mirror of
https://github.com/larvit/adf-codec.git
synced 2026-11-20 07:05:44 +01:00
Answer principles round 2: 1 🔴, 2 🟡 (0 misread); mutants killed, dead branches gone, data-* in its own module, linked images keep both targets, every URL sink named
This commit is contained in:
@@ -12,7 +12,7 @@
|
||||
|
||||
| ID | Release | Blocked by | Exempt | Item | L | E | I | R | S | Moves | Score |
|
||||
|---|---|---|---|---|---|---|---|---|---|---|---|
|
||||
| 142 | 0.3.0 | | security | **Settle in `docs/decisions.md`, weighing the pros and cons with the maintainer, whether `adfToHtml` writes a `javascript:`, `vbscript:`, `file:` or non-image `data:` URL as the ADF holds it.** | 2 | 2 | 2 | 4 | 3 | 6 by 3 | 4.5 |
|
||||
| 142 | 0.3.0 | | security | **Settle in `docs/decisions.md`, weighing the pros and cons with the maintainer, whether `adfToHtml` writes a `javascript:`, `vbscript:`, `file:` or non-image `data:` URL as the ADF holds it, in a link's `href`, an image's `src` and each link the carry element shows.** | 2 | 2 | 2 | 4 | 3 | 6 by 3 | 4.5 |
|
||||
| 131 | 0.3.0 | | | **Ship `htmlToAdf`, reading back exactly what `adfToHtml` writes and refusing any other HTML as `unmappable-html`.** | 4 | 1 | 2 | 5 | 7 | 3 by 3 | 0.6 |
|
||||
| 133 | 0.3.0 | 131 | | **Write mentions, emoji, dates, statuses and inline cards as semantic HTML in `adfToHtml` and read them back in `htmlToAdf`, in place of the carry element.** | 2 | 2 | 2 | 4 | 4 | 6 by 3 | 3.0 |
|
||||
| 132 | 0.3.0 | 131 | | **Write tables as `<table>` in `adfToHtml` and read them back in `htmlToAdf`, in place of the carry element.** | 2 | 2 | 2 | 4 | 5 | 6 by 4 | 2.4 |
|
||||
@@ -63,15 +63,18 @@
|
||||
|
||||
## Details
|
||||
|
||||
### 142. Settle in `docs/decisions.md`, weighing the pros and cons with the maintainer, whether `adfToHtml` writes a `javascript:`, `vbscript:`, `file:` or non-image `data:` URL as the ADF holds it.
|
||||
### 142. Settle in `docs/decisions.md`, weighing the pros and cons with the maintainer, whether `adfToHtml` writes a `javascript:`, `vbscript:`, `file:` or non-image `data:` URL as the ADF holds it, in a link's `href`, an image's `src` and each link the carry element shows.
|
||||
|
||||
The exposure: ADF from an author a consumer does not trust can hold a link's `href` or an external
|
||||
image's `url` of `javascript:…`. `adfToHtml` writes it into `href` or `src` as held
|
||||
(`docs/decisions.md` §HTML writes a URL as the ADF holds it, whatever its scheme). An export tool
|
||||
showing that HTML unsanitized in a browser runs the script when a reader follows the link.
|
||||
The exposure: ADF from an author a consumer does not trust can hold a `javascript:…` URL in a
|
||||
link's `href`, an external image's `url`, or a card's `url` or `data.url`. `adfToHtml` writes it as
|
||||
held into a link's `href` or an image's `src`, and into the `href` of each link the carry element
|
||||
shows: a carried node's link mark, a card and an external image (`docs/decisions.md` §HTML writes a
|
||||
URL as the ADF holds it, whatever its scheme). An export tool showing that HTML unsanitized in a
|
||||
browser runs the script when a reader follows the link.
|
||||
|
||||
Weigh writing the URL as held, leaving sanitizing to the consumer as for any HTML, against carrying
|
||||
such a link or image in the carry element, which keeps the URL in `data-adf`. cmark, the CommonMark
|
||||
Weigh writing the URL as held, leaving sanitizing to the consumer as for any HTML, against keeping
|
||||
it in `data-adf` alone. Carrying the node no longer does that, since the carry element links what
|
||||
it shows: the carry would also have to show such a link without its `href`. cmark, the CommonMark
|
||||
reference implementation, leaves `javascript:`, `vbscript:`, `file:` and `data:` other than a PNG,
|
||||
GIF, JPEG or WebP image out of its HTML by default; a browser reads a scheme after dropping tabs,
|
||||
line breaks and leading control characters. Say whether the markdown writers' links follow the
|
||||
@@ -237,7 +240,9 @@ A writer panel picks `<s>` or `<del>`.
|
||||
|
||||
### 135. Write media, media groups and captions as semantic HTML in `adfToHtml` and read them back in `htmlToAdf`, in place of the carry element.
|
||||
|
||||
A writer panel picks the spellings; an external image already has one from item 130.
|
||||
A writer panel picks the spellings; an external image already has one from item 130. Atlassian's
|
||||
editor puts `localId`, `width` and `widthType` on every `mediaSingle`, so every editor-written
|
||||
image rides the carry until this item.
|
||||
|
||||
### 136. Write underline, text and background colours, subscript, superscript, alignment and indentation as HTML in `adfToHtml` and read them back in `htmlToAdf`, in place of the carry element.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user