larvit/adf-codec
3
0
Fork 0
mirror of https://github.com/larvit/adf-codec.git synced 2026-11-12 19:58:28 +01:00
Code Activity

Answer prose round 1: 0 🔴, 2 🟡 (0 misread); say what insideRun's callers rely on, delete sharedRuns's comment, clear the termination comment

Browse Source
This commit is contained in:
Lilleman auf Larv
2026-11-03 21:54:29 +01:00
parent 84c45c30a5
commit 9e8df99db2
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/markdown/mark-spellings.ts
+1 -1
View File
@@ -44,7 +44,7 @@ export function isEmphasis(mark: AdfMark): boolean {
return markSpelling(mark.type)?.kind === 'emphasis' return markSpelling(mark.type)?.kind === 'emphasis'
} }
// spec/flavour.md, Marks. The writers and the portable reducer group runs alike only while both ask this. // spec/flavour.md, Marks. The portable reducer must ask this too, or it trims edge whitespace by runs the writers do not spell.
export function insideRun({ node, outer }: RunNode, mark: AdfMark): RunNode | undefined { export function insideRun({ node, outer }: RunNode, mark: AdfMark): RunNode | undefined {
const held = nodeMarks(node)[outer] const held = nodeMarks(node)[outer]
return held !== undefined && identicalMark(held, mark) ? { node, outer: outer + 1 } : undefined return held !== undefined && identicalMark(held, mark) ? { node, outer: outer + 1 } : undefined
src/markdown/portable/inline-reduction.ts
+1 -2
View File
@@ -162,7 +162,7 @@ function withMarks(leaf: AdfNode, marks: readonly AdfMark[]): AdfNode {
} }
export function trimmedEdges(leaves: readonly AdfNode[]): AdfNode[] { export function trimmedEdges(leaves: readonly AdfNode[]): AdfNode[] {
// Terminates: a pass that changes a leaf drops its edge whitespace or takes a mark off that whitespace, and merging adds neither. // Terminates: a pass that changes a leaf drops whitespace from the leaf's edge or takes a mark off that whitespace, and merging adds no whitespace or mark.
for (let current = leaves; ; ) { for (let current = leaves; ; ) {
const merged = withoutEdgeBreaks(mergeAdjacentText(current, joinsWhenEditorNormal)) const merged = withoutEdgeBreaks(mergeAdjacentText(current, joinsWhenEditorNormal))
let changed = false let changed = false
@@ -218,7 +218,6 @@ function edgeDepth(marks: readonly AdfMark[], neighbour: AdfNode | undefined, wh
return kept === 0 && lineEdge ? undefined : kept return kept === 0 && lineEdge ? undefined : kept
} }
// How many of the runs around a leaf holding `marks`, outermost first, hold `neighbour` too.
function sharedRuns(marks: readonly AdfMark[], neighbour: AdfNode): number { function sharedRuns(marks: readonly AdfMark[], neighbour: AdfNode): number {
let inside: RunNode | undefined = { node: neighbour, outer: 0 } let inside: RunNode | undefined = { node: neighbour, outer: 0 }
for (const [depth, mark] of marks.entries()) { for (const [depth, mark] of marks.entries()) {