From b695c4c88c3a50cf38ccaf06b2117bc8928d864b Mon Sep 17 00:00:00 2001 From: Lilleman auf Larv Date: Fri, 18 Sep 2026 23:14:37 +0200 Subject: [PATCH] Review nits: drop the spec's restated carry rule, the test's duplicate paths and todo.md's incident note --- README.md | 2 +- spec/flavour.md | 2 +- src/markdown/parse/markdown-to-adf.test.ts | 2 -- todo.md | 3 +-- 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index bcb8170..672bb20 100644 --- a/README.md +++ b/README.md @@ -102,7 +102,7 @@ emit refuses: | `unspellable-line-start` | a paragraph line begins with a code span whose backticks would read back as a code fence | put any text before the code span | | `unspellable-whitespace` | an `emoji`, `mention` or `status` holds a newline in the text its inline directive spells in the content slot | replace it with a space — an inline directive never spans lines | | `unsupported-nesting-depth` | blocks, marks, an attribute's JSON or a carried node's JSON nest past 500 levels | keep the ADF and pass the document over, or show it read-only; flatten the input where you are the one who wrote it | -| `unsupported-node-shape` | a node carries an attribute, value, argument or body its type does not take — or markdown writes as a directive a node or mark the flavour spells as CommonMark | write the shape the message names; `spec/flavour.md` lists every type's attributes and body | +| `unsupported-node-shape` | a node carries an attribute, value, argument or body its type does not take, or lacks one it needs — or markdown writes as a directive a node or mark the flavour spells as CommonMark | write the shape the message names; `spec/flavour.md` lists every type's attributes and body | ## The guarantees diff --git a/spec/flavour.md b/spec/flavour.md index e17ebb8..8ae3b80 100644 --- a/spec/flavour.md +++ b/spec/flavour.md @@ -474,7 +474,7 @@ the inline directive `!adf:link[text]{attrs}` only where CommonMark does not: an backslash, an entity reference, an angle bracket beside a space or opening a bare destination, a newline in the title), or a link opening a paragraph whose markdown spelling would read as a link reference definition. Every such spelling carries an `href`: a directive link CommonMark could -spell is a named error, and so is one spelling no `href`, the mark without one riding the carry. +spell is a named error, and so is one spelling none. - `border` — Attributes: `color` (string, `#rrggbb` or `#rrggbbaa`), `size` (number, 1–3). - `code`, `em`, `strike`, `strong` — Attributes: none. diff --git a/src/markdown/parse/markdown-to-adf.test.ts b/src/markdown/parse/markdown-to-adf.test.ts index 5410da5..ec6bf9f 100644 --- a/src/markdown/parse/markdown-to-adf.test.ts +++ b/src/markdown/parse/markdown-to-adf.test.ts @@ -996,8 +996,6 @@ test('names the href the directive link spells no value for', () => { assert.equal(content(markdownToAdf('!adf:link[a]\n')), named) assert.equal(content(markdownToAdf('!adf:link[a]{title=t}\n')), named) assert.equal(content(markdownToAdf('See !adf:link[a]{id=01a032c3-7a90-70c9-88f6-c60f710eda07}.\n')), named) - assert.equal(content(markdownToAdf('!adf:underline[!adf:link[a]{title=t}]\n')), named) - assert.deepEqual(path(markdownToAdf('Part.\n\nSee !adf:link[a]{title=t}.\n')), ['content', 1]) }) test('names the directive mark left without the content it wraps', () => { diff --git a/todo.md b/todo.md index bd16e9b..cd480da 100644 --- a/todo.md +++ b/todo.md @@ -8,8 +8,7 @@ milestone. A done item shrinks to its title here; its full text moves to `todo-h Start a session with: `Read AGENTS.md and todo.md, then do what todo.md's "Next session" says.` 1. `git fetch origin` first and read this file at `origin/main`, then branch off it, not the - worktree left behind: a checkout behind the remote reads a merged item as unchecked, which sent - this session at 14 after it had shipped. + worktree left behind: a checkout behind the remote reads a merged item as unchecked. 2. The first unchecked item in shipping order, per AGENTS.md §15 — or, where that item has no release, the planning chunk §15 describes. 3. In flight: nothing.