larvit/adf-codec
3
0
Fork 0
Code Pull Requests 1 Actions Activity

Read the inline nodes and the marks back, and keep the whitespace CommonMark does not strip #41

Merged
lilleman merged 5 commits from inline-nodes-read-back into main 2026-09-02 12:34:20 +02:00
Conversation 0 Commits 5 Files Changed 24
+394 -93
lilleman commented 2026-09-01 21:36:07 +02:00
Owner
Copy Link
Copy Source

3i. inline-nodes/ joins the parsing directories: the content slot's text attribute, the :text{text="…"} whitespace spelling, the four directive marks and their nesting order, and the markdown-spelled mark names as named errors.

Settled with the maintainer: :text reads back one run of spaces and tabs, or one run of newlines, and nothing else. The same read found a hole the other way — attemptLine refused a line edged with a vertical tab or a form feed, where CommonMark strips spaces and tabs alone — so that check narrows, and its last cause gone, the check goes with it.

3i. `inline-nodes/` joins the parsing directories: the content slot's `text` attribute, the `:text{text="…"}` whitespace spelling, the four directive marks and their nesting order, and the markdown-spelled mark names as named errors. Settled with the maintainer: `:text` reads back one run of spaces and tabs, or one run of newlines, and nothing else. The same read found a hole the other way — `attemptLine` refused a line edged with a vertical tab or a form feed, where CommonMark strips spaces and tabs alone — so that check narrows, and its last cause gone, the check goes with it.
lilleman added 1 commit 2026-09-01 21:36:07 +02:00
Read the inline nodes and the marks back, and keep the whitespace CommonMark does not strip
CI / gate (push) Successful in 9s
Details
01faa71914
lilleman added 1 commit 2026-09-01 22:11:23 +02:00
Answer the architecture pass: the seam attribute reading names, and the speller a third file copied
CI / gate (push) Successful in 8s
Details
f4e4d77fc1
lilleman added 1 commit 2026-09-01 22:35:09 +02:00
Answer the stability pass: the slot a line ending reached, and the text an image description dropped
CI / gate (push) Successful in 8s
Details
1429f4ce3c
lilleman added 1 commit 2026-09-01 23:04:27 +02:00
Name the position a directive name the other one spells belongs to
CI / gate (push) Successful in 8s
Details
5defa89b8d
lilleman added 1 commit 2026-09-02 12:28:23 +02:00
Answer the stability nits: the spellings a position hint names, and the fault its name owns
CI / gate (push) Successful in 9s
Details
df6b19601d
lilleman marked the pull request as ready for review 2026-09-02 12:34:12 +02:00
lilleman merged commit f93dda8697 into main 2026-09-02 12:34:20 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/adf-codec#41
Delete Branch "inline-nodes-read-back"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?