larvit/fejkdata
3
0
Fork 0
Code Pull Requests 1 Actions Activity

Check formatting on the latest Go only, the toolchain that defines it

Browse Source
This commit is contained in:
Lilleman auf Larv
2026-09-21 07:49:14 +02:00
committed by Lillem4n
parent ed25368b93
commit 1b5ed27406
3 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
README.md
+12 -4
View File
@@ -940,6 +940,13 @@ the Development section below, and who ships a register the four above then draw
- **Raising the lowest supported Go is a major.** A consumer building on it breaks,
which is the one test every rule above applies; Go's convention of a minor is not
followed.
- **The format check runs on the latest Go only.** `gofmt`'s output is the
toolchain's, not the code's: 1.27 stopped padding a map literal's values out to a
lone long key, so no source satisfies both it and 1.22's. A consumer on the lowest
supported Go depends on the code compiling and its tests passing there, which is
the `portable` stage, and never runs `gofmt` over this source, so the latest
toolchain alone defines the one canonical form goal 2 asks a reader to meet. Valid
while the lowest supported Go is not the latest.
- **The changelog heading is the one spelling of a release; CI cuts the tag.** A
tag pushed by hand is served by `go get` at once, so a tag whose commit lacks its
heading is burnt, not fixed. The heading on a gate-passed `main` commit is the
@@ -1367,12 +1374,13 @@ supported Go, and must pass before it can be merged — unless it changes none o
the files the build and its tests read, nor the workflow itself, in which case
it's skipped (see [Decisions](#decisions)). That build is the whole gate but the
changelog check, which CI runs against the PR base — vet, complexity, format check
and tests — so run it locally before pushing:
and tests — so run it locally before pushing. The lowest Go builds the `portable`
stage, all of that bar the format check:
```sh
docker build . # latest
docker build --build-arg GO_VERSION=1.22.12 . # lowest supported
GO_VERSION=1.22.12 docker compose run --rm test # the same tests, without the image build
docker build . # latest
docker build --build-arg GO_VERSION=1.22.12 --target portable . # lowest supported
GO_VERSION=1.22.12 docker compose run --rm test # the same tests, without the image build
```
A change to the shipped data re-pins [`testdata/shipped_shape.txt`](testdata/shipped_shape.txt)