larvit/fejkdata
3
0
Fork 0
Code Pull Requests 1 Actions Activity

Answer stability and product-owner: New's godoc says where the load lands, plainer Performance wording, regenerate before re-pinning, and no redundant sort

Browse Source
This commit is contained in:
Lilleman auf Larv
2026-10-03 17:52:29 +02:00
committed by Lillem4n
parent cc8797744b
commit 590681ed24
4 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
README.md
+6 -6
View File
@@ -815,9 +815,9 @@ The target is about a microsecond per value (goal 12).
Each file is parsed, validated and weight-indexed once, bar a table's name and parent Each file is parsed, validated and weight-indexed once, bar a table's name and parent
columns, which are mapped on the first `Fake` that selects by name or descends through columns, which are mapped on the first `Fake` that selects by name or descends through
it. With the shipped set alone, a category loads on the first call reaching it, with it. With the shipped set alone, `New` loads nothing: a category loads on the first call
every category it reads and every table linked to it, and `List` reads an index for what reaching it, with every category it reads and every table linked to it. Beside
has not loaded yet; beside a `--data-path`, every category loads in `New`. Proving the draw fences adds a pass over the loaded tree per `--data-path`, `WithDataPath` or `WithDataFS`, every category loads in `New`. Proving the draw fences adds a pass over the loaded tree per
fence, and walks what a render reads only where data holds a reference, so a set that fence, and walks what a render reads only where data holds a reference, so a set that
holds none pays for the passes alone. A `Fake` call then costs about what its output holds none pays for the passes alone. A `Fake` call then costs about what its output
costs: an unweighted pick is O(1) whatever the list's length, a weighted one costs: an unweighted pick is O(1) whatever the list's length, a weighted one
@@ -1020,9 +1020,9 @@ Goal 3 is scored by a panel of simulated readers, and [`AGENTS.md`](AGENTS.md) s
what the score asks of a pull request. Goal 5 is checked against simulated template what the score asks of a pull request. Goal 5 is checked against simulated template
writers from the Audience. writers from the Audience.
A change to the shipped data regenerates [`shippedindex.go`](shippedindex.go) with A change to the shipped data runs `generate` above first and commits
`generate` above, and re-pins [`testdata/shipped_shape.txt`](testdata/shipped_shape.txt) [`shippedindex.go`](shippedindex.go) with the change, then re-pins
in its own commit: [`testdata/shipped_shape.txt`](testdata/shipped_shape.txt) in its own commit:
```sh ```sh
REPIN=1 docker compose run --rm --user "$(id -u):$(id -g)" test REPIN=1 docker compose run --rm --user "$(id -u):$(id -g)" test
fejkdata.go
+2 -1
View File
@@ -86,7 +86,8 @@ func WithoutShippedData() Option {
// in order with the last winning a name clash. Each JSON file becomes a category // in order with the last winning a name clash. Each JSON file becomes a category
// named after the file (address.json -> "address") and each subdirectory a // named after the file (address.json -> "address") and each subdirectory a
// namespace segment. It errors on a missing directory, invalid JSON, invalid data, // namespace segment. It errors on a missing directory, invalid JSON, invalid data,
// or no data at all. // or no data at all. The shipped set alone loads each category on the first call
// reaching it; beside WithDataPath or WithDataFS, every category loads here.
func New(opts ...Option) (*Generator, error) { func New(opts ...Option) (*Generator, error) {
c := config{shipped: true} c := config{shipped: true}
for _, opt := range opts { for _, opt := range opts {
shipped.go
-2
View File
@@ -5,7 +5,6 @@ import (
"fmt" "fmt"
"io/fs" "io/fs"
"path" "path"
"sort"
"strings" "strings"
) )
@@ -120,7 +119,6 @@ func loadShipped(root *folder, wanted []unloadedCategory) {
if len(sites) == 0 { if len(sites) == 0 {
return return
} }
sort.Slice(sites, func(i, j int) bool { return sites[i].path < sites[j].path })
if err := categoryBinding(sites, root.children).bind(); err != nil { if err := categoryBinding(sites, root.children).bind(); err != nil {
panic(internalError("binding shipped categories: %v; after a change under data/, regenerate shippedindex.go", err)) panic(internalError("binding shipped categories: %v; after a change under data/, regenerate shippedindex.go", err))
} }
shipped_test.go
+1 -1
View File
@@ -60,7 +60,7 @@ func TestShippedIndexIsCurrent(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
if string(got) != string(want) { if string(got) != string(want) {
t.Fatalf("%s is stale for data/; regenerate it with go generate", shippedIndexFile) t.Fatalf("%s is stale for data/; regenerate it: docker compose run --rm --user \"$(id -u):$(id -g)\" generate", shippedIndexFile)
} }
} }