From 70fdfbd591ad2ce9c892403703a79a5a928d5656 Mon Sep 17 00:00:00 2001 From: Lilleman auf Larv Date: Mon, 12 Oct 2026 17:45:46 +0200 Subject: [PATCH] Answer prose round 1: the README lists the release tooling's tests in the gate, and the decision says the size test checks the premise --- README.md | 8 ++++---- docs/decisions.md | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 29f4344..304c9d9 100644 --- a/README.md +++ b/README.md @@ -1145,10 +1145,10 @@ docker compose run --rm --user root --entrypoint chown test -R "$(id -u):$(id -g Every pull request runs `docker build .` against both the latest and the lowest supported Go, and must pass before it can be merged — unless it changes none of the files the build and its tests read, nor the workflow itself, in which case -it's skipped. That build is the whole gate but the -changelog check, which CI runs against the PR base — vet, complexity, format check -and tests — so run it locally before pushing. The lowest Go builds the `portable` -stage, all of that bar the format check and the release tooling's tests: +it's skipped. That build is the whole gate except the changelog check, which CI +runs against the PR base: vet, complexity, the format check, the Go tests and the +release tooling's tests. Run it locally before pushing. The lowest Go builds the +`portable` stage, which skips the format check and the release tooling's tests: ```sh docker build . # latest diff --git a/docs/decisions.md b/docs/decisions.md index 0df151d..a921a1f 100644 --- a/docs/decisions.md +++ b/docs/decisions.md @@ -151,7 +151,7 @@ A directory a machine happens to have would make `--seed 42` machine-dependent; - The CLI is a library call. One exported list names every shipped package, and `fejkdata`'s own `main` passes it to that call. The list lives in a package of its own, so a library importing the core links no data it did not import. A custom CLI is the same few lines with other modules added. No API and no flag exists only for custom CLIs; `Main` tells one apart only by its build info and file name, so its help and errors carry its name and its `--version` its own module's version beside fejkdata's. The maintainer chose so on 2026-10-11. - The help's examples and its hint for an empty stdin read no data, so each renders in any custom CLI, and both point to `--list` for the paths. "Shipped data", in `--no-shipped-data` and in `-d`'s help, names the modules passed to `Main`, a custom CLI's own included. The audience bench's custom-CLI builder seat ruled so on 2026-10-11, before 0.1.0. -Valid while the shipped data stays under 100 MiB, which `TestShippedDataStaysUnder100MiB` holds: `go get` fetches the whole Go module, and the `go` command refuses a Go module zip over 500 MiB (`MaxZipFile` in `golang.org/x/mod/zip`). Past it, `todo.md` item 193 moves the largest packages into nested Go modules that keep their import paths, each requiring the core release that drops the package, so no build sees it twice. +Valid while the shipped data stays under 100 MiB, which `TestShippedDataStaysUnder100MiB` checks: `go get` fetches the whole Go module, and the `go` command refuses a Go module zip over 500 MiB (`MaxZipFile` in `golang.org/x/mod/zip`). Past it, `todo.md` item 193 moves the largest packages into nested Go modules that keep their import paths, each requiring the core release that drops the package, so no build sees it twice. ## A shipped package's folder spells its namespace, its Go name is that namespace in lower case without separators, and its manifest mounts it with `namespace`