larvit/fejkdata
3
0
Fork 0
Code Pull Requests 1 Actions Activity

Order spilled pins by path, and correct todo.md's inline array name

Browse Source
This commit is contained in:
Lilleman auf Larv
2026-09-24 10:02:10 +02:00
committed by Lillem4n
parent bbcb259b02
commit a0fc1bc4f1
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pins.go
+2 -2
View File
@@ -68,7 +68,7 @@ func (p *pinSet) pin(t *table, r int) {
} }
} }
// each calls fn for every pinned row, in pin order, the spilled ones by table name. // each calls fn for every pinned row, in pin order, the spilled ones by path.
func (p *pinSet) each(fn func(t *table, r int)) { func (p *pinSet) each(fn func(t *table, r int)) {
for _, q := range p.inline[:p.n] { for _, q := range p.inline[:p.n] {
fn(q.t, q.row) fn(q.t, q.row)
@@ -77,7 +77,7 @@ func (p *pinSet) each(fn func(t *table, r int)) {
for t := range p.spill { for t := range p.spill {
spilled = append(spilled, t) spilled = append(spilled, t)
} }
sort.Slice(spilled, func(i, j int) bool { return spilled[i].category < spilled[j].category }) sort.Slice(spilled, func(i, j int) bool { return spilled[i].path < spilled[j].path })
for _, t := range spilled { for _, t := range spilled {
fn(t, p.spill[t]) fn(t, p.spill[t])
} }
todo.md
+4 -3
View File
@@ -49,8 +49,9 @@ This round, in order:
`entered`'s `pinsAncestors` flag stop restating `walkTable`'s draw condition and `entered`'s `pinsAncestors` flag stop restating `walkTable`'s draw condition and
`rowOf`'s ancestor rule: a change to how a render draws rows still leaves the fence `rowOf`'s ancestor rule: a change to how a render draws rows still leaves the fence
proving the old rule. Hold a row rendered whole in `drawAt` beside `drawn`, so proving the old rule. Hold a row rendered whole in `drawAt` beside `drawn`, so
`pinSet` holds only what `pin` pins and `alternatives` needs no exception. Needs the `pinSet` holds only what `pin` pins and `alternatives` needs no exception. Settle a
item above. cell of a municipality drawn whole beside a path pinning a region it is not in. Needs
the item above.
- Register a transform once: `transforms` restates the `lowercase`, `uppercase` and - Register a transform once: `transforms` restates the `lowercase`, `uppercase` and
`ascii` entries in `builtins`, and `valueProof.template` classifies by the first while `ascii` entries in `builtins`, and `valueProof.template` classifies by the first while
render calls the second. Derive the numeric builtins `valueProof.template` lists in render calls the second. Derive the numeric builtins `valueProof.template` lists in
@@ -290,7 +291,7 @@ because pairing a street with its exact postnummer rewrites shipped rows.
- Hold every change the charter says owes a `CHANGELOG.md` entry to one in CI: the - Hold every change the charter says owes a `CHANGELOG.md` entry to one in CI: the
check covers `data` and `testdata/shipped_shape.txt` alone, where `AGENTS.md` adds a check covers `data` and `testdata/shipped_shape.txt` alone, where `AGENTS.md` adds a
flag, an exit code, an exported name, a fence, a builtin and the lowest Go. flag, an exit code, an exported name, a fence, a builtin and the lowest Go.
- Measure the allocation gate over the shipped `geo` trees too: `pinSet.pins [8]` is sized - Measure the allocation gate over the shipped `geo` trees too: `pinSet.inline [8]` is sized
for them, and `perf_test.go` checks a synthetic five-deep tree only. for them, and `perf_test.go` checks a synthetic five-deep tree only.
- Make a named draw group's hold lazy, `&hold{}` in `renderScope.hold`: it escapes - Make a named draw group's hold lazy, `&hold{}` in `renderScope.hold`: it escapes
to the heap anyway, so its two eager maps buy no stack and cost two allocations per to the heap anyway, so its two eager maps buy no stack and cost two allocations per