From b93d47eeb28641ea90f5e2dfaef836edfde2a508 Mon Sep 17 00:00:00 2001 From: Lilleman auf Larv Date: Mon, 5 Oct 2026 00:44:17 +0200 Subject: [PATCH] Answer stability round 2: let the selector be the assertion --- data_test.go | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/data_test.go b/data_test.go index 1e9a38a..6852afc 100644 --- a/data_test.go +++ b/data_test.go @@ -270,9 +270,7 @@ func TestShippedPersonNames(t *testing.T) { seen[fake(t, f, locale+".sex[f].first-name")] = true got := fakeTemplate(t, f, `{/`+locale+`.person.first}|{/`+locale+`.person.sex}`) first, sex, _ := strings.Cut(got, "|") - if v := fake(t, f, locale+".sex["+sex+"].first-name["+first+"]"); v != first { - t.Fatalf("%s: %q: %q is not a %s name", locale, got, first, sex) - } + fake(t, f, locale+".sex["+sex+"].first-name["+first+"]") } if len(seen) < 300 || !seen["Anna"] && locale == "sv_SE" || !seen["Mary"] && locale == "en_US" { t.Fatalf("%s female first names: %d distinct in 2000, want a weighted register", locale, len(seen)) @@ -290,14 +288,10 @@ func TestShippedPersonIsOneNamedPick(t *testing.T) { got := fakeTemplate(t, f, `{/`+locale+`.person as a}{/`+locale+`.person as b}{a.first}|{a.sex}|{a.prefix}|{b.first}|{b.sex}`) parts := strings.Split(got, "|") for _, p := range [][2]string{{parts[0], parts[1]}, {parts[3], parts[4]}} { - if v := fake(t, f, locale+".sex["+p[1]+"].first-name["+p[0]+"]"); v != p[0] { - t.Fatalf("%s: %q: %q is not a %s name", locale, got, p[0], p[1]) - } + fake(t, f, locale+".sex["+p[1]+"].first-name["+p[0]+"]") } if title := strings.TrimSpace(parts[2]); title != "" && locale == "en_US" { - if v := fake(t, f, "en_US.sex["+parts[1]+"].title["+title+"]"); v != title { - t.Fatalf("%q: %q is not a %s title", got, title, parts[1]) - } + fake(t, f, "en_US.sex["+parts[1]+"].title["+title+"]") } apart = apart || parts[0] != parts[3] }