Answer prose round 2: the maintainer's approval beside the list it covers, Facts and compileInto docs naming what they read, and "the folder that dir names"

This commit is contained in:
2026-10-05 16:01:18 +02:00
committed by Lillem4n
parent 643efc8650
commit c55b296385
5 changed files with 8 additions and 8 deletions
+2 -2
View File
@@ -49,7 +49,7 @@ func (s Source) labelled(p string) string {
return path.Join(s.label, p)
}
// dirPath is the folder dir names, as fsys spells it.
// dirPath is the folder that dir names, as fsys spells it.
func (s Source) dirPath(dir []string) string {
if p := path.Join(append([]string{s.base}, dir...)...); p != "" {
return p
@@ -77,7 +77,7 @@ func (s Source) Walk(compile func(Category) error) error {
return err
}
// walkDir walks the folder dir names, and reports whether it handed over any category.
// walkDir walks the folder that dir names, and reports whether it handed over any category.
func (s Source) walkDir(dir []string, compile func(Category) error) (bool, error) {
full := s.dirPath(dir)
entries, err := fs.ReadDir(s.fsys, full)
+1 -1
View File
@@ -71,7 +71,7 @@ func TestReadRowsReadsOnlyAFileBesideTheCategory(t *testing.T) {
return err
}
if _, err := c.ReadRows("x.tsv"); err == nil || err.Error() != "rows names x.tsv, which is not beside it in "+map[string]string{"t": "lbl", "u": "lbl/sub"}[c.Name] {
t.Errorf("ReadRows(x.tsv) = %v, want the file named missing beside %s", err, c.Name)
t.Errorf("ReadRows(x.tsv) = %v, want an error saying x.tsv is not beside %s", err, c.Name)
}
return nil
})
+2 -2
View File
@@ -14,8 +14,8 @@ import (
"github.com/larvit/fejkdata/internal/invariant"
)
// Facts is what a proof knows of every render of a node: bounds on the number each
// reads as, and per datatype why some render's text is not one ("" when none).
// Facts is what a proof knows of every render of a node: bounds on the number each render
// reads as, and, per datatype, why some render's text is not of it ("" when every render's is).
type Facts struct {
Lo, Hi float64
NonZero float64 // every value is at least this far from zero; 0 when one can be zero