Answer prose round 1: 0 🔴, 10 🟡 (0 misread); define code health, restore the topic index, give each decision a premise of its own
CI / full-gate (push) Successful in 3m39s

This commit is contained in:
2026-11-08 21:09:19 +01:00
parent 4c8ba083ce
commit 3179be0d11
8 changed files with 88 additions and 62 deletions
+3 -3
View File
@@ -10,9 +10,9 @@ export interface Gate {
session?: boolean; // any signed-in user, no grant to hold; anonymous is sent to /login
}
// A gate naming none of the three allows everyone. Discovery refuses one on a route or a plugin's
// nav node, so only the header nodes `config/menu.ts`'s `groups` builds get here without a gate,
// and failing closed would hide every section an operator grouped.
// A gate naming none of the three allows everyone. Discovery refuses one on a plugin's route, nav
// node or profile-menu entry, so only the header nodes `config/menu.ts`'s `groups` builds get here
// without a gate, and failing closed would hide every section an operator grouped.
export function allows(gate: Gate, user: User | null): boolean {
if (gate.public === true) return true;
if (gate.session === true) return user !== null;
+3 -3
View File
@@ -31,9 +31,9 @@ test("init SQL gives each Ory service its own database, and leaves plugin databa
}
});
// docs/decisions.md records that the driver runs the provisioning DDL in bootstrap and nothing
// else. A single value imported from the wrong module puts it in web's graph without changing
// behaviour, so nothing but this would notice.
// A single value imported from the wrong module puts the driver in web's graph without changing
// behaviour, so nothing but this would notice (docs/decisions.md → "Plugin storage hands over
// credentials, not a client").
test("the Postgres driver reaches bootstrap only, never web's import graph", () => {
const files = sourceFiles();
assert.ok(files.length > 40, "walks the source tree");
+2 -1
View File
@@ -20,7 +20,8 @@ import { buildCredentials, storagePluginIds, type StorageCredentials } from "./p
const config = loadConfig(); // validates the env (incl. enforced secrets) — fails loud at boot
// The storage secret is in `config` now, so drop it from the environment before ANY plugin code
// runs: a plugin module's top level evaluates during discovery, long before onBoot. Defence in
// depth, not a boundary (docs/decisions.md) — and only ever move this line earlier, never later.
// depth, not a boundary (docs/decisions.md → "The trust boundary is the `web` process, not the
// plugin") — and only ever move this line earlier, never later.
delete process.env["PLUGIN_DB_SECRET"];
// App-level logger: structured, OTLP-capable when OTLP_ENDPOINT is set. The hot path clones it
// per request for access logging + a trace span (src/http/request-tracking.ts); console-only otherwise.