From 437a2e8580df77402a5116521479164303bcc28d Mon Sep 17 00:00:00 2001
From: Lilleman auf Larv <lilleman@larvit.se>
Date: Sat, 31 Oct 2026 08:41:59 +0100
Subject: [PATCH] =?UTF-8?q?Answer=20stability=20round=201:=200=20?=
 =?UTF-8?q?=F0=9F=94=B4,=203=20=F0=9F=9F=A1=20(0=20misread);=20pin=20dashb?=
 =?UTF-8?q?oard=20heading=20and=20branding,=20fix=20stale=20comment?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 README.md             | 4 ++--
 src/http/app.test.ts  | 2 ++
 src/ui/chrome.test.ts | 9 ++++++++-
 src/ui/chrome.ts      | 4 +---
 views/index.ejs       | 6 ++----
 5 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index c02d72d..8e6a230 100644
--- a/README.md
+++ b/README.md
@@ -1825,8 +1825,8 @@ src/                 The app — strict tsc, no build step. *.test.ts sit beside
   plugin-host/       plugin.ts (the contract) · plugin-api.ts (the `@plainpages/plugin-api` barrel) · system.ts
                      (ctx.system) · discovery · router · hooks · view-resolver · storage (the rules) ·
                      storage-provisioning (the DDL; bootstrap-only, holds the driver)
-  ui/                chrome (the one global menu) · nav (composeNav) ·
-                     menu-config (`#menu-config`) · icons (lucide sprite builder) · list-query · paginate
+  ui/                chrome (`ctx.chrome`: menu, brand, user) · nav (composeNav) · menu-config
+                     (`#menu-config`) · icons (lucide sprite builder) · list-query · paginate
 
 plugin-api/          The `@plainpages/plugin-api` package — the author barrel, linked into /node_modules
 views/               Core EJS in the one app shell: home, index, auth, oauth-consent, error, 403/404/500/503,
diff --git a/src/http/app.test.ts b/src/http/app.test.ts
index 706c227..591f059 100644
--- a/src/http/app.test.ts
+++ b/src/http/app.test.ts
@@ -65,6 +65,8 @@ test("the dashboard at /dashboard: the instructional starter in the unified shel
   assert.match(html, /<aside class="sidebar"/);
   // The default is a short instructional starter, not a mock-data list.
   assert.match(html, /Starter dashboard/);
+  assert.match(html, /<h1 class="page-title">Dashboard<\/h1>/); // the topbar heading …
+  assert.match(html, /<nav class="crumbs"[^>]*>\s*<span>Dashboard<\/span>/); // … and its breadcrumb
   assert.match(html, /export default definePlugin/); // shows how to replace it from a plugin
   assert.doesNotMatch(html, /<form class="filters"/); // the old mock People list is gone
   assert.doesNotMatch(html, /Avery Kline/);
diff --git a/src/ui/chrome.test.ts b/src/ui/chrome.test.ts
index 87b79fd..fc6210e 100644
--- a/src/ui/chrome.test.ts
+++ b/src/ui/chrome.test.ts
@@ -75,8 +75,15 @@ test("branding logo + default theme flow through when set", () => {
   assert.equal(chrome.theme, "dark");
 });
 
+test("branding name and sub are translated; an unknown key renders as itself", () => {
+  const t = (key: string): string => (key === "brand.sub" ? "Undertitel" : key);
+  const chrome = buildPluginChrome({ menu: { branding: { name: "Acme", sub: "brand.sub" }, override: {} }, t });
+  assert.equal(chrome.brand.name, "Acme");
+  assert.equal(chrome.brand.sub, "Undertitel");
+  assert.equal(buildPluginChrome({ menu: { branding: { name: "Acme" }, override: {} } }).brand.sub, undefined);
+});
+
 test("shellUser derives the profile from the real user; anonymous → Guest", () => {
   assert.deepEqual(shellUser(null), { email: "", initials: "G", name: "Guest" });
-  // Real user: name = email local part, email kept, initials = first two letters of the local part.
   assert.deepEqual(shellUser({ email: "ada@example.com", id: "u1", permissions: [] }), { email: "ada@example.com", initials: "AD", name: "ada" });
 });
diff --git a/src/ui/chrome.ts b/src/ui/chrome.ts
index d5f42fb..82e433d 100644
--- a/src/ui/chrome.ts
+++ b/src/ui/chrome.ts
@@ -70,8 +70,7 @@ export function buildPluginChrome(opts: ChromeOptions): PageChrome {
   };
 }
 
-// The User carries no display name (the JWT holds only id/email/permissions), so the profile shows
-// the email's local part as the name; anonymous ⇒ "Guest".
+// The JWT holds only id/email/permissions, so the profile name is the email's local part.
 export function shellUser(user: User | null | undefined, t: Translate = ENGLISH): ShellUser {
   if (!user) {
     const guest = t("shell.guest");
@@ -81,7 +80,6 @@ export function shellUser(user: User | null | undefined, t: Translate = ENGLISH)
   return { email: user.email, initials: (local.slice(0, 2) || "U").toUpperCase(), name: local };
 }
 
-// `name`/`sub` pass through `t`, so a catalog key is translated and an operator's own wording renders as written.
 function branding(menu: MenuConfig, t: Translate): { logo?: string; name: string; sub?: string; theme?: string } {
   const b = menu.branding;
   return {
diff --git a/views/index.ejs b/views/index.ejs
index b5a9e53..7e4f14f 100644
--- a/views/index.ejs
+++ b/views/index.ejs
@@ -1,8 +1,6 @@
 <%#
-  Dashboard: the gated post-login app home. The built-in default is a short instructional
-  starter — what /dashboard is and how to replace it from a plugin. Composes the app shell (the one
-  global menu via model.nav) around the prose. A plugin owns the real dashboard via a `dashboard`
-  handler; this renders until then. Data: chrome (PageChrome).
+  The built-in /dashboard starter, shown until a plugin's `dashboard` handler replaces it.
+  Data: chrome (PageChrome).
 %><%
   const nav = include("partials/nav-tree", { nodes: chrome.nav });
   // These four messages carry markup (<code> spans), so they render raw — the documented