Answer prose round 1: 0 🔴, 4 🟡 (0 misread); document the e2e typecheck, tighten comments and changelog

2026-10-31 08:24:18 +01:00
parent cd46c77332
commit 4e7d897516
7 changed files with 12 additions and 9 deletions
@@ -53,8 +53,8 @@ docker compose build web
 step "Typecheck"
 docker compose run --rm --no-deps web npm run typecheck

-# The specs import @playwright/test, which only the runner image carries, so the host's tsc can't
-# resolve them: typecheck them in that image. --no-deps skips web and Ory; any suite's file builds it.
+# The specs import @playwright/test, which only the runner image installs, so they typecheck there
+# rather than in the web image. --no-deps skips web; the visual file just names the e2e service.
 step "Typecheck e2e-tests"
 docker compose -f compose.yml -f e2e-tests/compose.visual.yml run --user "$(id -u):$(id -g)" --rm --no-deps --build e2e npm run typecheck