Architecture review fixes: partials carry the locale, mountable locales/, shared core words

examples/plugins/scheduling/i18n/en-US.ts

@@ -5,13 +5,11 @@
 import type { PluralMessage } from "#plugin-api";
 
 const messages = {
-  "scheduling.cancel": "Cancel",
   "scheduling.field.assignee": "Assignee",
   "scheduling.field.end": "End",
   "scheduling.field.start": "Start",
   "scheduling.field.title": "Shift title",
   "scheduling.filter.label": "Filter shifts",
-  "scheduling.filter.search": "Search",
   "scheduling.filter.searchLabel": "Search shifts",
   "scheduling.filter.searchPlaceholder": "Search title or assignee…",
   "scheduling.form.submit": "Create shift",

examples/plugins/scheduling/i18n/sv-SE.ts

@@ -1,13 +1,11 @@
 import type { SchedulingMessages } from "./en-US.ts";
 
 const messages: SchedulingMessages = {
-  "scheduling.cancel": "Avbryt",
   "scheduling.field.assignee": "Tilldelad",
   "scheduling.field.end": "Slut",
   "scheduling.field.start": "Start",
   "scheduling.field.title": "Passets namn",
   "scheduling.filter.label": "Filtrera pass",
-  "scheduling.filter.search": "Sök",
   "scheduling.filter.searchLabel": "Sök pass",
   "scheduling.filter.searchPlaceholder": "Sök på namn eller person…",
   "scheduling.form.submit": "Skapa pass",

examples/plugins/scheduling/shifts.test.ts

@@ -4,14 +4,14 @@ import { Readable } from "node:stream";
 import test from "node:test";
 // Import only from the #plugin-api barrel — the same contract boundary shifts.ts uses (the host may
 // refactor any deeper src/* freely behind it); the test models the dev/test story the contract preaches.
-import { createTranslator, GuardError, Log, type PageChrome, type RequestContext, type RouteResult } from "#plugin-api";
+import { englishTranslator, GuardError, Log, type PageChrome, type RequestContext, type RouteResult } from "#plugin-api";
 import enUS from "./i18n/en-US.ts";
 import {
   assertHttpUrl, buildFormModel, createShift, createUpstream, listShifts, newShiftForm, overview, readInput,
   SHIFTS_PATH, type Shift, type ShiftInput, type ShiftsUpstream, UpstreamError, validate,
 } from "./shifts.ts";
 
-const t = createTranslator({ catalogs: [enUS], locale: "en-US" }); // this plugin's own catalog, as the host would pass it
+const t = englishTranslator(enUS); // this plugin's catalog then the host's, as the host would chain them
 const CHROME: PageChrome = { brand: { name: "Test" }, csrfToken: "tok", nav: [], signInHref: "/login", user: { email: "", initials: "T", name: "Tester" } };
 
 function fakeCtx(opts: { body?: string; permissions?: string[]; url?: string; verifyCsrf?: (s: string | null | undefined) => boolean } = {}): RequestContext {

examples/plugins/scheduling/shifts.ts

@@ -6,12 +6,13 @@
 // pure functions against a mock upstream with no network (README.md → Local dev & test story).
 
 // One import from the host's #plugin-api barrel — the stable author surface (see README.md → Building plugins).
-import { can, createTranslator, CSRF_FIELD, GuardError, type PageChrome, parseListQuery, readFormBody, type RouteHandler, type Translate, tracedFetch } from "#plugin-api";
+import { can, CSRF_FIELD, englishTranslator, GuardError, type PageChrome, parseListQuery, readFormBody, type RouteHandler, type Translate, tracedFetch } from "#plugin-api";
 import enUS from "./i18n/en-US.ts";
 
-// The plugin's own English, for a view model built outside a request (its unit tests). At runtime a
-// handler passes ctx.t, which reads this plugin's catalog for the visitor's locale first.
-const EN: Translate = createTranslator({ catalogs: [enUS], locale: "en-US" });
+// The plugin's own English (its catalog, then the host's), for a view model built outside a request:
+// its unit tests. At runtime a handler passes ctx.t, which reads this catalog in the visitor's
+// locale first, then the host's.
+const EN: Translate = englishTranslator(enUS);
 
 export const SCHEDULING_PATH = "/scheduling"; // the plugin's public overview page
 export const SHIFTS_PATH = "/scheduling/shifts";
@@ -102,10 +103,10 @@ export function buildListModel(opts: { canWrite: boolean; chrome: PageChrome; er
     count: t("scheduling.shifts.count", { count: opts.shifts.length }),
     ...(opts.error ? { error: opts.error } : {}),
     filterBar: {
-      applyLabel: t("scheduling.filter.search"),
+      applyLabel: t("filter.search"),
       clearHref: SHIFTS_PATH,
       label: t("scheduling.filter.label"),
-      pills: opts.q ? [{ label: t("scheduling.filter.search"), remove: SHIFTS_PATH, value: opts.q }] : [],
+      pills: opts.q ? [{ label: t("filter.search"), remove: SHIFTS_PATH, value: opts.q }] : [],
       rows: [[
         { label: t("scheduling.filter.searchLabel"), name: "q", placeholder: t("scheduling.filter.searchPlaceholder"), type: "search", value: opts.q },
         { type: "spacer" },
@@ -139,7 +140,7 @@ export function buildFormModel(opts: { chrome: PageChrome; errors?: Record<strin
       action: SHIFTS_PATH,
       cancelHref: SHIFTS_PATH,
       csrfToken: opts.chrome.csrfToken,
-      cancelLabel: t("scheduling.cancel"),
+      cancelLabel: t("common.cancel"),
       fields: [
         field({ icon: "i-cal", id: "title", label: t("scheduling.field.title"), value: v.title ?? "" }),
         field({ icon: "i-user", id: "assignee", label: t("scheduling.field.assignee"), value: v.assignee ?? "" }),