File asset caching for 0.4.21 and drop the page-cache question
CI / full-gate (push) Successful in 4s
CI / full-gate (push) Successful in 4s
This commit is contained in:
@@ -6,7 +6,7 @@
|
||||
|
||||
`Bar = 1`
|
||||
|
||||
`Next ID = 34`
|
||||
`Next ID = 35`
|
||||
|
||||
## Items
|
||||
|
||||
@@ -24,6 +24,7 @@
|
||||
| 32 | 0.4.21 | 29, 30 | | **Fail the gate on a stylesheet feature the browser floor lacks, unless it is guarded.** | 3 | 1 | 1 | 3 | 4 | code health by 2 | 6.0 |
|
||||
| 27 | 0.4.21 | | | **Inset the scheduling example's lead text, shift count, alerts and call-to-action by `--pad-x`, like the bars around them.** | 1 | 2 | 1 | 2 | 1 | 9 by 2, 2 by 1 | 4.8 |
|
||||
| 20 | 0.4.21 | | | **Redirect an anonymous hit on a session-needing flow page to sign-in, instead of a 500.** | 2 | 2 | 2 | 4 | 3 | 2 by 4 | 4.2 |
|
||||
| 34 | 0.4.21 | | | **Send `Cache-Control` and a validator on static assets, so a browser or CDN revalidates them with a 304 instead of refetching.** | 2 | 2 | 2 | 4 | 3 | 8 by 3 | 3.0 |
|
||||
| 4 | 0.4.21 | | | **Refuse a permission save whose baseline no longer matches Keto, so concurrent edits are not silently lost.** | 2 | 2 | 2 | 4 | 4 | 2 by 4 | 2.8 |
|
||||
| 7 | 0.4.21 | | | **Confirm a successful permission save, and report a partial failure instead of hiding it.** | 2 | 2 | 2 | 4 | 4 | 2 by 4 | 2.8 |
|
||||
| 22 | 0.4.21 | | | **Offer a `users:read` holder a View row action on the users list, not Edit.** | 2 | 2 | 1 | 3 | 3 | 2 by 2 | 2.1 |
|
||||
@@ -31,7 +32,6 @@
|
||||
| 1 | 0.4.21 | | owner | **Publish every release to Docker Hub, and give the Hub page its short description.** | 3 | 3 | 2 | 6 | 5 | 1 by 3 | 1.3 |
|
||||
| 13 | 0.4.21 | | | **Accept a verification code pasted with surrounding whitespace.** | 4 | 2 | 3 | 7 | 7 | 2 by 8 | 1.0 |
|
||||
| 19 | 0.5.0 | | question | **Run the documented Docker commands on macOS and fix whatever misbehaves.** | 2 | 2 | 1 | 3 | 3 | 1 by 3 | 3.3 |
|
||||
| 33 | 0.5.0 | | question | **Decide whether any public page gets a shared-cache `Cache-Control`, now that the host sends `private, no-store` on every page.** | 2 | 3 | 4 | 7 | 3 | 8 by 2 | 2.0 |
|
||||
| 16 | 0.5.0 | | question | **Decide whether the single Keto `Resource` namespace splits into per-domain namespaces.** | 3 | 2 | 3 | 6 | 6 | 7 by 2 | 0.5 |
|
||||
| 6 | 0.5.0 | | | **Warn at discovery when a route or nav node gates on a permission no plugin declares.** | 2 | 1 | 1 | 2 | 2 | 7 by 3, 9 by 3 | 8.0 |
|
||||
| 23 | 0.5.0 | | | **Give list pages one view-model helper from query to pagination, instead of ~40 hand-written lines each.** | 3 | 1 | 2 | 4 | 5 | 1 by 4, 9 by 2, code health by 3 | 7.9 |
|
||||
@@ -97,6 +97,18 @@ The fix belongs in `examples/plugins/scheduling/public/scheduling.css`; check ea
|
||||
session. `/settings` stays `public`, since recovery lands there with a Kratos session but no app JWT;
|
||||
a 401 should redirect to `/login` with the page as `return_to`. Add the missing E2E.
|
||||
|
||||
### 34. Send `Cache-Control` and a validator on static assets, so a browser or CDN revalidates them with a 304 instead of refetching.
|
||||
|
||||
`src/http/static.ts` answers every `/public/*` and plugin static file with only `content-length`
|
||||
and `content-type`, so browsers cache heuristically and a CDN or proxy is told nothing. Add
|
||||
`Cache-Control: public` with a short `max-age`, plus an `ETag` or `Last-Modified`, and answer a
|
||||
matching `If-None-Match` / `If-Modified-Since` with 304 on GET and HEAD. Asset URLs carry no content
|
||||
hash, so a long `max-age` or `immutable` would strand visitors on stale CSS after an upgrade; hashing
|
||||
them is a larger change to the views and out of scope. Pages stay `private, no-store`
|
||||
(`src/http/app.ts`): the static branch returns before that header is set. Write the unit test in
|
||||
`src/http` first, with expected values from this item. State the choice once in a comment in
|
||||
`static.ts`, and in one README line where operators read about caching and CDNs.
|
||||
|
||||
### 4. Refuse a permission save whose baseline no longer matches Keto, so concurrent edits are not silently lost.
|
||||
|
||||
Sketch: post the rendered set as a hidden baseline; when it no longer matches Keto, re-render with
|
||||
@@ -149,15 +161,6 @@ test covers. Code entry has no E2E coverage today.
|
||||
Needs a Mac. Two suspects, both from `--user "$(id -u):$(id -g)"`: a macOS `id -g` is `20`, which is
|
||||
`dialout` inside the noble image, and Docker Desktop remaps bind-mount ownership in its VM.
|
||||
|
||||
### 33. Decide whether any public page gets a shared-cache `Cache-Control`, now that the host sends `private, no-store` on every page.
|
||||
|
||||
Every non-asset response is `private, no-store`. The built-in signed-out `/` and its signed-in
|
||||
variant share one URL, so a shared cache keyed on URL and `Accept-Language` would serve the
|
||||
signed-out page to a signed-in visitor for the cache lifetime, and a cache that bypasses on cookies
|
||||
would never store it. Options: leave it, so operators cache only assets; add `Vary: Cookie`; or give
|
||||
the signed-out page its own URL. A plugin route can already opt in through `RouteResult.headers`.
|
||||
I is 4 because a wrong rule caches a signed-in page for everyone, exposing PII.
|
||||
|
||||
### 16. Decide whether the single Keto `Resource` namespace splits into per-domain namespaces.
|
||||
|
||||
Ory's own examples model `Shift`, `Document` and so on. One global `Resource` bucket is the
|
||||
|
||||
Reference in New Issue
Block a user