From bb6adc40af2c8667c434245780bd3c0784305153 Mon Sep 17 00:00:00 2001 From: lilleman Date: Sun, 2 Aug 2026 15:06:48 +0200 Subject: [PATCH 1/2] Remove stability reviewer auto-run from AGENTS.md --- AGENTS.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 27e305d..d15356c 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -7,7 +7,7 @@ commands and layout. Use the file `todo.md`. -For each todo item, interview the user extensively to deeply understand the scope and goal of each. When done, run the stability reviewer agent in a loop and address all feedback until there is none. If you are not very confident of how to address it, ask the user. Check the completed task in this file. Commit all changes and push to a new branch, create a PR and merge it when the CI/CD turns green. +For each todo item, interview the user extensively to deeply understand the scope and goal of each. When done, check the completed task in this file. Commit all changes and push to a new branch, create a PR and merge it when the CI/CD turns green. ## Project priorities (do not erode) @@ -168,9 +168,6 @@ Same test before adding a row to a table or the file map — a clause, not a par that re-parses `ctx.url.pathname`: it duplicates the URL shape, ignores the router's params, and has to re-handle HEAD. Factor shared per-request setup (auth gate, `ctx.system` capability resolution, target fetch) into a small `withX` wrapper — see `examples/plugins/admin/`. -- Run the stability reviewer agent after every implementation of something that can be like - a PR. That includes any change pushed directly to main. - Skip this if the changes are purely documentation and/or comments. - Use well formed, standard compliant, rich URIs. Prefer state in the URL over POST:ing in for for example list pages with filters and pagination. Do: "ids=x&ids=y" and not "ids[]=x&ids[]=y" and not "ids=x,y". -- 2.52.0 From 12cc2d54c29f8bb9d7bb5ad3a53198855f3f50d9 Mon Sep 17 00:00:00 2001 From: lilleman Date: Sun, 2 Aug 2026 15:12:22 +0200 Subject: [PATCH 2/2] Clarify todo.md reference and record manual review policy --- AGENTS.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index d15356c..478f878 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -7,7 +7,7 @@ commands and layout. Use the file `todo.md`. -For each todo item, interview the user extensively to deeply understand the scope and goal of each. When done, check the completed task in this file. Commit all changes and push to a new branch, create a PR and merge it when the CI/CD turns green. +For each todo item, interview the user extensively to deeply understand the scope and goal of each. When done, check the completed task in `todo.md`. Commit all changes and push to a new branch, create a PR and merge it when the CI/CD turns green. ## Project priorities (do not erode) @@ -168,6 +168,8 @@ Same test before adding a row to a table or the file map — a clause, not a par that re-parses `ctx.url.pathname`: it duplicates the URL shape, ignores the router's params, and has to re-handle HEAD. Factor shared per-request setup (auth gate, `ctx.system` capability resolution, target fetch) into a small `withX` wrapper — see `examples/plugins/admin/`. +- Reviews are maintainer-triggered (e.g. via the larv-review skill) — never auto-run reviewer + agents. Decided 2026-08-02, replacing the earlier run-after-every-implementation rule. - Use well formed, standard compliant, rich URIs. Prefer state in the URL over POST:ing in for for example list pages with filters and pagination. Do: "ids=x&ids=y" and not "ids[]=x&ids[]=y" and not "ids=x,y". -- 2.52.0