100 KiB
100 KiB
Plainpages — implementation TODO
Build order is top → bottom; each phase is roughly independent and testable. Conventions: write tests first (node --test for units, Playwright for E2E), tear down test containers after runs, keep deps minimal, pin all versions, run everything via Docker.
North-star / MVP. Done = a developer can clone, run one command, get a working register/login, and start hacking on their own plugin — no manual key generation, no hand-edited Ory config, no DB setup. Everything below serves that; the one-command bootstrap (§3) and the example plugin (§7) are what make the MVP real. Hydra/SSO are explicitly post-MVP.
0. Housekeeping / primitives
- Decide JWT verify approach:
node:crypto(RS256/ES256 viacreatePublicKey({format:"jwk"})) vs addjose— justify if adding. →node:crypto(no new dep);src/jwt.tsverifies JWS signatures. - Cookie helpers: parse
Cookieheader, buildSet-Cookie(HttpOnly, Secure, SameSite). →src/cookie.ts(parseCookies/serializeCookie); stdlib-only, injection/pollution-safe. - Request context type threaded to handlers:
{ req, res, url, params, query, user|null, roles }. →src/context.ts(RequestContext+buildContext);rolesmirroruser.roles, the §2 router/§4 JWT middleware supplyparams/user. - Error templates: add 403 + 500 (404 exists). →
views/403.ejs+views/500.ejs; 500 wired intoapp.tserror handler (HTML, plain-text fallback). - Config/env loader: Ory endpoints, cookie/CSRF secret, JWKS location, ports. →
src/config.ts(loadConfig); validated at boot, dev defaults for clean-clone, prod requires real secrets; wired intoserver.ts. - Run the architecture and the product reviewer agents on the whole project, not just the latest changes, and address their issues. → Both: no bugs/security issues. Addressed: wired
buildContextintoapp.ts; graceful SIGTERM/SIGINT shutdown; EJS template caching in prod. Deferredcore//shell/split (premature for an 8-file scaffold; revisit at §2/§4). - Go over all comments in the code and the README and try to make it shorter and more information dense. Remove not strictly needed stuff. → Tightened comments across
src/*.ts, Dockerfile, and trimmed verbose/duplicated prose in README; tests + typecheck green. - Go over all tests and combine/unify ones that cover the same stuff or are very related and could be combined in a good way. Remove tests that aren't helping, we only want tests that are actually helpful to us. → Merged related cases across jwt/cookie/app/context/config tests (59 → 42), every assertion preserved; typecheck + tests green.
0.1 Extra input from human
- Remove all usage of NODE_ENV - add a new core principle to the project that the app should at all times be unaware of what environment it is running in. Configuration should be explicit, like "disable email" or "cache templates". → Dropped NODE_ENV everywhere; added environment-agnostic principle (AGENTS.md §4 + README). Behaviour is now explicit toggles:
CACHE_TEMPLATES,REQUIRE_SECURE_SECRETS(parsed/validated inconfig.ts, wired viaserver.ts); compose files set them per deployment.app.tsno longer readsprocess.env.
1. Building blocks — extract from html-css-foundation/ (no Ory needed; render mock data)
- Move
styles.css+auth.cssintopublic/css/; remove existingstyle.css. →git mvfromhtml-css-foundation/intopublic/css/; dropped the placeholderstyle.css; views + tests now referencestyles.css; foundation mockups repointed to../public/css/. - Lucide icon sprite from
lucide-static(dep added) →views/partials/icons.ejs; serve/inline only the icons used. →src/icons.ts(id→lucide map +buildIconSprite) generates a hidden<symbol>sprite of the 31 icons the mockups reference, paths sourced from pinned lucide-static;icons.test.tsguards provenance + only-used. Stale image rebuilt (lucide-static was missing). Wiring into the app shell is the next item. - App-shell partial (sidebar + topbar + content slot). →
views/partials/shell.ejs: full document wrapping.app→ sidebar (brand +navslot + theme/profile footer) ·.scrim·.content(.topbar+bodyslot); reuses the mockup's classes (styled bystyles.css), inlines the icon sprite. Slotsnav/actions/bodyare HTML locals,title/brand/user/breadcrumbstext; defaults render standalone.shell.test.tscovers landmarks, slots, escaping, defaults. Not yet routed (that's "replace placeholder index"). - Nav-tree partial — recursive, header/leaf × clickable/static, counts,
aria-current. →views/partials/nav-tree.ejs: data-driven, self-including. Node{ label, href?, icon?, count?, current?, open?, children? }; header (children →.nav-disctoggle + sibling.nav-children) vs leaf (spacer), clickable (<a>) vs static (<span>), orthogonal. Renders into the shell'snavslot.nav-tree.test.tscovers the full matrix + counts/icons/aria-current/escaping/empty. - Filter-bar partial — GET form (search, segmented, selects, chips, daterange, applied pills). →
views/partials/filter-bar.ejs: data-driven<form method="get">(server-side, zero-JS).rows: Control[][],type ∈ search|segmented|select|chips|daterange|spacer, each reflecting current value (checked/selected); plus appliedpills(+ remove links, Clear all) and Reset/Apply actions. Columns/“more filters” menus deferred to the menu/popover item.filter-bar.test.tscovers every type + value reflection + pills + defaults. - Data-table partial — sortable headers, row-select, badges, kebab row actions. →
views/partials/data-table.ejs: data-driven, zero-JS.columns({ label, sortable, sort, href, className }) render sort as<a class="th-sort">+aria-sort(links, not the mockup's inert buttons);selectable/actionstoggle the check/kebab columns.rowscarry typedcells(string | text+class | user/avatar | badge tone | raw html) + kebabactions(link or danger button, separators).data-table.test.tscovers the matrix + minimal/empty defaults. - Pagination partial — rows-per-page + page numbers, query-param driven. →
views/partials/pagination.ejs: data-driven, zero-JS.summary {from,to,total}, rows-per-page GET<form>(select + submit,hidden[]carries list state),pages: {label,href?,current?,ellipsis?}[](links; current/ellipsis inert),prev/next(href ⇒ link, omit ⇒ disabled). Reuses the mockup's.pagerCSS, no changes.pagination.test.tscovers the matrix + value reflection + empty defaults. - Form-field partials (input/label/hint/error) + auth-card partial. →
views/partials/field.ejs: data-driven.field— label (+ inlinelink/Optional), optional icon input (has-ico),hint, server-drivenerror(string | {text} | {html}) wiringaria-invalid+aria-describedby; added one CSS rule.field.has-error .field-error{display:flex}so a rendered field shows its own error.views/partials/auth-card.ejs: the<form class="auth-card">shell — head (back/title/sub), optionalssoproviders (text logo or icon, link or button) + divider,bodyslot (fields + submit),altfooter.field.test.ts/auth-card.test.tscover the matrix + escaping + defaults. - Menu/popover + theme-switch partials (pure CSS
details/summary). →views/partials/menu.ejs: data-driven<details>popover —trigger(icon/text/raw-html,class:""⇒ bare kebab),align/uppositioning,width;items= head · sep · link/button (icon, danger) · check-group(the columns/“more filters” menus filter-bar deferred here).views/partials/theme-switch.ejs: Light/Auto/Dark radiogroup with the fixedtheme-light/auto/darkidsstyles.csskeys its:has()swaps off. Added.menu-pop.up(replaces the mockup's inline up-positioning);shell.ejsnow reuses both partials.menu.test.ts/theme-switch.test.tscover the matrix + escaping + defaults. - Helper
composeNav(fragments, override, roles)→ merged, permission-filtered tree. →src/nav.ts: pure, I/O-free. Flattens plugin fragments, applies the central override (rename → group → order → hide, all keyed by nodeid), then role-filters — a node shows iff it has nopermissionorrolesincludes it; a gated header drops its whole subtree, an emptied pure header is dropped. Emits clean nodes (noid/permission, absent fields omitted) ready fornav-tree.ejs. Filter runs last so everything above is per-deployment.NavNode/NavOverride/NavGroupSpectypes exported;nav.test.tscovers merge/filter/empties/override matrix. - Helper
parseListQuery(url)→{ q, filters, sort, page, pageSize }. →src/list-query.ts: pure, never throws; inverse of the filter-bar GET form + sort/pagination links. AcceptsURL/URLSearchParams/string.qtrimmed;filters= every non-reserved param asstring[](multi-value chips kept, empties dropped);sort={field,dir}with-field⇒ desc (lone-/empty ⇒ null);pagea positive int (else 1);pageSizedefaults 25, clamped to [1, max 100]. Reserved names + page-size bounds overridable via options.list-query.test.tscovers the full/default/clamp/custom-name matrix. - Helper
paginate(total, page, pageSize)→ page model. →src/paginate.ts: pure, URL-free math feedingpagination.ejs; caller maps page numbers → hrefs. Returns{ from, to, page, pageCount, pageSize, prev, next, total, pages }. Inputs clamped/guarded (page pinned to [1,pageCount], total/pageSize coerced to sane ints, empty list ⇒ 1 page / 0–0).pages= first/lastboundaries+siblings-wide window around current, sorted/deduped, with ellipsis for gaps >1 (a lone hole is shown, not collapsed);siblings/boundariesoverridable.paginate.test.tscovers model/clamp/empty/windowing. - Replace placeholder
indexwith the app-shell dashboard. →/now renders a real app-shell "People" list.src/dashboard.ts(purebuildDashboardModel(url, roles)) wires the §1 helpers end-to-end:parseListQuery→ filter (q/status/team) + sort +paginateover a 30-row mock dataset →composeNav; builds the filter-bar/data-table/pagination/shell configs with canonical, state-preserving links.views/index.ejscomposes the partials around the shell by capturing eachinclude()(EJS returns the string) into a slot. Filtering/sorting/paging all round-trip the URL, zero-JS. Removed the deadpartials/header.ejs.dashboard.test.tscovers default/search/sort/paginate;app.test.tsasserts the live page + URL filtering. Mock data + demo profile stand in until §2/§4. - Check the full system in Playwright and make screenshots and compare to the static original design in html-css-foundation to make sure we're showing the correct graphics. → Dockerized Playwright (official image, browsers preinstalled — no host Node/browsers):
e2e/(config +visual.spec.ts),Dockerfile.e2e,compose.e2e.ymlrun the suite against the livewebservice. 6 parallel tests: screenshots live (default/sorted+filtered/dark/mobile) and the foundation mockups (App Shell + Auth) →e2e/artifacts/(git-ignored); asserts the live DOM computes the same design-system styles as the mockup for the shared components (.sidebar/.topbar/.brand/.btn-primary/.theme-switch/.filters/.pager), every icon<use>resolves, sort/search round-trip the URL, the CSS theme switch flips the palette, and mobile hides the sidebar off-canvas. Verified visually: live dashboard matches the mockup design (light + dark); diffs are data only. All green. - Go over all HTML and CSS and make adjust it to be as sematic as we can, css classes, ids html elements and all, then add semantic DOM as a priority in this project. → Added Semantic, accessible DOM as core principle (AGENTS.md §5 + README). Fixes: page title is now the page
<h1>(shell + mockup), a focus-revealed skip link to#main-content, data-table identifier cell is<th scope="row">(CSS styles tbodyth), error pages got descriptive headings (code retained). Tests-first: shell/data-table specs assert the new markup; typecheck + 75 units + 6 E2E green.
1.1 Extra input from human
- Add to principles that we should have full E2E coverage in the Playwright tests - make sure they can run in parallel to get up some speed. → Added Full, parallel E2E core principle (AGENTS.md §6 + README): every user-facing flow gets a Playwright test shipped with it, tests stay side-effect-free so the suite runs
fullyParallel(already set; verified 7 tests / 7 workers). Led by example: added E2E coverage for the 404 page (the one user-facing gap). Fixed the documented run command to--build(the runner bakes ine2e/, so spec edits were silently ignored without it).
2. Plugin host
- Specify the plugin contract (big job, do first — it's the product's main API surface). Write it down as the authoritative reference: the full manifest shape; the
RequestContexthanded to handlers and what's guaranteed stable; contract versioning (aapiVersion/engines-style field so a plugin declares the host it targets, and the host refuses or warns on mismatch); conflict rules (two plugins claiming the samebasePath, nav slot, orpermissionname → defined, loud resolution, not last-write-wins); the local dev/test story (how an author runs + tests one plugin in isolation against the host). Audience is experienced devs: optimise for a powerful, predictable, clearly-documented API. Crash-isolation (a bad plugin can't take down the host) is a nice-to-have, not a blocker — fail loud at boot/discovery over sandboxing at runtime. It is a target that plugins should be able to overload as much as possible. Hooks on actions in the system is not bad either, if it is possible. →src/plugin.tsis the typed, machine-readable contract (single source of truth: authoredPluginManifest+ folder-derivedPlugin,Route/RouteResult/RouteHandler,PermissionDecl,PluginHooks,definePlugin(),HOST_API_VERSION) plus the pure rules the §2 host enforces —isValidPluginId(URL-safe folder name: lowercase/digits/dashes),checkApiVersion(semver viaparseSemver/official regex, no dep: same major+minor→ok, older minor→warn, newer minor/major-mismatch/malformed→refuse) andfindConflicts(id/route = error, duplicate nav-id = error, shared permission token = warn; never last-write-wins). Identity is the folder: id = folder name, mount =/<id>— neither is in the manifest, so mount-path uniqueness is structural (no basePath rule).apiVersionis a literal a plugin pins (never importsHOST_API_VERSION). navicon= Lucide sprite id.docs/plugin-contract.mdis the prose reference (anatomy/identity, manifest fields, handler/RouteResult,RequestContextstability guarantee, nav/permission namespacing, versioning, conflicts, hooks, dev/test story). README links it. Tests-first (plugin.test.ts); typecheck + 82 units green. Discovery/router/view-resolver/static stay as the next §2 items that wire this to FS+HTTP. - Discovery: scan
plugins/, import eachplugin.tsdefault export, validate. →src/discovery.ts(discoverPlugins): the imperative shell over plugin.ts's pure rules. Scansplugins/(sorted, skips dotfiles/non-dirs; missing dir ⇒[]for a clean clone), derivesidfrom the folder, dynamically imports eachplugin.tsdefault export and validates it —isValidPluginId, default-export-is-a-manifest,checkApiVersion, array-shape of nav/routes/permissions, thenfindConflictsacross the set. Fails loud: every per-plugin problem + every error-level conflict is collected and thrown as one boot-stopping Error naming the plugin(s); warns (older-minor apiVersion, shared permission token) log and load continues. Wired intoserver.tsboot (logs the loaded ids).discovery.test.tscovers empty/happy/each failure mode + the warn path (temp-dir fixtures). Router/view-resolver/static are the next §2 items. - Router: match method+path under
basePath, resolve path params, run permission gate, call handler with context. →src/router.ts: the pure core (matchRoute/allowedMethods/isAuthorized), wired byapp.ts(the imperative shell). A route mounts at/<id>+ its path via the now-exportedfullPath(shared withfindConflicts, so they can't drift);:namesegments →ctx.params.name(percent-decoded, malformed ⇒ no match). Specificity: a literal segment beats a:param(/users/newwins over/users/:idregardless of declaration order), ties keep discovery order. HEAD answers a GET route; known-path/wrong-method ⇒ 405 +Allow.isAuthorized= composeNav's gate (nopermission⇒ open, elserolesmust include it); fail-closed today since auth (§4) supplies no user yet (gated ⇒ 403).app.tsbuilds the context, gates, calls the handler, and mapsRouteResult→ response (sendResult: html/json/redirect/view/void; author headers override; the void escape hatch lets a handler ownctx.res);viewrenders the plugin's ownviews/<view>.ejs(the richer resolver — core-partial includes, subfolders — is the next §2 item). Dropped the global non-GET/HEAD 405 (plugins bring other methods). Wired intoserver.ts(createApp({ plugins })). Tests-first:router.test.ts(match/params/specificity/HEAD/methods/gate) + anapp.test.tsintegration mounting a demo plugin (every RouteResult shape + 403/405/404); typecheck + 98 units green. - Per-plugin view resolver (
plugins/<id>/views/*.ejs) and also all possible partials for ejs in the views folder and sub folderes. →src/view-resolver.ts(renderPluginView/resolveViewPath), wired intoapp.tsfor aviewRouteResult (replaces the router's minimal stub).resolveViewPath(pure) maps a view name →plugins/<id>/views/<view>.ejs, supports nested names (shifts/edit), defaults the.ejsextension, and refuses traversal/control-char names (same guard asstatic.ts). Rendering passes EJSviews: [<plugin>/views, coreViewsDir]: EJS resolves aninclude()relative to the current file first, then those roots — so a plugin view reaches every core building-block partial (shell, nav-tree, data-table, …) and its own partials/subfolders, plugin-root first so it can deliberately shadow a core partial. Out-of-bounds name ⇒ reject (fail loud). Tests-first:view-resolver.test.ts(resolve/nest/extension/traversal/control-char + a nested view that includes both a core partial and its own) + theapp.test.tsplugin integration now asserts the liveviewpage includespartials/theme-switch; typecheck + 102 units green. Per-plugin static serving is the next §2 item. - Per-plugin static serving:
plugins/<id>/public/→/public/<id>/. →routePublic(pure, insrc/static.ts), wired intoapp.ts's existing/public/branch. A request/public/<rest>whose leading segment names a discovered plugin serves fromplugins/<id>/public/<rest>; anything else (e.g.css/styles.css) stays on the corepublic/. Disambiguates by the discovered plugin-id set, so only mounted plugins expose assets and core paths are unaffected; plugin ids are URL-safe so the raw segment compares directly (no decode needed). ReusesserveStaticunchanged, so the sub-path keeps its decode + traversal/control-char guard (encoded..⇒ 403) and HEAD support; a missingpublic/or file ⇒ 404. Tests-first: aroutePublicunit (plugin/core split, nested asset, bare/public/<id>) + theapp.test.tsplugin integration now serves a realdemo/public/app.css(200 +text/css) and still 403s a traversal; typecheck + 103 units green.config/menu.tscentral override is the next §2 item. config/menu.tscentral override: reorder/rename/hide/group + branding (app name, logo, default theme). →src/menu-config.ts(MenuConfig/Branding/MenuConfigInput,defineMenu()identity helper,DEFAULT_MENU,loadMenuConfig()) + the operator fileconfig/menu.ts. The override iscomposeNav's existingNavOverride(reorder/rename/group/hide by node id, applied before the per-user filter); branding ={ name, logo?, sub?, theme? }.loadMenuConfig(imperative shell) dynamically importsconfig/menu.tsif present, validates the authored shape fail-loud (branding field types +themeenum, overridehide/orderstring-arrays /groupsarray /renameobject), merges branding over defaults; absent file ⇒DEFAULT_MENU(clean clone). Wired:server.tsloads it at boot →createApp({ menu })→buildDashboardModel(url, roles, menu)feedsmenu.overrideintocomposeNavandmenu.branding(name/sub) into the shell brand.config/menu.tsships defaults matching prior behaviour (name "Plainpages"/sub "Console", empty override), so a clean clone is unchanged. Addedconfigto tsconfigincludeso the authored file is type-checked (DockerfileCOPY . .already bakes it). Tests-first:menu-config.test.ts(absent⇒defaults / read+merge / malformed⇒throws) + adashboard.test.tscase asserting rename+hide+branding take effect; typecheck (incl.config/) + 107 units green; smoke-loaded the real file at boot. Rendering branding (logo, default theme) into the app shell is the next §2 item.- Wire branding into the app shell. → Completes the §2 branding chain (name/sub already flowed).
shell.ejsnow rendersbrand.logoas<img class="brand-logo" alt="">when set, else the default#i-boxbrand-mark; thethemelocal (already forwarded to the theme-switch) is now supplied.buildDashboardModelputsmenu.branding.logointoshell.brandandmenu.branding.themeintoshell.theme(both omitted when unset, so a clean clone is unchanged → brand-mark + auto theme);views/index.ejsforwardsthemeto the shell. Added a.brand-logoCSS rule (22px, matches.brand-marksizing). Tests-first:shell.test.ts(logo replaces the mark + default theme checked; no-logo ⇒ mark + auto) + extendeddashboard.test.ts(logo→brand, theme→shell.theme) + anapp.test.tsintegration renderingcreateApp({ menu })end-to-end (logo<img>+theme-darkchecked on/). Default-app shell rendering is byte-equivalent, so the visual E2E is unaffected; typecheck + 109 units green. The §2 plugin host is feature-complete (remaining §2 items are the project-wide review + comment/test cleanup). - Run the architecture and the product reviewer agents on the whole project, not just the latest changes, and address their issues. → Ran both on all of
src/,views/,config/, Docker/tsconfig. Verdict: architecture sound + disciplined, no crash/security defect in the current path (fail-loud, traversal guards, JWT/cookie defenses all confirmed). Fixed now: (1) HIGH —PluginHookswas typed+documented but never invoked; wired it (src/hooks.ts:runBootHooks/runRequestHooks/runResponseHooks) —server.tsrunsonBootafter discovery before listen,app.tsrunsonRequest(before routing, first non-void short-circuits, renders against its plugin) +onResponse(after handler, observer, throw→500); skipped entirely when no plugin declares a hook (hot path free);hooks.test.ts+ anapp.test.tsintegration. (2)discovery.tsfailhelper retyped: void. (3) Documented the template trust boundary indocs/plugin-contract.md(rawhtml/*.htmlfields; URL sinks escaped but not scheme-checked) + tightened the Hooks prose to the wired semantics. Deferred (reviewer-scoped, not §2): extract a sharedbuildShellContextout ofdashboard.tsand route the built-in screens throughmatchRoute/isAuthorized→ §5 (premature at one call site); asafeUrl()helper for href sinks → §4 (no untrusted URLs until upstream data flows); doc/type-duplication + non-local§Nrefs → the §2 comment-cleanup item; HEAD-render cost + dev empty-secret fallback → negligible. typecheck + 113 units green; boot smoke-tested. - Go over all comments in the code and the README and try to make it shorter and more information dense. Remove not strictly needed stuff. → Pass over the §2 accretion (the §0/§1 cleanup at line 21 stands). Tightened the verbose module-header blocks (
plugin.ts,discovery.ts,router.ts,dashboard.ts) and collapsed thecheckApiVersionrule comment to a one-liner that points at the contract doc (the if-chain + messages already document it). Removed now-stale forward-refs ("router wiring is the next §2 item", "rendered in the shell — next §2 item"). README: corrected the Status note (it undersold — §1 design system + the whole §2 plugin host are built, not just a scaffold), dropped the stale_(planned)_/"planned to extract" markers on Building a plugin and Building blocks (both shipped; auth guards still flagged §4), and named the real helpers. Left the security-rationale comments (jwt/cookie/static/paginate) and the EJS partials' config-doc headers intact — they carry vital info / are the only schema for untyped locals. No anchor links broke; typecheck + 113 units green. - Go over all tests and combine/unify ones that cover the same stuff or are very related and could be combined in a good way. Remove tests that aren't helping, we only want tests that are actually helpful to us. → Reviewed all 24 test files. The suite already follows the deliberate per-module "matrix + edge" pattern from the §0/§1 merge (line 22), so most files carry no fat and force-merging distinct concerns would only hurt readability. Removed the genuine §2-era overlaps, all in
app.test.ts: merged the two HTTP static tests into one (GET/HEAD + traversal/NUL→403), and dropped the standalone "renders the 403 error page"ejs.renderFilestopgap (its comment even said "403 has no first-party route yet") — the gated plugin route now exercises 403 over HTTP, so the template assertions (status + 403.ejs body + stylesheet link) moved there; also dropped the now-unusedejsimport. Unifiedview-resolver.test.ts's tworesolveViewPathcases (resolve + reject) into one. 113 → 110 tests, zero coverage lost; typecheck + tests green.
3. Ory stack — compose + config
postgresservice (pinned tag); separate DB/schema per Kratos/Keto/Hydra. →compose.ymlpostgresservice pinned topostgres:18.4-alpine3.23(verified latest stable PG + newest Alpine the official image ships);ory/postgres/init/init.sql(mounted atdocker-entrypoint-initdb.d) creates one DB per service (kratos/keto/hydra) so each owns its schema + migrations. Dev defaults (ory/ory, env-overridable for prod), namedpgdatavolume mounted at/var/lib/postgresql(PG18+ version-subdir layout — not/data),pg_isreadyhealthcheck. Web app never connects. Verified live: boots healthy, three DBs present, then torn down.postgres.test.tsguards the pin + DB-per-service. typecheck + 112 units green.kratosservice (pinned) +migrate; identity schema (traits: email, name). →compose.ymladdskratos/kratos-migratepinned tooryd/kratos:v26.2.0(verified latest stable);kratos-migraterunsmigrate sql -e --yesagainst the per-servicekratosDB after postgres is healthy,kratoswaits for it (service_completed_successfully).ory/kratos/identity.schema.json= email (password identifier, verification/recovery via email) +name {first,last}, email required.ory/kratos/kratos.yml= bootable baseline: password login, self-service UIs pointing at the web routes (themed in §4), serve URLs, dev-throwaway secrets (prod via env, §3), identity schema wired; DSN via env. Themed flows/SSO/session/tokenizer/JWKS are the next §3/§4 items. Tests-first (kratos.test.ts: version pin + migrate-before-serve + DSN→kratos DB + schema traits + schema wiring). Boot-verified: migrate exits 0, kratos serves/health/ready200, serves the identity schema, inits a password login flow; torn down. typecheck + 117 units green.- Kratos self-service flows (login, registration, recovery, verification, settings) → return URLs at our themed pages. →
ory/kratos/kratos.yml: all five flows enabled, eachui_url(+ after/return URLs) points at our web routes (/login,/registration,/recovery,/verification,/settings; §4 renders the fields). Recovery + verification run on the emailcodemethod (login stays password-only —code.passwordless_enabledleft default-off); registration after-hookssession+show_verification_ui; settings getsprivileged_session_max_age+required_aal: highest_available. Added acourier(SMTP) sending to a pinned dev mail catcher — mailpit (axllent/mailpit:v1.30.1) incompose.override.yml, web UI on:8025; prod overridesCOURIER_SMTP_CONNECTION_URI. Kratosservenow runs--watch-courierso queued codes actually dispatch (without it they sit "queued"). Tests-first (kratos.test.ts: five flow ui_urls → our pages, recovery/verification usecode+ courier +--watch-courier, mailpit pin). Boot-verified end-to-end: all four public browser-flows 303 →127.0.0.1:3000/<flow>?flow=…, a registration delivered a real "Use code … to verify your account" email to mailpit (queue →sent); torn down. typecheck + 120 units green. - Kratos OIDC/SSO providers (Google/Microsoft/SAML) config (secrets via env). None enabled by default — a clean clone runs password-only; a provider activates purely by supplying its env creds. →
ory/kratos/kratos.ymladds theoidcmethod present-but-disabled with an emptyproviders: [](clean clone = password-only, boots clean). Activation is pure env, no code/rebuild:SELFSERVICE_METHODS_OIDC_ENABLED=true+SELFSERVICE_METHODS_OIDC_CONFIG_PROVIDERS=[…](the whole-array override is the only env-settable form Kratos offers — nested-field env vars aren't supported). Providers (google/microsoft/OIDC bridges) carry theirclient_id/client_secretand reference the committed shared claims mapperory/kratos/oidc/claims.jsonnet(provider claims →email+name{first,last}). SAML isn't in OSS Kratos (Enterprise/Network/Polis only) — documented: front it with an OIDC bridge (Ory Polis) and register that bridge as a generic OIDC provider. README Social sign-in (SSO) section documents activation; §4 will derive the buttons from the live provider list. Tests-first (kratos.test.ts: oidc disabled + empty by default, mapper maps email/name). Boot-verified both halves: clean stack → login flow has onlydefault+passwordgroups; a one-off kratos with the SSO env → login flow gains anoidcgroup + agooglebutton, no boot errors; torn down. typecheck + 122 units green. - Kratos session settings (cookie name, lifespan, sliding refresh). →
ory/kratos/kratos.ymladds asessionblock: branded cookiename: plainpages_session(persistent: true,same_site: Lax),lifespan: 720h(30d "stay signed in" backbone the app re-mints the ~10m JWT off, §4), and sliding refresh viaearliest_possible_extend: 24h(an active session extends back to full lifespan only once within 24h of expiry — no DB write per request). Tests-first (kratos.test.ts: cookie name + lifespan + extend window). Boot-verified: kratos serves/health/ready200 with the block; a real browser registration (one-off--devkratos, since Secure cookies don't ride plain http — that's the line-69 split) issuedSet-Cookie: plainpages_session=…; Max-Age=2591999; Expires=…; HttpOnly; SameSite=Lax— name/persistent/lifespan all as configured; torn down. typecheck + 123 units green. - Kratos tokenizer template
plainpages: claims{ sub, email, roles },ttl ≈ 10m,jwks_urlsigner,claims_mapper_url(Jsonnet readingmetadata_admin.roles). →ory/kratos/kratos.ymladdssession.whoami.tokenizer.templates.plainpages:ttl: 10m,subject_source: id(sub = identity id),claims_mapper_url/jwks_urlpointing at the mounted config dir.ory/kratos/tokenizer/plainpages.jsonnetis the claims mapper —emailfromsession.identity.traits.email,rolesfrom themetadata_adminprojection (§4 refreshes it from Keto at login; absent on a fresh identity ⇒[], defensiveobjectHas).subis fixed to the identity id by Kratos (subject_source), not the mapper. The JWKS signing key referenced byjwks_urlis generated/mounted by the next §3 item — Kratos loads it lazily at tokenize time, so this boots clean. Tests-first (kratos.test.ts: template ttl/subject_source/urls + mapper email/roles-from-metadata_admin). Boot-verified: kratos serves/admin/health/ready200 with the tokenizer wired (config schema accepts the block); torn down. typecheck + 125 units green. - Generate + mount the JWT signing JWKS; document key rotation. →
src/gen-jwks.ts(generateJwks()+ CLI) mints an ES256 EC P-256 signing key as a JWK Set — Ory's recommended alg and the verifier's preferred (src/jwt.ts). The committedory/kratos/tokenizer/jwks.jsonis the dev throwaway (like the cookie/cipher secrets inkratos.yml), already mounted via./ory/kratos:/etc/config/kratos:roat thejwks_urlthe tokenizer template points to — so a clean clone signs out of the box. Regenerate/rotate:docker compose run --rm -T web node src/gen-jwks.ts > ory/kratos/tokenizer/jwks.json(alsonpm run gen-jwks). README documents prod override (mount a real key or…_JWKS_URL=base64://…) + zero-downtime rotation (Kratos signs with the first key, app verifies bykid(§4) → prepend new, keep old ~one 10m TTL, drop). Tests-first (gen-jwks.test.ts: generator shape + unique kid, committed key validity, round-trip — a JWS signed with a generated key verifies throughverifyJws). Boot-verified the full chain end-to-end: live Kratos registered an identity (API flow),whoami?tokenize_as=plainpagesreturned a real JWT signed with ourkid,verifyJwsvalidated it against the committed public half, claims{sub, email, roles:[]}+ exp−iat = 600s (10m); torn down. typecheck + 128 units green. ketoservice (pinned) +migrate; namespaces in OPL (role,group, resource permissions). →compose.ymladdsketo/keto-migratepinned tooryd/keto:v26.2.0(Ory's unified versioning — same train as kratos; verified latest stable);keto-migraterunsmigrate up -yagainst the per-serviceketoDB after postgres is healthy,ketowaits on it (service_completed_successfully) — mirrors the kratos pattern.ory/keto/keto.ymlserves read on 4466 + write on 4467 (the portsconfig.tsalready targets), DSN via env, loads the OPL from the mounted file.ory/keto/namespaces.keto.tsis the OPL model:User(subject = Kratos id),Group/Roleas subject sets withmembers(the coarse roles read at login → JWT, README), and a fine-grainedResourcewithpermitsview/edit/delete over owner ⊇ editor ⊇ viewer (README's third "may I?" tier). OPL stays out of tsconfiginclude(Keto-dialect, like the jsonnets). README: Status note + Layout updated, the role tuple example fixed to#membersto match the OPL. Tests-first (keto.test.ts: version pin + migrate-before-serve + DSN→keto DB + read/write ports + OPL namespaces/permits). Fixed a pre-existing kratos test that over-asserted every compose DSN was kratos's (now scoped to kratos DSNs). Boot-verified the whole model live: migrate exits 0, read API ready, then over the write/read APIs —role:admin#members@user:alicechecks allowed;Resource:doc1owner→delete/view allowed, viewer→view allowed but delete denied, stranger denied; and a transitiveGroup:eng members ⊆ Role:editorresolveduser:erin→editor; torn down. typecheck + 135 units green.hydraservice (pinned) +migrate; issuer + login/consent URLs → our app. →compose.ymladdshydra/hydra-migratepinned tooryd/hydra:v26.2.0(Ory's unified train — same version as kratos/keto; verified latest);hydra-migraterunsmigrate sql -e --yesagainst the per-servicehydraDB after postgres is healthy,hydrawaits on it (service_completed_successfully) — mirrors the kratos pattern.ory/hydra/hydra.ymlserves public 4444 + admin 4445,urls.self.issuer= the public OAuth2 URL, andurls.login/consent/logoutpoint at our app routes (/oauth2/login,/oauth2/consent,/oauth2/logout; §6 renders the handlers, namespaced under/oauth2/so they don't collide with Kratos's first-party/login). Dev throwawaysecrets.system(prod overrides via env). Hydra refuses an http issuer in prod, socompose.override.ymladdsserve all --dev+ exposes4444for dev (the full dev/prod split + health checks is the next §3 item). Tests-first (hydra.test.ts: version pin + migrate-before-serve + DSN→hydra DB + public/admin ports + issuer/login/consent/logout URLs). Boot-verified end-to-end: migrate exits 0, public+admin/health/ready200, OIDC discovery reportsissuer: http://127.0.0.1:4444/, and a real authorization flow (created an OAuth2 client, hit/oauth2/auth) 302-redirected tohttp://127.0.0.1:3000/oauth2/login?login_challenge=…— our app; torn down. typecheck + 140 units green.- Split dev (
compose.override.yml) vs prod (compose.yml) wiring; health checks +depends_onordering. →compose.yml(base/prod) adds busybox-wget/health/readyhealthchecks to the long-running Ory services (kratos:4433, keto:4466, hydra:4444) and gateswebonkratos+ketoservice_healthy(the servicesconfig.tstalks to — hydra is post-MVP §6, absent from config, so web doesn't gate on it; ordering is transitive through the migrate gates). Dev/prod split: prod publishes no internal Ory ports;compose.override.ymlexposes only the host-facing ones the browser needs — kratos public 4433 (self-service flows POST toflow.ui.action, kratos.yml base_url) alongside the existing hydra 4444 + mailpit 8025. The visual E2E stays Ory-free viadepends_on: !reset []onwebincompose.e2e.yml(the dashboard is mock data — no Postgres/Ory boot). Tests-first (compose.test.ts: Ory healthchecks + web ordering + the port split + the e2e reset). Boot-verified the full dev stack with--wait: kratos/keto/hydra/postgres/mailpit all healthy,webstarted only after kratos+keto healthy, the host reaches kratos 4433 + hydra 4444 + web 3000 while keto 4466 is refused (internal-only); torn down. README Development refreshed (dropped the stale "Ory…planned" note). typecheck + 144 units green. - One-command bootstrap (the MVP bar):
docker compose upbrings up web + all Ory services + Postgres with zero manual prep. Commit working default Ory configs; auto-run migrations on first boot; auto-generate the JWKS signing key if absent; seed an admin identity + its Keto roles + a demo password (admin/admin) idempotently. Land anOPL/namespace bootstrap so Keto answers checks out of the box. →src/bootstrap.ts+ a one-shotbootstrapcompose service: runs after kratos+keto are healthy (web gates on itsservice_completed_successfully), idempotent so everyupre-runs cleanly. (1)ensureJwksgenerates the ES256 signing key (reusesgen-jwks.ts) only when the committed dev key is absent — tokenizer dir mounted rw so it can land. (2)seedAdmincreatesadmin@plainpages.local/adminvia the Kratos admin API (a re-run's 409 → look up + reuse the id). (3) grantsRole:admin#members@user:<id>via the Keto write API (PUT, idempotent) — the source of truth the §4 login flow projects into the JWT. Migrations + default Ory configs already auto-run/committed (§3); OPL/namespaces load fromketo.yml(§3). The password policy is bypassed by the admin API, soadmin/adminis accepted. Tests-first:bootstrap.test.ts(payload builders, seed idempotency via mock fetch, generate-if-absent) +compose.test.ts(service wiring). Boot-verified the whole chain on the live stack:docker compose up --waitseeds with zero prep, Ketocheck→allowed:true, login withadmin@plainpages.local/adminissues a session + tokenizes a JWT; re-run → "already present"; moving the committed key → "generated a JWKS signing key". JWTrolesstays[]until §4 wires the Keto→metadata_adminprojection. typecheck + 151 units green. The first-run banner (login URL + creds) and the prod-secret/SSO exception docs are the next §3 items. - First-run banner / log line printing the login URL + seeded admin creds, with a clear "change these before production" warning. →
firstRunBanner()insrc/bootstrap.ts(pure, testable) renders a boxed banner — login URL · seeded email/password · "⚠ change before production" — thatmain()prints after seeding. Login URL fromAPP_URL(compose defaulthttp://localhost:3000, overridable per deployment); creds reuse the seededADMIN_EMAIL/ADMIN_PASSWORD. Tests-first (bootstrap.test.ts: asserts URL + creds + warning present); README Development notes the banner. Live-verified: rebuilt bootstrap prints the banner after the admin line; typecheck + 152 units green; stack torn down. - Document the only things that can't be auto-generated: third-party SSO provider client id/secret (optional — password login works without them) and production secrets (real cookie/CSRF secret + signing key, supplied via env, replacing the dev throwaways). Everything else must work from a clean clone. → New README What you must supply (the only manual prep) subsection (under Configuration) consolidates the previously-scattered facts into one authoritative list: a clean clone needs nothing; exactly two production-only things can't be auto-generated — (1) production secrets (
COOKIE_SECRET/CSRF_SECRET+ the JWT signing key, withREQUIRE_SECURE_SECRETS=truerefusing throwaways) and (2) optional SSO provider creds (no creds ⇒ no button). States everything else (Ory migrations, dev signing key, demo admin + Keto roles, OPL model) is generated/seeded on first boot. Cross-links the existing SSO + JWT-rotation subsections (no duplication) and adds a pointer from Production / deployment. All four anchors verified; docs-only — typecheck + 152 units green. - Run the architecture and the product reviewer agents on the whole project, not just the latest changes, and address their issues. → Ran both on the whole project (weighted to the §3 Ory stack). Verdict: architecture sound + disciplined, no Critical; both independently flagged the same top issue. Fixed now: (1) HIGH (both agents) —
JWKS_URLdefault washttp://kratos:4433/.well-known/jwks.json, but Kratos does not republish the session-tokenizer key there (no OIDC discovery on Kratos — that's Hydra), so the §4 verifier would have fetched the wrong/empty set and no one could be authorized. Repointed the default tofile:///etc/config/kratos/tokenizer/jwks.json— the exact key Kratos signs with (kratos.ymljwks_url) — and mounted that tokenizer dir read-only intoweb(compose.yml) so the verifier resolves the live key in dev and prod (same file bootstrap regenerates).config.test.tsnow locks the default to the tokenizer file + asserts the committed key is a real ES256 JWKS carrying akid(the regression the old/jwks/match missed). (2) MEDIUM (stability) —bootstraphad uncappedrestart: on-failure; a permanent seed error would loop forever and silently hangweb(gates onservice_completed_successfully). Capped toon-failure:5(seed is idempotent — 409-create + idempotent PUT — so transient Ory blips still recover, permanent ones give up loud). (3) §3's newwebdepends_onmade the documenteddocker compose run --rm web …typecheck/test/gen-jwks commands drag up the whole Ory stack — added--no-deps(README + AGENTS.md). Deferred (reviewer-scoped, not §3): extractbuildShellContextout ofdashboard.ts+ route built-in screens throughmatchRoute/isAuthorized→ §5 (forcing function arrives with the 2nd/3rd screen); seed the demo admin'smetadata_admin.rolesprojection so first login is non-empty → §4 (the login-completion projection owns it); enforce Ory*.ymlprod secrets + self-service return-URLs via env → §9 (ops). typecheck + 153 units green; both compose files validated. - Go over all comments in the code and the README and try to make it shorter and more information dense. Remove not strictly needed stuff. → Pass over the §3 Ory accretion. Killed the now-stale "the next §3 item generates/mounts" forward-refs (the JWKS shipped) in
kratos.yml(×2) +kratos.test.ts. Tightened the verbose service/header blocks incompose.yml(web depends_on/JWKS-mount, the three Ory headers, the bootstrap block) and thebootstrap.ts/gen-jwks.tsmodule headers — dropping prose the README/src/bootstrap.tsalready carry, keeping the security/stability rationale (read-only mount, bounded retry). Trimmedconfig.ts's JWKS comment and thekratos.ymlSSO block (kept the concrete env example), and aligned thegen-jwks.tscommand with the README's--no-deps. Net −12 lines; typecheck + 153 units green. The §3 README sections (Development / What you must supply / SSO / JWT rotation) were already authored concise in §3 (todo lines 70–72) and left intact. - Go over all tests and combine/unify ones that cover the same stuff or are very related and could be combined in a good way. Remove tests that aren't helping, we only want tests that are actually helpful to us. → Pass over the §3 Ory-stack tests. The clear overlap: the "image pinned to an exact version" AGENTS.md check was re-implemented 5× (postgres/kratos/keto/hydra + mailpit). Unified into one
compose.test.tsscan over all three compose files (strictly stronger — auto-covers any future image) + one test asserting each Ory service & its migrate sidecar share one version (subsumes the per-service "both present + same version" halves). Dropped the now-redundant pin tests frompostgres/kratos/keto/hydra.test.ts(each keeps its config-semantics tests; comments point pinning atcompose.test.ts). Also trimmedconfig.test.ts's duplicate re-validation of the committed JWKS key —gen-jwks.test.tsalready owns key validity (round-trips a signature); the config test keeps the default-path assertion. The migrate-before-server / DSN / port / URL tests stay per-service (distinct config, distinct files — merging would hurt the per-module structure). 153 → 150 tests, zero coverage lost; typecheck + tests green.
4. Auth — identity, session JWT, guards
- Kratos public client (fetch): init/get/submit flows,
whoami,whoami?tokenize_as=plainpages. →src/kratos-public.ts(createKratosPublic({baseUrl, fetchImpl})): typedfetchwrappers over Kratos' public API, no SDK dep (built-infetch),fetchImpl-injectable likebootstrap.ts.initBrowserFlow(type, {cookie?, returnTo?})GETs/self-service/<type>/browserwithAccept: json(so Kratos returns the flow + CSRFSet-Cookieto relay, not a redirect);getFlow(type, id, {cookie?})reads/self-service/<type>/flows?id=forwarding the browser cookie;submitFlow(action, {body, contentType?, cookie?})POSTs urlencoded to the flow'sui.action(manual redirect) →{ok, status, body, location, setCookie}(200 success / 400 re-rendered flow-with-errors, no throw / 303 Location or 422redirect_browser_to);whoami({cookie?, tokenizeAs?})reads/sessions/whoami→Session|null(401⇒null), with?tokenize_as=plainpagesreturning the session'stokenizedJWT. Fail-loudKratosErrorcarries.status(so §4 line 81 can re-init on an expired 404/410). Flowui.nodestyped loosely — rendering/field-error mapping is §4's renderer. Tests-first (kratos-public.test.ts, mock fetch: URLs/JSON-accept/cookie relay/Set-Cookie/tokenize query + 410/500 errors + 400 validation + redirect targets). Building block — no route/E2E yet (the themed flow pages + login completion are the next §4 items). README Layout lists it. typecheck + 159 units green. - Kratos admin client (fetch): identity CRUD +
metadata_adminupdate. →src/kratos-admin.ts(createKratosAdmin({baseUrl, fetchImpl})): typedfetchwrappers over Kratos' admin API (admin port), no SDK,fetchImpl-injectable likekratos-public.ts; reuses that module'sKratosError(carries.status).createIdentity(POST, 201),getIdentity(GET, 404⇒null),listIdentities({credentialsIdentifier?, ids?, pageSize?, pageToken?})→{identities, nextPageToken}(parses the keyset cursor from theLinkrel="next" header for the §5 users list),updateIdentity(full PUT),deleteIdentity(DELETE, 204), andupdateMetadataAdmin— the key login-completion method:PATCHJSON-Patchadd /metadata_adminso it sets the roles projection whether the field is absent/null/set and never clobbers traits/state. Building block — no route/E2E yet (login completion §4 line 83 wires it; the projection feeds the tokenizer'smetadata_adminmapper, §3). Tests-first (kratos-admin.test.ts, mock fetch: URLs/method/JSON-Patch body/query+pagination/Link parsing + 201/200/404/409 mapping). README Layout lists it. typecheck + 167 units green. - Keto client (fetch):
check, list/expand relations, write/delete tuples. →src/keto-client.ts(createKetoClient({readUrl, writeUrl, fetchImpl})): typedfetchwrappers over Keto's relation-tuple APIs, no SDK,fetchImpl-injectable like the kratos clients; read (check/listRelations/expand) and write (writeTuple/deleteTuple) split onto the two ports config.ts targets (4466/4467).RelationTuple(subject_id xor subject_set; mirrors bootstrap's roleTuple) is the wire shape for writes + the filter shape for reads viatupleParams(subject sets → dottedsubject_set.*keys).checkreturns aboolreadingallowedfrom both 200 (allowed) and 403 (denied) — Keto answers a denial with 403, not 200 (caught in boot-verify); other statuses fail loud viaKetoError(carries.status, parallels KratosError).writeTuplePUTs (idempotent),deleteTupleDELETEs by query,listRelationsparsesnext_page_token,expandreturns the loose tree. Building block — no route/E2E yet (login completion §4 line 83 + guards line 86 wire it). Tests-first (keto-client.test.ts, mock fetch: URLs/ports/method/query+body/subject forms/allowed mapping/pagination/errors). README Layout lists it. Boot-verified live: full round-trip against a real keto (check false → write → true → list → expand → delete → false). typecheck + 174 units green. - Render Kratos flows: fetch flow → render fields against our themed pages → POST to
flow.ui.action(Kratos handles its CSRF), map field errors/messages. →src/flow-view.ts(purebuildFlowView(flow, type)): maps a fetched self-serviceFlow→ themed view model — hidden inputs (incl.csrf_token), themed fields (label frommeta.label, type/required/autocomplete from attributes, an input icon by field semantics, node-level error message), submit buttons (name/value preserved), and tone-mapped flow messages (error→neg/success→pos/info→info);oidcnodes skipped (SSO is the next item). Per-flow chrome (title/sub/back/alt) +AUTH_FLOWSpath→type map.views/auth.ejsrenders it into the html-css-foundation auth layout, reusing theauth-card+fieldpartials and capturingpartials/flow-body.ejs(messages + hidden + fields + buttons) into the card body; new reusablepartials/alert.ejs+ an.alertdesign-system component (styles.css, tone tokens).app.tsserves the five routes via an injectablekratosclient (server.ts builds it fromconfig.kratosPublicUrl): no?flow=⇒ init server-side + relay Kratos' CSRFSet-Cookie+ 303 to?flow=<id>;?flow=<id>⇒getFlow(forwarding the browser cookie) → render; an expired/unknown flow (403/404/410) re-inits. The browser POSTs the form straight toflow.ui.action(Kratos owns CSRF) — no server-sidesubmitFlow. Tests-first:flow-view.test.ts(mapping matrix: hidden/fields/buttons/icons/errors/tone/oidc-skip/chrome/AUTH_FLOWS) +app.test.tsintegration (init 303 + CSRF relay + expired restart; rendered page posts to Kratos with the live fields + error alert) — mockKratosPublic. typecheck + 181 units green. Boot-verified the whole chain on the live stack:/login303 →?flow=relaying the realcsrf_token_…cookie, the page posts to127.0.0.1:4433with the live token + identifier/password + submit; registration renders the realtraits.*fields; recovery/verification chrome correct; a stale flow id 303s back to re-init; torn down. Browser-submittable end-to-end (dev http Secure-cookie posture, login completion → our JWT cookie) is the next §4 items (lines 83/89); the full live-stack login Playwright E2E is owned by §8. - SSO buttons → Kratos OIDC flows. Render per configured provider only: derive the list from Kratos' enabled OIDC providers (no creds ⇒ no button); hide the whole SSO section when none are configured. No code change needed to add/remove a provider — config only. →
flow-view.tsnow collects the login/registration flow'soidc-group submit nodes intoFlowView.sso({label, logo, name, value}per provider;logo= provider initial, lucide ships no brand marks) instead of skipping them — so the button list is Kratos' live provider list (none configured ⇒sso: []⇒ no section; activate/remove a provider purely via the §3 OIDC env).auth-card.ejsgained a submit-provider branch: a provider withname/valuerenders<button type="submit" name=… value=…>(postsprovider=<id>to the same Kratos form, sharing its csrf hidden input);hrefstill ⇒<a>, neither ⇒ inert button.auth.ejsforwardssso: { providers: flow.sso }. Removed the mockup-onlybody:not(:has(#sso-toggle:checked)) .sso{display:none}rule fromauth.css(#sso-toggleis a "remove for production" preview control inhtml-css-foundation/Auth.html) — visibility is now purely server-side. Tests-first:flow-view.test.ts(oidc→sso matrix +sso:[]when none),auth-card.test.ts(submit-provider markup),app.test.ts(live/loginrenders the SSO submit button in the form). README Social sign-in (SSO) updated (dropped the §4 forward-ref). typecheck + 181 units green. Boot-verified end-to-end: a real Kratos with the OIDC env emitted{group:oidc, name:provider, value:google}→buildFlowViewderived[{label:"Sign in with google", logo:"G", name:"provider", value:"google"}]; clean-clone/loginrenders no.ssosection; torn down. - Login completion: read roles from Keto → write
metadata_publicprojection → tokenize → set JWT cookie. →src/login.ts(completeLogin/readRoles/sessionCookie,SESSION_COOKIE), wired intoapp.tsatGET /auth/complete— wherekratos.ymlnow lands the browser after a successful login (login.after.default_browser_return_url). The route:whoami(cookie)→ identity (id/email; no session ⇒ 303/login);readRoleslistsRole:*#members@user:<id>from Keto (one paged read, sorted/de-duped; group→role transitivity is §5); projects{roles}onto the identity; thenwhoami(tokenize_as: plainpages)→ the signed JWT, stored asplainpages_jwt(HttpOnly + SameSite=Lax + 30d,securedeferred to §9).server.tsbuilds the kratos-admin + keto clients and passes all three tocreateApp. Design bug caught in live boot-verify + fixed: the projection had to movemetadata_admin→metadata_public— Kratos strips admin metadata from the session the tokenizer reads, sometadata_adminyieldedroles:[];metadata_publicis carried (and the user already reads these coarse roles in their own JWT, so nothing leaks). Touchedkratos-admin.ts(updateMetadataAdmin→updateMetadataPublic,/metadata_publicpatch), the tokenizer jsonnet, and the kratos.yml/README rationale. Tests-first:login.test.ts(readRoles paging/dedup; completeLogin order whoami→project→tokenize; no-session⇒null; missing email⇒null; no-JWT⇒throw; cookie flags) +app.test.tsintegration (/auth/completeprojects roles, setsplainpages_jwt, 303→/; no session ⇒ 303/login, no cookie) +kratos.test.ts(after-login URL + jsonnet metadata_public). Boot-verified the whole chain live: real admin login →/auth/complete→ JWT{sub, email, roles:["admin"], exp−iat=600}, identity re-projectedmetadata_public:{roles:["admin"]}from Keto (wiped first to prove the write); no-session ⇒ 303/login; torn down. The full-stack login Playwright E2E is owned by §8. typecheck + 189 units green. - JWT middleware: verify signature via cached JWKS, validate
exp/iss/aud(+clock skew), build context (user, roles). →src/jwt-middleware.ts(authenticate/verifyToken/validateClaims/claimsToUser) is the per-request hot path that never calls Ory: read theplainpages_jwtcookie →decodeJwsthekid→ resolve the verify key from the cached JWKS →verifyJws(§0 signature/alg-confusion guards) → validate claims → project theUser(sub→id, email, roles).src/jwks.ts(JwksProvider,loadJwks,staticJwks) is the key-by-kidseam:loadJwksreads the mountedfile://tokenizer key (dev default + prod mount) or abase64://inline set;staticJwkspicks bykid, falling back to the sole key when a token carries none — HTTP fetch + TTL cache + rotation-on-miss is the next §4 item (line 85); the interface lets it drop in without touching callers. Claim checks:exprequired +nbfhonoured, both with a 60s clock-skew leeway;iss/audare opt-in — validated only whenJWT_ISSUER/JWT_AUDIENCEare pinned (new optionalconfig.tsfields), because the Kratos tokenizer sets neither (a clean clone must still verify).authenticatefails closed: any bad/expired/malformed token ⇒null(anonymous), so the route renders signed-out and the §2 permission gate denies. Wired intoapp.ts— verify once per request (after the static short-circuit, before routing/hooks), threaduserinto both the base and routeRequestContext, and feedctx.roles(was[]) into the dashboard nav;server.tsloads the mounted JWKS at boot + passes the pinned iss/aud. Tests-first:jwt-middleware.test.ts(key-by-kid across a rotated set, exp/nbf + skew, iss/aud only-when-configured, bad-sig/unknown-kid, claimsToUser sub/email/roles, authenticate fail-closed matrix),jwks.test.ts(kid select/sole-key/miss + file/base64/reject-http),config.test.ts(iss/aud optional),app.test.ts(a verified cookie authorizes the gated/demo/secret; no-cookie/expired ⇒ 403). typecheck + 199 units + 7 E2E green; boot-smoked server.ts loading the mounted key. The live-stack token-refresh/timeout E2E is the §4 line 90 item; the full login E2E is §8. - JWKS fetch + cache + rotation handling. →
src/jwks.ts:cachingJwks(load, opts)self-refreshing provider behind the existingJwksProvider.getKeyseam (drop-in, callers untouched) — holds keys forttlMs(5m), reloads on the next lookup past TTL, and on akidmiss reloads once more (rotation-on-miss → a freshly-prepended key verifies without a restart, README zero-downtime rotation), throttled byminRefetchMs(60s) so a stream of bogus kids can't hammer the source. A reload failure keeps the last-good set (transient resilience); only a cold cache propagates the error (→ middleware fails closed). Concurrent loads coalesce on one in-flight promise.createJwksProvider(jwksUrl)routes by scheme + primes at boot (fail loud):base64://→ immutablestaticJwks;file://→ re-readable cache (rotation by remount/edit);http(s)://→ newfetchJwks(Accept JSON, non-2xx throws).server.tsnowawait createJwksProvider(config.jwksUrl)(top-level await already present) — replacesstaticJwks(loadJwks(...)). Tests-first (jwks.test.ts: TTL cache+expiry, rotation-on-miss + throttle, last-good-on-error vs cold-load-propagates, scheme routing + http prime/cache + fail-loud on non-2xx/missing-file/bad-scheme). README Layout line updated; the JWT signing key & rotation + flow-diagram cache notes already described this. typecheck + 203 units green; boot-smoked the file:// prime path. Guards/re-mint/logout/CSRF are the next §4 items. - Guards:
requireSession(validate JWT),can(role)(claim, in-process),check(relation, object)(live Keto). →src/guards.ts: in-handler authorization (imperative counterpart to the §2 declarative routepermissiongate; the JWT was already verified once by the §4 middleware →ctx.user/ctx.roles, so these never call Ory for the coarse tiers).requireSession(ctx)asserts a session → returns theUser, else throwsGuardError(401, location:/login);can(ctx, role)is the coarse zero-I/O JWT-claim predicate (anonymous ⇒ false);check(keto, ctx, {namespace, object, relation})is the one live Keto call (fine-grained relationship tier, README) — subject =user:<id>, anonymous ⇒ false fail-closed (no call). NewGuardError {status, location?};app.ts's request catch maps it (location ⇒ 303 redirect, else render the 403 page) before the 500 path, so a guard thrown anywhere in handling becomes the right response, never a 500. Tests-first:guards.test.ts(requireSession return/throw,canmatrix,checksubject + fail-closed) + anapp.test.tsHTTP integration (anonymous →/login,can/checkpass → 200 / fail → 403). README Building blocks +docs/plugin-contract.mdRoutes document them (dropped the "land with §4" marker). typecheck + 207 units green. Session re-mint / logout / CSRF are the next §4 items. - Session re-mint on TTL expiry (re-read roles from Keto). → "stay signed in": the ~10m JWT lapses but the 30d Kratos session lives, so the hot path silently re-mints instead of dropping to anonymous.
jwt-middleware.tsnow classifies the cookie viaresolveSession→{user, expired}(TokenError.expiredset only on a lapsed-but-intact token);authenticatedelegates to it.login.tsaddsremintSession(reusescompleteLogin: whoami → re-read roles from Keto → re-project → re-tokenize → fresh cookie + refreshed user — the one moment authz recomputes) +clearSessionCookie(Max-Age=0).app.tshot path: only when the token is expired (not absent/garbage) and the Ory clients are wired does it re-mint, setting the cookie viares.setHeaderso it rides whatever response follows; a dead Kratos session clears the stale cookie so later requests fall straight through to anonymous (no per-request Ory hit). Tests-first:jwt-middleware.test.ts(resolveSession lapsed-vs-absent/tampered matrix),login.test.ts(remintSession live→fresh / dead→clearing),app.test.ts(expired+live session → gated route runs + fresh cookie; expired+dead session → 403 + cleared cookie). typecheck + 210 units green. Live-stack token-timeout/refresh Playwright E2E is the §4 line 90 item. - Logout: revoke Kratos session + clear cookie. →
GET /logout(app.ts): clears our localplainpages_jwt(clearSessionCookie, Max-Age=0) and revokes the Kratos session. Kratos' own cookie lives on its origin, so we can't expire it from here — insteadkratos.createLogoutFlow(cookie)(newKratosPublicmethod,GET /self-service/logout/browser→{logoutToken, logoutUrl}, 401⇒null) and 303 the browser tologoutUrl; Kratos revokes the session, clearsplainpages_session, and lands on/login(kratos.ymllogout.after, already configured). No active session ⇒ just clear our cookie + 303/login. Wired the inert shell "Sign out" button →<a href="/logout">(zero-JS, matches the menu's existing link items). Tests-first:kratos-public.test.ts(logout flow 200→urls / 401→null + cookie forwarded),app.test.tsintegration (active session → Kratos logout URL + cleared JWT; no session →/login+ cleared JWT),shell.test.ts(sign-out link wired). typecheck + 212 units green. Boot-verified live: admin login →/logout303s to the real…/self-service/logout?token=ory_lo_…withplainpages_jwtcleared, following it revokes the session (whoami200→401) and redirects to/login; no-session/logout→/login; torn down. - Secure cookie flags; CSRF for our own POST forms. → Secure flag: new explicit
SECURE_COOKIEStoggle (config.ts, default off — dev is http;compose.ymlsets ittrue,compose.override.yml/compose.e2e.ymlfalse), threaded through every first-party Set-Cookie (session JWT, clear, re-mint, CSRF). CSRF:src/csrf.ts— stateless signed double-submit token<nonce>.<HMAC-SHA256(CSRF_SECRET, nonce)>(node:crypto, no dep):issueCsrfToken/verifyCsrfToken(self-validating, timing-safe),ensureCsrfToken(reuse a genuineplainpages_csrfcookie, else mint — one token across tabs),csrfCookie(HttpOnly+Lax, secure opt-in),verifyCsrfRequest(cookie genuine and field echoes it).src/body.tsreadFormBody(size-capped urlencoded reader; §5 forms reuse it). Applied to our one first-party form: logout is now a CSRF-guardedPOST—shell.ejs's Sign-out is a<form method=post action=/logout>with a hidden_csrf(semantic win: a state change is a form, not a GET link),app.tsissues the token cookie onGET /and verifies it onPOST /logout(bad/missing → 403, before any Kratos call);dashboard.ts→index.ejs→shell thread the token. Kratos' own flows keep Kratos' CSRF; the host does not auto-gate plugin routes (they own their body/safety per the contract). Switched the cookie-setting sites toappendHeaderso the CSRF cookie coexists with others. Tests-first:csrf.test.ts/body.test.ts+ extendedconfig/dashboard/shell/apptests (logout POST: valid→Kratos logout + cleared JWT, no-session→/login, missing/forged→403) + an Ory-free E2E (GET / issues the cookie + matching form token; tokenless POST→403). typecheck + 217 units + 8 E2E green. Boot-verified live on the full stack: GET / double-submit token matches; admin login →POST /logout303s to the real…/self-service/logout?token=ory_lo_…with the JWT cleared; no-session→/login; forged/missing→403; torn down. - Make sure we have E2E tests for token timeouts and refresh (maybe by shorten the token lifetime to very low or something). → New full-stack Playwright suite
e2e/auth-refresh.spec.ts(run viacompose.e2e-auth.yml): boots the real Ory stack (Postgres + Kratos + Keto + bootstrap + web), logs in the seeded admin, completes login on web → session JWT, then proves the §4 "stay signed in" hot path end-to-end — once the token lapses the next request is silently re-minted from the live Kratos session (fresh JWT, laterexp, roles re-read from Keto =["admin"]); revoking the Kratos session (admin API) then makes the next lapsed request clear the stale cookie (→ anonymous). To make timeout/refresh observable in seconds not ~10m:ory/kratos/e2e.yml(merged via a second-c) shortens the tokenizerttlto 8s and pointsserve.public.base_urlatkratos:4433(so the runner drives self-service over the compose network), and a new explicitJWT_CLOCK_SKEW_SECconfig (default 60, the E2E sets0) makes web treat the JWT as expired the instant its ttl lapses instead of +60s. The flow is driven over HTTP (fetch + manual cookie relay) because Kratos/web sit on different hosts here — it exercises web's own server-side relay; the browser-UI login stays §8. Scoped the existing visual suite tovisual.spec.ts(stays Ory-free/fast) so the two suites don't cross-run. Tests-first for the config knob (config.test.ts). Verified live: auth suite green (re-mint + clear), visual suite still 8/8 green; typecheck + 218 units green; both stacks torn down. - Run the architecture and the product reviewer agents on the whole project, not just the latest changes, and address their issues. → Ran both on the whole project (weighted to the §4 auth hot path). Verdict: no Critical/High; both confirmed the auth core (alg-allowlist JWS verify, fail-closed
resolveSession, key-by-kidcache, timing-safe CSRF, traversal guards) is sound, and that a tampered/garbage cookie can't drive the Ory re-mint round-trip (only a validly-signed, time-expired token setsexpired). Fixed now (tests-first): (1) MEDIUM (stability) — the re-mint hot path turned an Ory outage into a 500 on every lapsed request (a dead Kratos session returnsnulland clears cleanly, but a 5xx/refused/timeout throws and escaped to the 500 handler). Wrapped theremintSessioncall inapp.tsin try/catch → degrade to anonymous (route renders signed-out / guard bounces to/login), and leave the cookie untouched so it re-mints once Ory recovers;app.test.tsre-mint test now also asserts outage→403-not-500 + no cleared cookie. (2) MEDIUM (architecture) — a plugin folder named after a host route (login/logout/auth/public/recovery/registration/settings/verification) would silently shadow it (plugin routes resolve first), the one collisionfindConflictsdidn't catch. AddedRESERVED_PLUGIN_IDS(plugin.ts) checked indiscovery.ts→ fails boot loud, like every other conflict; documented indocs/plugin-contract.mdIdentity;discovery.test.tscovers it. Deferred (reviewer-scoped, not §4): extractbuildShellContextout ofdashboard.ts+ thread the realctx.userinto the shell (kills the hardcoded "Sam Rivers" demo profile) and give the host its own internal route table viamatchRoute/isAuthorized→ §5 (the 2nd/3rd built-in screen is the forcing function; the hardcoded user is the one user-visible §4 gap, so §5 opens with it);/auth/completelogin-CSRF hardening + thePOST /logoutoversized-body→500 papercut → §9 (security headers/CSRF/cookies); retarget the stalesafeUrl()§4 reference in the contract doc → the next §4 comment-cleanup item (line 92), helper itself deferred to §5/§7 when untrusted URL data first flows. No action: forwarding the full cookie header to Kratos on re-mint (works, mild over-coupling), the deliberately-opt-iniss/audclaim checks, theserializeCookielength bound. typecheck + 219 units green. - Go over all comments in the code and the README and try to make it shorter and more information dense. Remove not strictly needed stuff. → Pass over the §4 auth accretion (the §3 cleanup at line 74 stands). The §4 comments were authored dense, so the wins are targeted: tightened the verbose client module-headers —
kratos-public.ts(dropped the "themed flow pages build on this" forward-ref, kept the loose-ui.nodes-types rationale),kratos-admin.ts(folded the admin-port note up, trimmed theKratosErrorrestatement),keto-client.ts(dropped the caller-listing tail). Retargeted the stalesafeUrl()ref indocs/plugin-contract.md(the §4 reviewer flag at line 91): the helper was deferred to §5/§7, not §4. Left intact: app.ts's per-branch why comments (right altitude for scanning the request flow), config.ts's dense field notes, and the §4 README Auth, sessions & permissions sections (the canonical design rationale, authored concise in §4)._(planned)_markers stay for §9 (line 133 owns dropping them). typecheck + 219 units green. - Go over all tests and combine/unify ones that cover the same stuff or are very related and could be combined in a good way. Remove tests that aren't helping, we only want tests that are actually helpful to us. → Pass over the §4 auth tests. The clients (
kratos-public/kratos-admin/keto-client) and the focused units (jwks/flow-view/guards/csrf/body/login) already follow the per-module "matrix + edge" pattern, no fat to cut. Removed the two genuine §4-era overlaps: (1)jwt-middleware.test.tsre-ranresolveSession's whole classification matrix again underauthenticate— butauthenticateis justresolveSession(...).user, so merged into one test whereresolveSessionowns the matrix andauthenticateis asserted as its fail-closed user-projection (keptauthenticateitself — a documented convenience export, just not double-tested). (2)app.test.tshad two/auth/completeHTTP tests (live-session vs no-session) for one route → merged into one (happy path + edge), mirroring the project's style. 219 → 217 tests, zero coverage lost; typecheck + tests green.
5. Built-in admin screens (writes go only to Keto/Kratos)
- Users: list (Kratos identities) with filter/sort/pagination; create/edit/deactivate/delete; trigger recovery. →
src/admin-users.ts: pure view-model + Kratos-payload builders (toUserView,buildUsersListModel,buildUserFormModel,create/updateIdentityPayload,setStatePayload) +handleAdminUsers(the imperative shell app.ts dispatches/admin/users*to). Routes:GET /admin/users(list — filter by q/status, sortable headers, paginate; in-memory over one fetched Kratos page since the admin API has no search/sort),GET|POST /admin/users/new+/(create),GET|POST /admin/users/:id(edit; email is the read-only login identifier, name editable, optional initial password),POST …/:id/state(deactivate↔reactivate),…/delete,…/recovery(mints a code via the newkratosAdmin.createRecoveryCodeadmin endpoint, renders the link). Writes go only to Kratos (README "stateless"). Gated admin-only (anonymous→/login, non-admin→403 viaGuardError) and every mutation is CSRF-guarded (signed double-submit, like logout); reuses the §1 building blocks (filter-bar/data-table/pagination/field) around the app shell. Reviewer's §5 opener done too: extractedsrc/shell-context.ts(buildShellContext/shellUser) shared by the dashboard + admin screens — kills the hardcoded "Sam Rivers" demo profile, threads the real signed-in user (email/derived initials; anonymous→Guest);dashboard.ts+app.tsnow passctx.user. Addedreadonlytofield.ejs,admintoRESERVED_PLUGIN_IDS(a plugin folder can't shadow the screens),views:[viewsDir]to the core renderer (so a subfolder view includes the sharedpartials/by root-relative name). Tests-first:admin-users.test.ts(mapping/selection/payload matrix),app.test.tsHTTP integration (gate/list-filter/create/edit/state/delete/recovery + CSRF reject),shell-context.test.ts,kratos-admin.test.ts(recovery endpoint),discovery.test.ts(reservedadmin). typecheck + 228 units + 8 visual E2E green. Boot-verified live on the full Ory stack: seeded-admin login → JWTroles:["admin"]→/admin/userslists identities; create→303→listed, recovery→real Kratos code/link, state→inactive, delete→absent, forged CSRF→403; torn down. Groups/roles/menu-wiring are the next §5 items. - Groups: Keto subject sets — list/create/delete + membership management. →
src/admin-groups.ts: pure view-model + Keto-tuple builders (groupsFromTuples,parseSubject/memberTuple,memberView,isValidGroupName,buildGroups{List,Detail,Form}Model) +handleAdminGroups(the imperative shell app.ts dispatches/admin/groups*to). A group is a Keto subject setGroup:<name>#members; a member is a user (subject_id=user:<uuid>) or a nested group (subject_set=Group:<other>#members). Keto has no create-object, so a group exists while it has ≥1 member: create writes the first-member tuple (requires a member, rejects a duplicate/invalid name), delete removes every member tuple (one delete-by-partial-filter), add/remove member write/delete one tuple. Routes:GET /admin/groups(list — search/sort/paginate over one Keto namespace scan),GET|POST /admin/groups/new+/(create),GET /admin/groups/:name(membership detail — members by email, add a user/nested group, remove, delete-group),POST …/members·…/members/delete·…/delete. Writes go only to Keto (README "stateless"); Kratos is read only to label the member pickers by email. Gated admin-only (anon→/login, non-admin→403) and every mutation CSRF-guarded, same as Users; reuses the §1 building blocks around the shell. Extractedsrc/admin-nav.ts(shared Dashboard·Users·Groups sidebar nav) so the two screens can't drift; added a genericrowHeader<th scope=row>data-table cell (the group name links to its detail). Tests-first:admin-groups.test.ts(builder/validation/subject matrix),app.test.tsHTTP integration (gate/list/create/dup-reject/detail/add/remove/delete + CSRF + invalid-name & malformed-%→404),data-table.test.ts(rowHeader). Stability-reviewer (treated as a local PR): APPROVE; fixed its nits — symmetric subject validation (UUID-check the user id), "already exists" feedback on create, malformed-%→404 (safeDecode). typecheck + 237 units green. Boot-verified the core Keto interactions live (namespace listing, group-collapse counts, delete-group-by-filter, single-member removal). The full-stack groups-CRUD Playwright E2E is §8's scope (line 123), as with the Users screen. Roles/permissions + global-menu wiring are the next §5 items. - Roles & permissions: Keto relations — assign roles to users/groups; "effective access" view via Keto expand. →
src/admin-roles.ts: a role is a Keto subject setRole:<name>#members(OPL: members are users or groups, resolved transitively — the source of truth the §4 login projects into the JWT). Same shape as the Groups screen, so the pure membership helpers are reused fromadmin-groups.ts(parseSubject,isValidGroupName,memberView,groupsFromTuples, and now-exportedpagedTuples/memberCandidates/safeDecode). Routes (handleAdminRoles, dispatched by app.ts):GET /admin/roles(list — search/sort/paginate over one Keto scan),GET|POST /admin/roles/new+/(create = assign first member; rejects invalid/duplicate name),GET /admin/roles/:name(detail),POST …/members(assign a user/group) ·…/members/delete(revoke) ·…/delete(remove all member tuples). The one role-specific piece is effective access:keto.expand(Role:<name>#members, {maxDepth:50})→expandToEffectiveUsersflattens the tree to the distinct users who hold the role directly or transitively via a group (the coarse JWT projection stays direct-only per the README's one-read-per-login design; this view is where group→role inheritance is surfaced). Writes go only to Keto; Kratos is read only to label members. Gated admin-only (anon→/login, non-admin→403) + CSRF-guarded, like Users/Groups. Added a "Roles" entry (i-shield) to the sharedadmin-nav.ts; new.plain-listCSS rule. Tests-first:admin-roles.test.ts(builders + expand-flatten matrix) +app.test.tsHTTP integration (gate/list/create/dup-reject/assign user&group/effective-access-via-expand/revoke/delete + CSRF + malformed-name→404). Stability-reviewer run as a local PR: APPROVE, no Critical/High; addressed its expand-depth nit (explicitmaxDepth). 237→243 units + typecheck green. Live boot-verify caught a real bug the tests missed: Keto v26.2.0's expand nests the subject undertuple({type:"leaf",tuple:{subject_id}}), not at the node top-level as the §4ExpandTreetype had guessed — fixed the type + walker + the (wrongly-shaped) fixtures, then re-verified live that a user reachable only through a group surfaces in effective access; torn down. Global-menu wiring is the next §5 item. - Wire into the menu (admin section, permission-gated). → Extracted
adminSection(current?)inadmin-nav.tsas the single source of truth for the built-in screens' menu links: a permission-gated (admin) "Admin" header whose children are Users/Groups/Roles. Wired into the global dashboard menu (dashboard.tsappendsadminSection()) so an admin sees the section on/;composeNav'sfilterByRolesdrops the whole gated header + subtree for a non-admin/anonymous (cosmetic — the routes themselves stay independentlyGuardError(403)-gated). The in-screenadminNav()now reuses the sameadminSection(current)(Dashboard link + the active-marked section) so the two navs can't drift; narrowedAdminScreentogroups|roles|users(the home link was nevercurrent). Reuses existing sprite icons (no icon-guard change). Tests-first:dashboard.test.ts(admin→section present with the three hrefs; non-admin→absent) +app.test.tsHTTP integration (admin JWT→/admin/userslink rendered, anonymous→absent). Default anonymous/render is byte-equivalent (section filtered out) so the visual E2E is unaffected. README Layout line updated. Stability-reviewer run as a local PR: APPROVE, no Critical/High/Medium. 242→244 units + typecheck green. - Run the architecture and the product reviewer agents on the whole project, not just the latest changes, and address their issues. → Ran both on all of
src//views//config//docs (weighted to the §5 admin screens). Architecture: no Critical/High (functional-core/imperative-shell genuinely honored, security primitives sound). Product: 2 Critical + 1 High. Fixed now (tests-first): (1) Critical (product) — the Roles "Effective access" view showed group→role membership transitively butlogin.tsreadRolesgranted only direct memberships into the JWT, so a user holding a role only via a group was listed as having it yet gated as if not (two screens contradicting). Per the user's call, madereadRolestransitive: enumerate the defined roles + Keto-checkeach (resolves group membership), so the JWT now matches the Effective-access view + the OPL model — at login/refresh only, never per request (README login section +admin-roles.tsheader updated). (2) Critical (product) — no confirmation on destructive actions: added a server-rendered (zero-JS) confirm step (views/admin/confirm.ejs+partials/confirm-body.ejs, sharedbuildConfirmModel) —GET /admin/{users,groups,roles}/:id/deleterenders an interstitial (Cancel + the real POST); each detail/edit Delete control is now a link to it. (3) High (product) — self-lockout: an admin can no longer delete or deactivate their own account, revoke their own (direct) admin grant, or delete the admin role outright (each → 400 + inline error). Covers the direct-grant paths (incl. the bootstrap-seeded admin, which holds a direct grant); admin held only via a group can still be self-revoked, so the robust "last effective admin won't drop" check is deferred to §9 (stability-reviewer Medium). (4) MEDIUM (arch M1 pt.1) — extracted the gate+CSRF preamble copied verbatim across the 3 admin handlers intoadmin-nav.tsrequireAdmin/guardedForm(one security-critical copy, can't drift). (5) MEDIUM (arch M4) —shellUserno longer blanks the email: name = email local part, full email beneath (matchestoUserView). Tests-first throughout (extended the 3 admin HTTP tests + login/shell-context units); typecheck + 244 units + 8 visual E2E + the full-stack auth-refresh E2E green (the latter re-verifies live login→transitivereadRoles→roles:["admin"]). Deferred (reviewer-scoped, not the §5 checkpoint): the host internal route-table (fold the admin if-ladder + Hydra intomatchRoute/isAuthorized, arch M1 pt.2) → §6 (the 2nd/3rd Hydra screen is the forcing function); admin list-model/template near-duplication across Users/Groups/Roles (arch M3) → the §5 comment/test-cleanup items below (lines 101–102); success-flash after writes + welcoming empty-list states + warn-on-dangling-group-references + >250-row truncation notice (product Medium) → §5 polish / §8 E2E;safeUrl()href helper (arch L1 — the recovery link is server-built, not exploitable today) → §7 (first untrusted-URL flow); oversized-body→500 should be 413 (arch M2) + prod Ory-URLhttpsenforcement (arch L3) +§N-in-comments / README Layout drift (arch L4) → §9 (ops/security). - Go over all comments in the code and the README and try to make it shorter and more information dense. Remove not strictly needed stuff. → Pass over the §5 admin accretion. The §5 code was authored dense, so the wins are targeted: tightened the three near-identical module-header blocks (
admin-users/admin-groups/admin-roles) — dropped per-file restatement the README/code already carry (subject-form detail → "see parseSubject", "no user/group store" → covered by README "stateless", the verbatim "it gates… CSRF-guards… maps each action to a RouteResult" boilerplate → "gated admin-only, CSRF-guarded"). README Layout: compressed theviews/run-on (long admin/ + per-body-partial enumeration → grouped) and fixed an accuracy gap — it now lists the §5 delete-confirm view. Left intact: the EJS view config-doc headers (the only schema for untyped locals), the security-rationale comments, and the legitimate §9 forward-ref inadmin-roles.ts(the deferred last-effective-admin check). Docs/comments-only (per AGENTS.md, no stability-reviewer needed); typecheck + 244 units green. - Go over all tests and combine/unify ones that cover the same stuff or are very related and could be combined in a good way. Remove tests that aren't helping, we only want tests that are actually helpful to us. → Pass over the §5 admin tests. The genuine §5-era duplication was all in
app.test.ts: the three admin-screen HTTP tests (Users/Groups/Roles) each repeated an identical ~13-line harness preamble (createApp + listen + url + CSRF token + admin cookie + get/post), an identical 5-line gate block, and a stateful in-memoryKetoClientdefined 3× (the trivialstubKeto+ two byte-identical inline fakes). Unified into shared helpers —adminHarness(t, opts)→{url, token, get, post},assertAdminGate(url, get, path), and onefakeKeto(tuples?, over?)that subsumesstubKeto(the login tests now usefakeKeto([], …)) and both inline admin fakes (fakeKeto(tuples)/fakeKeto(tuples, { expand })); hoisted the sharedsameSet/matchesTupleup next to it. The per-module unit files (admin-users/groups/roles + the focused units) already follow the deliberate matrix pattern and the §3/§4 "don't force-merge across distinct modules" rule, so the near-identicalbuild*ListModeltests stay per-file (each guards its own function; the source-side list-model dedup is the deferred arch-M3 item, not the test side). −30 net lines, zero coverage lost; typecheck + 244 units green.
6. Hydra — OAuth2/OIDC provider (can ship after the rest)
- Login-challenge handler: authenticate via Kratos session, accept/reject. →
src/hydra-admin.ts(createHydraAdmin): typedfetchwrappers over Hydra's OAuth2 admin API (port 4445, no SDK,fetchImpl-injectable like the kratos/keto clients) —getLoginRequest/acceptLoginRequest/rejectLoginRequest+ aHydraErrorcarrying.status.src/oauth-login.ts(resolveLoginChallenge, pure):getLoginRequest→ skip (Hydra already authenticated the subject) ⇒ accept it without touching Kratos; a live Kratos session (whoami) ⇒ accept with that identity as the subject (remember, browser-session lifetime); no session ⇒ bounce to our themed/login?return_to=<absolute self URL>, so Kratos lands back on the challenge once signed in. Wired intoapp.tsatGET /oauth2/login(gated onhydra+kratospresent; missinglogin_challenge→400; the absolute return target derives from the request Host + the SECURE_COOKIES scheme — a spoofed Host can't escape, Kratos validatesreturn_toagainst its allow-list);/loginnow bakes areturn_tointo the Kratos flow init so the round-trip works.config.tsgainshydraAdminUrl(defaulthttp://hydra:4445);server.tsbuilds the client;compose.ymlwebnow gates onhydrahealthy (the app consumes it). Tests-first:hydra-admin.test.ts(request contracts + error mapping),oauth-login.test.ts(skip/session/no-session matrix),app.test.ts(HTTP: accept→Hydra redirect / no-session→/login bounce / missing-challenge→400 //loginreturn_to forwarding),config.test.ts+compose.test.ts(web↦hydra dep). Full-stack E2Ee2e/oauth-login.spec.ts(compose.e2e-oauth.yml): boots the real stack incl. Hydra, registers an OAuth2 client, starts an authorization flow, asserts the unauthenticated bounce and the authenticated accept (→ Hydra/oauth2/auth?…login_verifier=…) — green, then torn down. Stability-reviewer run as a local PR: APPROVE, no Critical/High; addressed its one stability warning — a stale/invalid/consumed challenge (Hydra 4xx, user-reachable via back button/slow login) now degrades to a recoverable 400 instead of a 500, while a genuine Hydra 5xx outage still surfaces as 500 (mirrors the themed-flow + §4 re-mint hardening). Deferred (reviewer-scoped, §9): document that prodallowed_return_urlsentries must be exact origins with a trailing/(the return_to safety leans on Kratos' allow-list). typecheck + 253 units + 8 visual E2E green. Consent handler + client registration are the next §6 items. - Consent-challenge handler: show / auto-accept first-party, grant scopes, accept/reject. →
src/hydra-admin.tsgains the consent half of the handshake (getConsentRequest/acceptConsentRequest/rejectConsentRequest+ConsentRequest/AcceptConsent/ConsentSessiontypes; the login/consent URL builder folded into onereqUrl(kind,…)+ a sharedput()).src/oauth-consent.ts(pure, sibling ofoauth-login.ts):resolveConsentChallenge→ skip (Hydra already consented / a skip-consent client) or first-party (the client's Hydrametadata.first_party === true) ⇒ auto-accept, else return aviewto show the themed consent screen;acceptConsent(re-reads the challenge so scopes/audience are never client-supplied) +rejectConsent(access_denied). The grant carries an OIDCsession.id_tokenwithemail/nameprojected from the Kratos identity (whoamitraits; absent ⇒ omitted). Wired inapp.tsatGET|POST /oauth2/consent(gated onhydra+kratos): GET shows/auto-accepts (sets the page CSRF cookie when fresh), POST is CSRF-guarded (same signed double-submit as/logout) and dispatchesdecision=allow→accept / else→reject → 303 to Hydra; a stale/consumed challenge (Hydra 4xx) degrades to a recoverable 400, a genuine outage (5xx) → 500 (mirrors/oauth2/login).views/oauth-consent.ejs+partials/consent-body.ejsreuse the auth-card: the consent screen lists the requested scopes (friendly labels for the standard OIDC ones) with Allow/Deny submit buttons. Tests-first:hydra-admin.test.ts(consent request contracts),oauth-consent.test.ts(skip/first-party/third-party/audience/id_token/accept-refetch/reject matrix),app.test.tsHTTP integration (auto-accept / screen render+CSRF cookie / allow+deny / forged-CSRF→403 / missing→400 / stale→400 / outage→500). Stability-reviewer run as a local PR: APPROVE, no Critical/High. Extended the full-stack E2Ee2e/oauth-login.spec.tsto drive the whole authorization-code flow against real Hydra — login accept → follow the login_verifier through Hydra → web's consent screen (third-party cliente2e-login, scopes listed) → Allow → consent_verifier → the client callback with a realcode(per-host cookie jars; Hydra resume URLs rebased onto the compose host). typecheck + 262 units + 8 visual + OAuth login+consent E2E green; stack torn down. OAuth2 client registration is the next §6 item. - OAuth2 client registration (admin UI or CLI). → Built-in OAuth2 clients admin screen (
src/admin-clients.ts,/admin/clients) — the §6 client side of Hydra (apps that log in through us).src/hydra-admin.tsgains the client half of the admin API:createClient/listClients/getClient/deleteClientover/admin/clients(+ anextPageTokenLink parser, mirrors kratos-admin) and the registration fields onOAuth2Client. The screen mirrors the §5 Users/Roles pattern — pure builders (toClientView,clientPayload,validateClientInput,parseRedirectUris,buildClients{List,Form,Detail}Model) +handleAdminClients(the imperative shell app.ts dispatches/admin/clients*to). Routes:GET /admin/clients(list — search/paginate over one Hydra page),GET|POST /admin/clients/new+/(register),GET /admin/clients/:id(read-only detail),GET|POST …/:id/delete(confirm + delete). Register builds a standard authorization-code client (+ refresh_token), confidential (client_secret_basic) or public (PKCE,none), with an optional first-party (auto-consent) flag; Hydra returns theclient_secretonce, so the register POST renders the new client's detail page with the one-time secret directly (no PRG) — never re-shown (getClientcarries no secret; detail asserts it). Writes go only to Hydra; gated admin-only (anon→/login, non-admin→403) + every mutation CSRF-guarded, like §5; a Hydra 4xx (bad redirect/scope) re-renders the form (400), a 5xx → 500 (mirrorsoauth-login.ts);:idviasafeDecode(malformed→404). Wired into the sharedadminSection(Users·Groups·Roles·OAuth2 clients,i-globe) so it shows for admins, invisible otherwise. New views (admin/clients,client-form,client-detail+partials/client-{form,detail}-body) reuse the shell/filter-bar/data-table/field blocks; one.detail-listCSS rule. Tests-first:hydra-admin.test.ts(client CRUD contracts incl. Link pagination/404→null/204),admin-clients.test.ts(builder/validation/payload matrix),app.test.tsHTTP integration (gate/list/register-shows-secret-once/invalid+CSRF-reject/detail-hides-secret/delete + malformed-%→404). Stability-reviewer run as a local PR: APPROVE, no Critical/High; addressed its one nit (dropped a deadURL.protocolcheck invalidateClientInput). Boot-verified the client CRUD live against real Hydra v26.2.0 (create→201 w/ one-time secret → list finds it → get → delete → get null); torn down. typecheck + 274 units green. Review/comment/test-cleanup are the next §6 items. - Run the architecture and the product reviewer agents on the whole project, not just the latest changes, and address their issues. → Ran both on the whole project (weighted to the §6 Hydra OAuth2 surfaces). Architecture: no Critical; Product: no Critical this checkpoint. Fixed now (tests-first): (1) HIGH (arch) —
/oauth2/logoutwas published to Hydra (hydra.ymlurls.logout) and asserted inhydra.test.ts, but had no handler (a dead/published contract — Hydra's RP-initiated logout would 404). Addedhydra-admin.acceptLogoutRequest(PUT logout/accept, folded into the sharedreqUrl(kind…)) + aGET /oauth2/logoutbranch: accept thelogout_challenge→ 303 to Hydra's post-logout redirect; missing challenge → 400; a stale/consumed 4xx → recoverable 400, a 5xx outage → 500 (byte-identical degrade to the login/consent siblings). GET-accept is safe — the challenge is Hydra-minted + single-use; the first-partyPOST /logoutstill owns ending the Kratos session + our JWT cookie. (2) HIGH (arch) — addedoauth2toRESERVED_PLUGIN_IDS(aplugins/oauth2/folder would silently shadow the provider routes — the one route surface the §4 reserved-id fix didn't cover; discovery now refuses it loud). (3) Product Blocker — the consent screen never told the user whose account they were authorizing (informed-consent gap on shared devices). It now renders "Signed in as<email>" (ConsentView.accountfromwhoami) + a "Not you? Sign out" form (CSRF-guarded by the same signed double-submit). (4) MEDIUM (arch) — consentaccept()now projects id_token claims only when the live Kratos session subject===the challenge subject Hydra bound at login (never leak a mismatched session's email/name into the issued token; guards the auto-accept path too). (5) Product nits — register-form confidential-vs-public guidance ("Browser/mobile apps can't keep a secret — choose Public…") and a client-detail "to change a client, delete and re-register — the secret is shown only once" note (covers the no-edit friction + lost-secret-on-reload). Stability-reviewer run as a local PR: APPROVE, no Critical/High; addressed its actionable follow-ups (README §6 now documents the logout handler + the consent identity line; a comment notes the GET-accept is Hydra-validated). Extendede2e/oauth-login.spec.tsto assert the consent screen names the signed-in account; boot-verified the full OAuth2 login+consent flow live against real Hydra v26.2.0 (E2E green) then torn down. typecheck + 279 units green. Deferred (reviewer-scoped, not the §6 checkpoint): the host internal route-table (fold the admin/oauth if-ladder into one{method,prefix,handler}table, deriveRESERVED_PLUGIN_IDS/allowedMethodsfrom it — arch M1, the long-deferred §2/§5 item) → §9: H1/H2 are now point-fixed, so M1 is reduced to a pure dedup/structural improvement (Medium) best done as a focused standalone change to the central dispatcher, not bundled into a review-fix; the RP-initiated-logout browser/live E2E (needs token-exchange +id_token_hint+post_logout_redirect_uris) → §8 (owns full E2E — the handler is unit+HTTP covered and reuses thecomplete()path already live-verified by the login/consent accepts); the redirect-URI scheme allowlist + thesafeUrl()href helper (arch L1) → §7 (first untrusted-URL flow); full client edit (registration-only by design — the detail page now says delete+re-register), the blank empty-list state (known §5 deferral), and success-flash after writes → §8/polish; unconditionalrefresh_token+ raw custom-scope labels (product 🟢) → future. - Go over all comments in the code and the README and try to make it shorter and more information dense. Remove not strictly needed stuff.
- Go over all tests and combine/unify ones that cover the same stuff or are very related and could be combined in a good way. Remove tests that aren't helping, we only want tests that are actually helpful to us.
7. Example plugin (reference)
- Reference plugin (e.g. people directory or scheduling): list page fetching upstream data, a form that forwards writes upstream, permission-gated nav.
- Verify the full plugin contract end-to-end against the README.
- Run the architecture and the product reviewer agents on the whole project, not just the latest changes, and address their issues.
- Go over all comments in the code and the README and try to make it shorter and more information dense. Remove not strictly needed stuff.
- Go over all tests and combine/unify ones that cover the same stuff or are very related and could be combined in a good way. Remove tests that aren't helping, we only want tests that are actually helpful to us.
8. Testing & CI
- node --test units across helpers / router / nav / auth (tests-first throughout).
- Playwright full E2E: login (password + mocked SSO), menu filtering by role, users/groups/permissions CRUD, a plugin page, logout.
- E2E harness: bring up the full compose stack, seed Keto roles + a test identity, tear down after.
- Run the architecture and the product reviewer agents on the whole project, not just the latest changes, and address their issues.
- Go over all comments in the code and the README and try to make it shorter and more information dense. Remove not strictly needed stuff.
- Go over all tests and combine/unify ones that cover the same stuff or are very related and could be combined in a good way. Remove tests that aren't helping, we only want tests that are actually helpful to us.
9. Production, security, ops
compose.ymlprod: Ory + Postgres, secrets via env, no source mount.- Security headers; secure/HttpOnly/SameSite cookies; CSRF; clock-skew tolerance.
- Optional revocation denylist for instant role/session revoke.
- Structured logging / basic observability. use @larvit/log for OTLP compability - but add subtasks and stuff for supporting incoming trace id etc from a reverse-proxy etc.
- JWT signing-key rotation runbook.
- Refresh README
Layout+ drop_(planned)_markers as pieces land. - Run the architecture and the product reviewer agents on the whole project, not just the latest changes, and address their issues.
- Go over all comments in the code and the README and try to make it shorter and more information dense. Remove not strictly needed stuff.
- Go over all tests and combine/unify ones that cover the same stuff or are very related and could be combined in a good way. Remove tests that aren't helping, we only want tests that are actually helpful to us.
10. User added stuff
- Make some pages optionally available publicly.