7.3 KiB
todo
Scoring
Score = 100 * V / (2**S + 8)
Bar = 1
Next ID = 74
Items
| ID | Release | Blocked by | Exempt | Item | L | E | I | R | S | Moves | Score |
|---|---|---|---|---|---|---|---|---|---|---|---|
| 14 | 0.6.0 | Drop a double-clicked duplicate submit, with no client-side JavaScript. | 4 | 2 | 3 | 7 | 7 | 2 by 7, 1 by 4 | 1.4 | ||
| 67 | 0.6.0 | Group src/auth's modules into one subfolder per concern, with bootstrap.ts staying at src/auth/bootstrap.ts. |
3 | 1 | 2 | 4 | 6 | code health by 4 | 1.0 | ||
| 19 | 0.7.0 | question | Run the documented Docker commands on macOS and fix whatever misbehaves. | 2 | 2 | 1 | 3 | 3 | 1 by 3 | 3.3 | |
| 73 | 0.7.0 | owner | Reach the comprehension floor: make the request pipeline in src/http/app.ts and the locale and EJS-locals plumbing readable one unit at a time, so every dimension mean reaches 7.0. |
3 | 1 | 2 | 4 | 7 | code health by 7 | 0.9 |
Renamed
- 0.4.21 renamed to 0.5.0
- 0.4.22 renamed to 0.5.0
Details
14. Drop a double-clicked duplicate submit, with no client-side JavaScript.
A second identical POST is expected from a non-technical user, and today creates two users, mints two recovery codes, or registers two OAuth2 clients. It must not break a legitimately repeatable action. Sketch: a CSS-only affordance so the second click has nothing to hit, plus the host recognising a duplicate (same session, route and payload within a short window), logging and dropping it. Open: what identifies "the same submission" (a one-time token minted into each form beats hashing the payload), the window, where the record lives given the host is stateless, and how a plugin declares a route repeatable.
Touches:
src/http/app.ts:answerPluginRoute,answerBuiltinRoute,prepareRequest,requestCsrfsrc/plugin-host/plugin.ts:Route(small)src/auth/csrf.tspublic/css/styles.css: lines 323-340 (small)README.md:### Routes & handlers
67. Group src/auth's modules into one subfolder per concern, with bootstrap.ts staying at src/auth/bootstrap.ts.
src/auth holds 19 modules over several concerns: the per-request session path (jwt*, jwks,
denylist, csrf, gate, guards), the Ory clients (kratos-*, keto-client, hydra-admin,
fetch-timeout), the sign-in flows and their views (routes, login, flow-view), the OAuth2
provider (oauth-*), and the one-shot CLIs (bootstrap, gen-jwks). Pick folders a reader can
name, and update the folder list in docs/decisions.md → "src/ is grouped by concern". Leave
bootstrap.ts in place, per "bootstrap.ts stays under src/auth/". Plugins import only the
barrel, so only src/plugin-host/plugin-api.ts's paths change for them. Update the README file
map. Make src/auth easier to navigate, a place the seats found hard.
Touches:
src/auth/csrf.tssrc/auth/csrf.test.tssrc/auth/denylist.tssrc/auth/denylist.test.tssrc/auth/fetch-timeout.tssrc/auth/fetch-timeout.test.tssrc/auth/flow-view.tssrc/auth/flow-view.test.tssrc/auth/gate.tssrc/auth/gate.test.tssrc/auth/gen-jwks.tssrc/auth/gen-jwks.test.tssrc/auth/guards.tssrc/auth/guards.test.tssrc/auth/hydra-admin.tssrc/auth/hydra-admin.test.tssrc/auth/jwks.tssrc/auth/jwks.test.tssrc/auth/jwt-middleware.tssrc/auth/jwt-middleware.test.tssrc/auth/jwt.tssrc/auth/jwt.test.tssrc/auth/keto-client.tssrc/auth/keto-client.test.tssrc/auth/kratos-admin.tssrc/auth/kratos-admin.test.tssrc/auth/kratos-public.tssrc/auth/kratos-public.test.tssrc/auth/link-header.tssrc/auth/link-header.test.tssrc/auth/login.tssrc/auth/login.test.tssrc/auth/oauth-consent.tssrc/auth/oauth-consent.test.tssrc/auth/oauth-login.tssrc/auth/oauth-login.test.tssrc/auth/routes.tssrc/auth/routes.test.tssrc/auth/bootstrap.ts: import lines (small)src/auth/bootstrap.test.ts: import lines (small)src/plugin-host/plugin-api.ts: the../auth/export lines (small)src/plugin-host/plugin.ts: theGateimport (small)src/plugin-host/plugin.test.ts: theAUTH_FLOWSimport (small)src/plugin-host/discovery.ts: thegate.tsimport (small)src/plugin-host/system.ts: the three client-type imports (small)src/http/app.ts: the../auth/import lines (small)src/http/app.test.ts: import lines (small)src/http/app-admin.test.ts: import lines (small)src/http/app-auth.test.ts: import lines (small)src/http/app-i18n.test.ts: import lines (small)src/http/app-plugins.test.ts: import lines (small)src/http/builtin-route.ts: theGateimport (small)src/ui/chrome.ts: thegate.tsimport (small)src/ui/nav.ts: thegate.tsimport (small)src/test-tooling/app-harness.ts: import lines (small)src/server.ts: the./auth/import lines (small)src/function-limits.test.ts: thesrc/auth/keys (small)src/postgres.test.ts: thesrc/auth/bootstrap.tspath (small, only if bootstrap's path changes)README.md:## Project layout,## Users, groups & permissions(small),## Building blocks(small),### Instant revoke: the optional denylist(small),### OAuth2 provider (Hydra)(small),## JWT signing key & rotation(small),### Scheduled rotation(small),### Emergency rotation (key compromise)(small)package.json: thegen-jwksscript (small)compose.yml: thesrc/auth/bootstrap.tscomment and command (small)
19. Run the documented Docker commands on macOS and fix whatever misbehaves.
Needs a Mac. Two suspects, both from --user "$(id -u):$(id -g)": a macOS id -g is 20, which is
dialout inside the noble image, and Docker Desktop remaps bind-mount ownership in its VM.
73. Reach the comprehension floor: make the request pipeline in src/http/app.ts and the locale and EJS-locals plumbing readable one unit at a time, so every dimension mean reaches 7.0.
The scoring run on PR #247 at 7e8bdd9 gave means Navigation 7.50, Locality 6.63, Shape 6.88, Self-sufficiency 6.88, Overall 7.13. Locality is the lowest. Item 67 covers the src/auth folder, so this item leaves it out.
Places the seats named, to make easier to read:
src/http/app.ts:67createApp: about 130 lines of closures that refer to each other, andswitchBasereadsbuiltinRoutes, which is declared later; all four seats named it.src/http/app.ts:263prepareRequestandsrc/http/context.ts:97buildContext: chrome is memoized lazily in both, and an untypedsharedbag feeds the context, so a new context field touches about five declarations.src/http/app.ts:202Host: restates the options and locals a third time.src/i18n/locale.ts:81chosenLocale: recovers "was a locale requested" fromlocaleHref("/") === "/", so its name hides the mechanism.views/partials/data-table.ejs:74,views/partials/menu.ejs:22andviews/partials/filter-bar.ejs:26: EJS locals leak into includes, defended by explicit null options.src/server.ts:25delete process.env["PLUGIN_DB_SECRET"]: a load-bearing order rule in a top-level script.public/css/styles.css:81: the dark and light token mapping is written three times.src/auth/routes.ts:58flowFailure: Kratos statuses that no comment in the file explains.
Aim: a reader of one unit should not need the other units open beside it. Re-run the scoring run when it ships.