larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Refuse a PDU whose optional parameters do not end on command_length (#87)

Browse Source 
* Regression tests for a truncated TLV tail refused rather than accepted

* Refuse a PDU whose optional parameters do not end on command_length

* Assert the bare TLV header refusal against jsmpp instead of recording it as a defect

* Note the truncated TLV tail defect as fixed in the java-client findings

* Derive the padding position, share the bare TLV fixture and trim the decision record

* Regression tests for a PDU whose trailing C-Octet String a peer left out

* An absent trailing C-Octet String consumes no octet, so a bodyless PDU still parses

* Bound the TLV loop by the buffer it was given rather than a second spelling of its length

* Answer the stability review's questions in the record and pin the array contract
This commit is contained in:
Lilleman auf Larv
2026-09-06 18:01:35 +02:00
committed by GitHub
parent c89005168d
commit 039951e69b
11 changed files with 215 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/session-error.test.ts
+4 -3
View File
@@ -3,8 +3,8 @@ import test, { describe } from 'node:test';
import type { PduHeader, Session } from '../src/index.ts';
import type { TestContext } from 'node:test';
import { PduRefusedError, client, server } from '../src/index.ts';
import { bareTlvHeader, shortened, truncatedTlv, withUnknownCmdId } from './raw-pdus.ts';
import { closeAfter } from './teardown.ts';
import { shortened, truncatedTlv, withUnknownCmdId } from './raw-pdus.ts';
const receipt = {
destination_addr: '46709771337',
@@ -85,11 +85,12 @@ describe('telling a refused PDU from a failed session', () => {
peer.sock.write(withUnknownCmdId({ cmdName: 'enquire_link', seqNr: 9 }));
peer.sock.write(shortened({ cmdName: 'deliver_sm', params: receipt, seqNr: 6 }, 3));
peer.sock.write(truncatedTlv({ cmdName: 'deliver_sm', params: receipt, seqNr: 7 }));
peer.sock.write(bareTlvHeader({ cmdName: 'deliver_sm', params: receipt, seqNr: 8 }));
assert.ok(await waitFor(() => seen.length === 3), 'one sessionError per refused PDU');
assert.ok(await waitFor(() => seen.length === 4), 'one sessionError per refused PDU');
assert.deepEqual(
seen.map(err => (err instanceof PduRefusedError ? err.reason : err.message)),
['command', 'body', 'tlvs'],
['command', 'body', 'tlvs', 'tlvs'],
);
});