larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Separate a receipt's fields on any whitespace, not only a space

Browse Source 
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Csos3Vfm66NrAywQUe3e4V
This commit is contained in:
Lilleman auf Larv
2026-09-01 21:37:19 +02:00
parent a91c55cc64
commit 0fd6da1542
3 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
todo.md
-5
View File
@@ -170,11 +170,6 @@ session message is a change to every call site.
- [ ] **Coverage reporting.** `node --test --experimental-test-coverage` works today; nothing
publishes the numbers.
- [ ] **A receipt whose fields are separated by anything but a space reads as one field.**
`parseReceipt()` takes `id:` as everything up to the next space, so a peer writing CRLF
between fields yields an id of `1a2b\r\nstat:DELIVRD` — one nothing correlates and no
notation can read. Every field pattern has the same shape. Raised by review, 2026-08-30.
- [ ] **An `onReceipt` hook.** Receipt text is only loosely specified and operators disagree on it,
but `dlrFromPdu()` is wired into `IncomingRequests` with no seam of its own: an application
facing a format we do not parse has to take the whole PDU on `onRequest` and reimplement the