larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Reassemble a concatenated message segmented with the sar_* TLVs (#91)

Browse Source 
* Regression tests for inbound sar_* concatenation

* Reassemble a concatenated message segmented with the sar_* TLVs

* Record the sar_* fix in the jasmin and Java-client findings

* Name the sar_* TLVs in the refusal, and separate group keys the addresses cannot forge

* Name the field a refused segment got wrong, and key groups on a separator no address holds

* Bound the new session tests, and derive Concat from the UDH fields
This commit is contained in:
Lilleman auf Larv
2026-09-06 21:03:14 +02:00
committed by GitHub
parent 061c1871bd
commit 18de565aad
12 changed files with 595 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files
interop-tests/jasmin.test.ts
+3 -5
View File
@@ -514,15 +514,13 @@ describe('C8 (target 3) - long MO from an upstream SMSC, SAR vs UDH segmentation
await sendSarMo(upstreamSession, { from: TO, message: text, to: FROM });
// Recorded either way, per the task: one whole `sms` (Jasmin reassembled the SAR segments
// before forwarding) or several fragments (it relayed them, and our SAR-blind reassembler -
// keyed on UDH only - never groups them; see findings for which happened and the reproducer).
const whole = await waitFor(() => sms.find(s => s.message === text), 10_000);
const fragments = sms.filter(s => text.includes(s.message) && s.message !== '');
const fragments = sms.filter(s => s.message !== text && text.includes(s.message) && s.message !== '');
await session.close({ signal: AbortSignal.abort() });
assert.ok(whole ?? fragments.length > 0, 'expected either a reassembled sms or SAR fragments to arrive');
assert.ok(whole, 'expected the SAR segments to reassemble into one whole sms');
assert.deepEqual(fragments.map(s => s.message), [], 'no segment reaches the application on its own');
});
test('UDH-segmented deliver_sm from the fake upstream', async () => {