larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Reassemble a concatenated message segmented with the sar_* TLVs (#91)

Browse Source 
* Regression tests for inbound sar_* concatenation

* Reassemble a concatenated message segmented with the sar_* TLVs

* Record the sar_* fix in the jasmin and Java-client findings

* Name the sar_* TLVs in the refusal, and separate group keys the addresses cannot forge

* Name the field a refused segment got wrong, and key groups on a separator no address holds

* Bound the new session tests, and derive Concat from the UDH fields
This commit is contained in:
Lilleman auf Larv
2026-09-06 21:03:14 +02:00
committed by GitHub
parent 061c1871bd
commit 18de565aad
12 changed files with 595 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files
interop-tests/jsmpp.test.ts
+7 -11
View File
@@ -173,7 +173,7 @@ describe('S2 - long messages in every spelling (targets 2, 3, 5)', () => {
assert.equal(sms.answeredOnArrival, false);
});
test('sar_*: defect (target 3) - each segment reaches the application as its own sms, not one', async () => {
test('sar_* (target 3): one reassembled sms, each segment answered <base>-<n>', async () => {
await waitForSessions(1);
const text = 'sar-'.padEnd(200, 'c');
@@ -184,17 +184,13 @@ describe('S2 - long messages in every spelling (targets 2, 3, 5)', () => {
assert.equal(segments.length, 2);
// Neither segment ever arrives as the whole 200-char text: each is its own ordinary sms
// carrying only its own ~130-char slice, with its own unrelated (non-<base>-<n>) message id.
const first = await waitForSms(text.slice(0, 130), 15_000);
const second = await waitForSms(text.slice(130), 15_000);
const sms = await waitForSms(text, 15_000);
assert.equal(first.answeredOnArrival, false);
assert.equal(second.answeredOnArrival, false);
assert.notEqual(first.smsId, second.smsId);
assert.equal(allSms.some(entry => entry.sms.message === text), false);
void first;
void second;
assert.equal(sms.answeredOnArrival, true);
assert.equal(segments[0]?.messageId, `${sms.smsId}-1`);
assert.equal(segments[1]?.messageId, `${sms.smsId}-2`);
// Neither ~130-char slice ever reached the application on its own.
assert.equal(allSms.filter(entry => text.includes(entry.sms.message)).length, 1);
});
});