Fixed negative sms IDs on failure

2015-06-16 16:56:04 +02:00
parent 16be9689fa
commit 2f65fd118b
2 changed files with 10 additions and 6 deletions
@@ -17,7 +17,7 @@ var log    = require('winston'),
 function smsResp(status, callback) {
 	var sms   = this,
 	    tasks = [],
-	    localSmsId,
+	    params,
 	    err,
 	    i;

@@ -54,17 +54,21 @@ function smsResp(status, callback) {
 	// Build async tasks to run the responses in parallel
 	i = 0;
 	while (sms.pduObjs[i] !== undefined) {
-		if (sms.pduObjs[i].pduObj.params.esm_class === 0x40) {
-			localSmsId = sms.smsId + '-' + (i + 1);
+		if (sms.smsId) {
+			if (sms.pduObjs[i].pduObj.params.esm_class === 0x40) {
+				params = {'message_id': sms.smsId + '-' + (i + 1)};
+			} else {
+				params = {'message_id': sms.smsId};
+			}
 		} else {
-			localSmsId = sms.smsId;
+			params = {};
 		}

 		tasks[i] = sms.session.sendReturn.bind(
 			sms.session,
 			sms.pduObjs[i].pduObj,
 			status,
-			{'message_id': localSmsId},
+			params,
 			false
 		);