larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Name the goal that outranks, on the number the guard still lets through
Mirror / push (push) Successful in 4s
Details
Test / lint (pull_request) Successful in 22s
Details
Test / test (18) (pull_request) Successful in 29s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 29s
Details
Test / test (24) (pull_request) Successful in 35s
Details
Test / test (26) (pull_request) Successful in 30s
Details

Browse Source
This commit is contained in:
Lilleman auf Larv
2026-09-21 10:35:57 +02:00
parent 0c4e6000b0
commit 3eb93303c3
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
todo.md
+4 -2
View File
@@ -238,8 +238,10 @@ and is also what the panel ranked hardest — two methods, one answer.
sent. The numeric branch exists for a digit sequence (`message_id: 123`); the product-owner sent. The numeric branch exists for a digit sequence (`message_id: 123`); the product-owner
review of #18 recommends `Number.isSafeInteger(value) && value >= 0` with the refusal naming review of #18 recommends `Number.isSafeInteger(value) && value >= 0` with the refusal naming
the fix, since a 64-bit SMSC id loses digits to a JS number before this library ever sees it. the fix, since a 64-bit SMSC id loses digits to a JS number before this library ever sees it.
Goal 3. That a number is accepted at all reaches a consumer in no sentence either: only the Goals 2 then 3: `from: 1e21` is reported as sent to an address that reaches nobody, which is
type comment at `defs/commands.ts:239`, and one CHANGELOG line that stops being visible when the wrong answer about what happened before it is laxness in what we send. That a number is
accepted at all reaches a consumer in no sentence either: only the type comment at
`defs/commands.ts:239`, and one CHANGELOG line that stops being visible when
0.7.0 is cut, while README's Building bullet reads as the whole rule for a text field. Whether 0.7.0 is cut, while README's Building bullet reads as the whole rule for a text field. Whether
this is a supported spelling or 0.4.0 tolerance decides whether that sentence lands in this is a supported spelling or 0.4.0 tolerance decides whether that sentence lands in
README.md or in MIGRATION.md — write it in the same change as the rule, so it is worded once. README.md or in MIGRATION.md — write it in the same change as the rule, so it is worded once.