Register the raw peer's teardown, and keep the changelog line to what changed
Mirror / push (push) Successful in 6s
Test / lint (pull_request) Successful in 21s
Test / test (18) (pull_request) Successful in 35s
Test / test (20) (pull_request) Successful in 30s
Test / test (22) (pull_request) Successful in 30s
Test / test (24) (pull_request) Successful in 31s
Test / test (26) (pull_request) Successful in 31s

This commit is contained in:
2026-09-22 21:49:25 +02:00
parent b54f5b02f3
commit 65ac3a3fd7
3 changed files with 38 additions and 32 deletions
+32 -31
View File
@@ -322,19 +322,16 @@ describe('bind', () => {
smpp.on('session', session => { session.on('sessionError', err => { errors.push(err); }); });
const responded = once<string>(resolve => {
const sock = net.connect({ port: smpp.port }, () => {
sock.write(pduBytes({ cmdName: 'outbind', params: { password: 'pass', system_id: 'smsc' }, seqNr: 1 }));
sock.write(Buffer.from('00000010000000150000000000000002', 'hex'));
});
const peer = rawPeer(t, smpp.port);
sock.on('data', data => {
sock.destroy();
resolve(data.toString('hex'));
});
});
peer.write({ cmdName: 'outbind', params: { password: 'pass', system_id: 'smsc' }, seqNr: 1 });
peer.write({ cmdName: 'enquire_link', seqNr: 2 });
assert.equal(await responded, '00000010800000150000000400000002');
const answered = await raceWithin(2000, peer.next());
assert.ok(answered, 'the peer was never answered');
assert.equal(answered.cmdStatus, 'ESME_RINVBNDSTS');
assert.equal(answered.seqNr, 2);
assert.deepEqual(errors, []);
});
@@ -1529,6 +1526,30 @@ describe('robustness', () => {
assert.ok(Date.now() - started < 5000, 'should have given up quickly');
});
test('leaves an alert_notification and an outbind unanswered, since SMPP names no response', async t => {
const peer = await smscPeer(t);
const { session } = await client({ port: peer.port });
const errors: Error[] = [];
assert.ok(session);
closeAfter(t, session);
session.on('sessionError', err => { errors.push(err); });
peer.writeRaw(pduBytes({
cmdName: 'alert_notification',
params: { esme_addr: '46709771337', source_addr: '46701113311' },
seqNr: 10,
}));
peer.writeRaw(pduBytes({ cmdName: 'outbind', params: { password: 'pass', system_id: 'smsc' }, seqNr: 11 }));
peer.writeRaw(pduBytes({ cmdName: 'enquire_link', seqNr: 12 }));
const answered = await raceWithin(2000, peer.next());
assert.ok(answered, 'the peer was never answered');
assert.equal(answered.cmdName, 'enquire_link_resp');
assert.equal(answered.seqNr, 12);
assert.deepEqual(errors, []);
});
test('stops a connection attempt on an aborted signal', async () => {
const controller = new AbortController();
@@ -1814,26 +1835,6 @@ describe('a PDU the codec cannot read', () => {
assert.ok((await raceWithin(2000, failed)) instanceof Error, 'one sessionError per refused PDU');
});
test('leaves an alert_notification and an outbind unanswered, since SMPP names no response', async t => {
const { peer, session } = await bound(t);
const errors: Error[] = [];
session.on('sessionError', err => { errors.push(err); });
peer.writeRaw(pduBytes({
cmdName: 'alert_notification',
params: { esme_addr: '46709771337', source_addr: '46701113311' },
seqNr: 10,
}));
peer.writeRaw(pduBytes({ cmdName: 'outbind', params: { password: 'pass', system_id: 'smsc' }, seqNr: 11 }));
peer.writeRaw(pduBytes({ cmdName: 'enquire_link', seqNr: 12 }));
const answered = await answerTo(peer);
assert.equal(answered.cmdName, 'enquire_link_resp');
assert.equal(answered.seqNr, 12);
assert.deepEqual(errors, []);
});
test('answers a deliver_sm with a truncated TLV stream with ESME_RINVTLVSTREAM', async t => {
const { peer, session } = await bound(t);
let reports = 0;