Refuse a connectTimeout Node's timers cannot hold, and pin the refusals the tests missed
Mirror / push (push) Successful in 5s
Test / lint (pull_request) Successful in 20s
Test / test (18) (pull_request) Successful in 26s
Test / test (20) (pull_request) Successful in 19s
Test / test (22) (pull_request) Successful in 20s
Test / test (24) (pull_request) Successful in 19s
Test / test (26) (pull_request) Successful in 20s

This commit is contained in:
2026-09-20 18:12:39 +02:00
parent 17447bbe3a
commit 84174b4a5b
6 changed files with 38 additions and 16 deletions
+1 -2
View File
@@ -94,8 +94,7 @@ function openSocket(options: ClientOptions): Promise<Result<{ sock: Socket }>> {
}
const settle = (result: Result<{ sock: Socket }>): void => {
if (timer) clearTimeout(timer);
clearTimeout(timer);
sock.removeListener('error', onError);
signal?.removeEventListener('abort', onAbort);
resolve(result);
+12 -4
View File
@@ -168,15 +168,23 @@ function limitsOf(options: CheckableOptions): [string, number, number][] {
];
}
/** Leaving it out is how the wait stays the OS's, so 0 would be a second spelling for that. */
/** Node's timers are 32-bit, and a delay above this one fires after 1 ms instead of never. */
const maxTimerDelay = 2_147_483_647;
function checkConnectTimeout(connectTimeout: number | undefined): VoidResult {
if (connectTimeout === undefined) return {};
if (Number.isInteger(connectTimeout) && connectTimeout >= 1) return {};
const got = String(connectTimeout);
return { err: new Error(`connectTimeout must be 1 or more, got ${got}; omit it to wait the OS out`) };
if (!Number.isInteger(connectTimeout) || connectTimeout < 1) {
return { err: new Error(`connectTimeout must be a whole number of milliseconds, 1 or more, got ${got}; omit it to wait the OS out`) };
}
if (connectTimeout > maxTimerDelay) {
return { err: new Error(`connectTimeout must be ${String(maxTimerDelay)} or less, got ${got}`) };
}
return {};
}
function checkLimits(limits: [string, number, number][]): VoidResult {