larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Read an undefined tagId as absent
Mirror / push (push) Has been cancelled
Details
Test / lint (pull_request) Successful in 31s
Details
Test / test (18) (pull_request) Successful in 30s
Details
Test / test (20) (pull_request) Successful in 30s
Details
Test / test (22) (pull_request) Successful in 30s
Details
Test / test (26) (pull_request) Successful in 31s
Details
Test / test (24) (pull_request) Successful in 36s
Details

Browse Source
This commit is contained in:
Lilleman auf Larv
2026-09-27 15:31:21 +02:00
parent cda8e9b112
commit 9379212c68
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/pdu.test.ts
+4 -2
View File
@@ -443,9 +443,9 @@ describe('TLVs', () => {
const refusals = [
// @ts-expect-error nils is no tag name
{ built: objToPdu({ cmdName: 'deliver_sm', params, tlvs: { nils: { tagValue: 'blajfoo' } } }), reason: /decimal id/ },
{ built: objToPdu({ cmdName: 'deliver_sm', params, tlvs: { 5142: { tagId: 5143, tagValue: 'blajfoo' } } }), reason: /tagId 5143/ },
{ built: objToPdu({ cmdName: 'deliver_sm', params, tlvs: { 5142: { tagId: 5143, tagValue: 'blajfoo' } } }), reason: /its tagId is not 5142/ },
// @ts-expect-error the key names the tag
{ built: objToPdu({ cmdName: 'deliver_sm', params, tlvs: { message_state: { tagId: 5, tagValue: 2 } } }), reason: /tagId 5/ },
{ built: objToPdu({ cmdName: 'deliver_sm', params, tlvs: { message_state: { tagId: 5, tagValue: 2 } } }), reason: /its tagId is not 1063/ },
{ built: objToPdu({ cmdName: 'deliver_sm', params, tlvs: { 5142: { tagValue: 300 } } }), reason: /Buffer/ },
{ built: objToPdu({ cmdName: 'deliver_sm', params, tlvs: { 65536: { tagValue: 'blajfoo' } } }), reason: /out of range/ },
{ built: objToPdu({ cmdName: 'deliver_sm', params, tlvs: { '05142': { tagValue: 'blajfoo' } } }), reason: /decimal id/ },
@@ -553,6 +553,8 @@ describe('TLVs', () => {
}));
assert.deepEqual(decode(encode({ cmdName: 'deliver_sm', params, tlvs: parsed.tlvs })).tlvs, parsed.tlvs);
// @ts-expect-error the key names the tag, and an undefined tagId names none
assert.equal(objToPdu({ cmdName: 'deliver_sm', params, tlvs: { message_state: { tagId: undefined, tagValue: 2 } } }).err, undefined);
});
test('types each known TLV by its tag, and an unknown one as octets', () => {