From 9c4939f5cf775ede247e38c5cb4459565624f37b Mon Sep 17 00:00:00 2001 From: Lilleman auf Larv Date: Sat, 5 Sep 2026 18:48:57 +0200 Subject: [PATCH] Fix every defect a phase finds before the next phase runs --- interop-tests/AGENTS.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/interop-tests/AGENTS.md b/interop-tests/AGENTS.md index ad6f279..ea0fe47 100644 --- a/interop-tests/AGENTS.md +++ b/interop-tests/AGENTS.md @@ -73,3 +73,18 @@ Behaviour of the peer worth knowing that is not our defect. ``` Then set the phase's row in PLAN.md's Status table to `done` or `blocked`, linking the file. + +## Fixing what a phase found + +Every defect a phase records is fixed before the next phase runs — a fix can change behaviour in +ways the next experiment must see. One fix per defect class, as its own change: + +1. A worktree on a branch off `origin/typescript` (never `origin/master`, the 0.4.0 code), named + for the defect. +2. Regression tests in `test/` first, naming the behaviour with the reproducer from the findings; + then the implementation; then the decision record in the root `AGENTS.md` where the fix settles + a question of the wire or the session's life. +3. `/larv-review` on the branch, with the pull request based on `typescript`. When it marks the PR + ready, squash-merge it. +4. Back in the experiments worktree: fast-forward `typescript`, rerun the experiment that found the + defect, delete the workaround its test carried, and note the fix in the findings file.