larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Cover a multi-segment Latin-1 message against a real peer, and correct the flash row it left stale

Browse Source
This commit is contained in:
Lilleman auf Larv
2026-09-09 17:26:40 +02:00
parent 7d6039796d
commit cced03767e
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
interop-tests/findings/02-smppsim.md
+4 -4
View File
@@ -57,12 +57,12 @@ tests passing, `malformed: 0`, `expert errors: 0` in both.
| C12 (`smppsim-queuefull`) | pass | `smppsim-queuefull - C12 …`; `ESME_RMSGQFUL` returned, session stays bound, later send succeeds once the one-slot queue drains | | C12 (`smppsim-queuefull`) | pass | `smppsim-queuefull - C12 …`; `ESME_RMSGQFUL` returned, session stays bound, later send succeeds once the one-slot queue drains |
| C13 (`maxOutstanding: 1`, 10 parallel) | pass | `smppsim - C13 …`; 10 distinct, strictly-increasing ids, none lost | | C13 (`maxOutstanding: 1`, 10 parallel) | pass | `smppsim - C13 …`; 10 distinct, strictly-increasing ids, none lost |
| C15 (bind version) | pass (peer never declares, see below) | `smppsim - C15 …`, both 0x34 and 0x50 | | C15 (bind version) | pass (peer never declares, see below) | `smppsim - C15 …`, both 0x34 and 0x50 |
| C17 (encodings over loopback) | pass | `smppsim - C17 …`, 5 sub-tests: Latin-1, UCS-2, flash (0x10), raw 0xF0 (not flash), raw UDH+8-bit-binary | | C17 (encodings over loopback) | pass | `smppsim - C17 …`, 5 sub-tests: Latin-1, UCS-2, flash (0x10), raw 0xF0 (flash), raw UDH+8-bit-binary |
| C18 (`smppsim-outbind`) | pass (record, not judge) | `smppsim-outbind - C18 …`; see below for the wire facts | | C18 (`smppsim-outbind`) | pass (record, not judge) | `smppsim-outbind - C18 …`; see below for the wire facts |
C17's `raw 0xF0 (not flash)` recorded a `@larvit/smpp` defect, fixed in C17's 0xF0 sub-test originally read `not flash`, recording a `@larvit/smpp` defect: 0xF0 is GSM
[#95](https://github.com/larvit/larvitsmpp/pull/95): 0xF0 is GSM 03.38 message class 0, so it reads 03.38 message class 0, immediate display. Fixed in
as flash now. [#95](https://github.com/larvit/larvitsmpp/pull/95), and the assertion inverted in `ff6ba9f`.
## Defects in @larvit/smpp ## Defects in @larvit/smpp
interop-tests/smppsim.test.ts
+8
View File
@@ -177,6 +177,14 @@ describe('smppsim - C3+C7 long MT, receipts and loopback reassembly', () => {
label: '2-segment UCS2 with 一 and an emoji', label: '2-segment UCS2 with 一 and an emoji',
message: `一😀${'x'.repeat(70)}`, message: `一😀${'x'.repeat(70)}`,
}, },
// Names its encoding because detect() never chooses LATIN1 - latin1.match() is false so that
// auto-selection skips it - and unnamed, this text would go out as UCS2.
{
encoding: 'LATIN1',
expectedSegments: 2,
label: '2-segment Latin-1',
message: 'é'.repeat(200),
},
]; ];
for (const testCase of cases) { for (const testCase of cases) {