From e42aa4f1e717e9d28d1e61b3c84d07b9c2ac8295 Mon Sep 17 00:00:00 2001 From: lilleman Date: Sat, 13 Jun 2015 14:43:48 +0200 Subject: [PATCH] Minor simplification of code --- lib/session.js | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/session.js b/lib/session.js index 11f47a1..02b526b 100644 --- a/lib/session.js +++ b/lib/session.js @@ -310,25 +310,22 @@ function sendReturn(pdu, status, params, closeAfterSend, callback) { closeAfterSend = undefined; } + if (typeof callback !== 'function') { + callback = function() {}; + } + utils.pduReturn(pdu, status, params, function(err, retPdu) { if (err) { log.error('larvitsmpp: lib/session.js: sendReturn() - Could not create return PDU: ' + err.message); that.closeSocket(); - if (typeof callback === 'function') { - callback(err); - } - + callback(err); return; } log.silly('larvitsmpp: lib/session.js: sendReturn() - Sending return PDU: ' + retPdu.toString('hex')); - that.sockWrite(retPdu, closeAfterSend); - - if (typeof callback === 'function') { - callback(null, retPdu); - } + callback(null, retPdu); }); }