larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Have the typed-TLV item prove the changelog's advice compiles
Mirror / push (push) Successful in 6s
Details
Test / lint (pull_request) Successful in 21s
Details
Test / test (18) (pull_request) Successful in 30s
Details
Test / test (20) (pull_request) Successful in 31s
Details
Test / test (22) (pull_request) Successful in 35s
Details
Test / test (24) (pull_request) Successful in 34s
Details
Test / test (26) (pull_request) Successful in 29s
Details

Browse Source
This commit is contained in:
Lilleman auf Larv
2026-09-24 00:28:47 +02:00
parent 11ff349333
commit e83ed1451c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
todo.md
+2 -1
View File
@@ -201,7 +201,8 @@ and is also what the panel ranked hardest — two methods, one answer.
`tagValue` is `TlvValue`, so `{ callback_num: { tagValue: buf } }` compiles and is refused `tagValue` is `TlvValue`, so `{ callback_num: { tagValue: buf } }` compiles and is refused
only at runtime, and reading `receipted_message_id` has to narrow out arrays it can never only at runtime, and reading `receipted_message_id` has to narrow out arrays it can never
hold. Derive the types from the specs' own wire types and `multiple` flag. It has to land in hold. Derive the types from the specs' own wire types and `multiple` flag. It has to land in
the same minor as the arrays, or narrowing the types is a second break. From the the same minor as the arrays, or narrowing the types is a second break. A test compiles the
CHANGELOG's `tagValue[0]` advice, which the union does not type-check today. From the
product-owner review of #25. product-owner review of #25.
- [ ] **Settle what a repeated tag not marked `multiple` reads as, and pin it in a test.** A vendor - [ ] **Settle what a repeated tag not marked `multiple` reads as, and pin it in a test.** A vendor