From f2ee8aa01632cad3a769d6fee238813c24670345 Mon Sep 17 00:00:00 2001 From: Lilleman auf Larv Date: Thu, 24 Sep 2026 00:24:49 +0200 Subject: [PATCH] Drop a false claim about the server's answers, and file what the panel found --- src/send-sms.ts | 3 +-- todo.md | 12 ++++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/send-sms.ts b/src/send-sms.ts index 0224c33..2e70932 100644 --- a/src/send-sms.ts +++ b/src/send-sms.ts @@ -314,8 +314,7 @@ export async function submitSms(deps: SendSmsDeps, sms: SendSmsInput): Promise deps.send({ cmdName: 'submit_sm', params: submitSmParams(sms, segment, { diff --git a/todo.md b/todo.md index 044ed08..b1a4781 100644 --- a/todo.md +++ b/todo.md @@ -372,6 +372,18 @@ and is also what the panel ranked hardest — two methods, one answer. ### Doc claims this review falsified +- [ ] **Make `LinkGate.isUp()`'s doc true or its state match it.** It says a link attached but not + yet bound cannot carry a request, while `up` starts `true`, so the first link and a server + session are up before any bind. From the comprehension panel of #25. + +- [ ] **Move `checkSessionOptions()`'s doc comment to what it describes.** It explains why a count + below 1 is refused, which is `checkLimits`' job, and says nothing of the function it heads. + From the comprehension panel of #25. + +- [ ] **Log why `DlrMerger.expect()` registered no merge.** Ids with no common `-` + numbering return silently, the likeliest cause of a `messageDlr` that never fires and the one + that leaves no trace. From the comprehension panel of #25. + - [ ] **Make "every README example is executed by the suite" true, or stop claiming it.** Goal 10 and the Done table both promise it; `test/readme.test.ts` transcribes the examples by hand and has drifted — 15 fenced `javascript` blocks in the README against 10 tests, and the test named "the