larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests 1 Actions Activity

WIP: Read and write every copy of a TLV SMPP lets repeat, and drop the dormant tlvMap #26

Closed
lilleman wants to merge 3 commits from tlv-multiple into main
pull from: tlv-multiple
merge into: larvit:main
Conversation 0 Commits 3 Files Changed 12
+10 -2
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 59ff21a3d2 - Show all commits
CHANGELOG.md
+1 -2
View File
@@ -40,8 +40,7 @@
- `callback_num`, `callback_num_atag`, `callback_num_pres_ind`, `broadcast_area_identifier` and - `callback_num`, `callback_num_atag`, `callback_num_pres_ind`, `broadcast_area_identifier` and
`broadcast_error_status` read as a list of every copy the peer sent, where only the last was kept, `broadcast_error_status` read as a list of every copy the peer sent, where only the last was kept,
and are written from a list. A single value or an empty list for one of them, or a list for any and are written from a list. A single value or an empty list for one of them, or a list for any
other tag, is other tag, is refused.
refused.
- `tlvMap` is gone from the `broadcast_sm_resp` command definition. Nothing read it. - `tlvMap` is gone from the `broadcast_sm_resp` command definition. Nothing read it.
## 0.5.0 ## 0.5.0
todo.md
+9
View File
@@ -378,6 +378,15 @@ and is also what the panel ranked hardest — two methods, one answer.
is honest that the run was 2026-09-08. Nothing runs the peers on a schedule or before a tag, so is honest that the run was 2026-09-08. Nothing runs the peers on a schedule or before a tag, so
the claim rots silently. Goals 1 and 9. the claim rots silently. Goals 1 and 9.
- [ ] **Correct the four doc claims the 2026-09-24 panel falsified.** `send-sms.ts:317` says this
library's own server waits for every segment before answering, where it answers each on
arrival; AGENTS.md counts nine goals where README lists ten; README's goals point at "the hard
rules below" and "the defect table below", both of which live in AGENTS.md.
- [ ] **Route the three `new Error(String(thrown))` through `errorFrom()`.** `client.ts:100` and
`reconnect-loop.ts:84,140` convert a thrown value with `String()`, which throws for an object
whose `toString` throws — the case `errorFrom()` exists for, and hard rule 1.
## Worth doing, not blocking ## Worth doing, not blocking
- [ ] **Decide whether `alert_notification` reaches the application as more than `incomingPduObj`.** - [ ] **Decide whether `alert_notification` reaches the application as more than `incomingPduObj`.**