larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Type each known TLV's value by its tag, on read and on write #30

Merged
lilleman merged 14 commits from tlv-types into main 2026-09-27 16:48:06 +02:00
Conversation 0 Commits 14 Files Changed 23
+3 -1
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c4b0437323 - Show all commits
src/defs/tlvs.ts
+3 -1
View File
@@ -135,7 +135,9 @@ function tagIdOf(name: string, input: object): Result<{ tagId: number }> {
return { err: new Error(`TLV "${name}": key it by its name, or a tag the table does not define by its decimal id, instead of giving a tagId`) }; return { err: new Error(`TLV "${name}": key it by its name, or a tag the table does not define by its decimal id, instead of giving a tagId`) };
} }
if (Object.hasOwn(tlvs, name)) return { tagId: tlvs[name]?.id ?? 0 }; const named = Object.hasOwn(tlvs, name) ? tlvs[name] : undefined;
if (named) return { tagId: named.id };
if (!/^(0|[1-9]\d*)$/.test(name)) { if (!/^(0|[1-9]\d*)$/.test(name)) {
return { err: new Error(`TLV "${name}": unknown tag name; key a tag the table does not define by its decimal id`) }; return { err: new Error(`TLV "${name}": unknown tag name; key a tag the table does not define by its decimal id`) };