larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests 1 Actions Activity

Name which body settles data_coding in resolveBody #40

Merged
lilleman merged 3 commits from resolve-body-source into main 2026-09-28 02:29:43 +02:00
Conversation 0 Commits 3 Files Changed 2
+1 -2
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit af29846544 - Show all commits
todo.md
+1 -2
View File
@@ -299,8 +299,7 @@ next work ([decision](docs/decisions.md#internals-and-tests)).
with no link from the code; one counted roughly fifty index redirects. The three left to inline with no link from the code; one counted roughly fifty index redirects. The three left to inline
as one line each: that `segmentUnits`' three numbers are in two units (septets and octets), as one line each: that `segmentUnits`' three numbers are in two units (septets and octets),
that a receipt's body is read as octets whatever its `data_coding` says, and the `<base>-<n>` that a receipt's body is read as octets whatever its `data_coding` says, and the `<base>-<n>`
id notation. The reasoning stays in the log; the id notation. The reasoning stays in the log; the definition belongs at the code.
definition belongs at the code.
- [ ] **Document the two delivery-receipt merge bounds.** `maxDlrMerges` (1000) and - [ ] **Document the two delivery-receipt merge bounds.** `maxDlrMerges` (1000) and
`dlrMergeTimeout` (24 h) are hardcoded, are not options, and appear in no README and no test — `dlrMergeTimeout` (24 h) are hardcoded, are not options, and appear in no README and no test —