From 27e50143227b652b7bc68affd4bb5a4c8e79668e Mon Sep 17 00:00:00 2001 From: Lilleman auf Larv Date: Sat, 21 Nov 2026 11:57:43 +0100 Subject: [PATCH] Test the median pick by tokens, the name of a silent claude and the environment git runs in --- bin/task_bench/test_digest.py | 4 ++-- bin/task_bench/test_gather.py | 12 ++++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/bin/task_bench/test_digest.py b/bin/task_bench/test_digest.py index 5953bef1..1ac629e6 100644 --- a/bin/task_bench/test_digest.py +++ b/bin/task_bench/test_digest.py @@ -138,8 +138,8 @@ class DigestTest(unittest.TestCase): self.assertIn("### bug-2-base-1, the passing run with the median tokens, 10", held.splitlines()) def test_the_median_is_by_tokens_whatever_the_order_the_runs_ran_in(self): - runs = [Run("bug-2-base-1", True, 30, b""), Run("bug-2-head-1", True, 10, b""), Run("bug-2-base-2", True, 20, b"")] - self.assertEqual(digest([], [Bug("2: a.go:1:1 X", "a.go", "boom", runs)], lambda path: True).splitlines()[-2:], ["### bug-2-base-2, the passing run with the median tokens, 20", ""]) + runs = [Run("bug-2-base-1", True, 20, b""), Run("bug-2-head-1", True, 10, b""), Run("bug-2-base-2", True, 30, b"")] + self.assertEqual(digest([], [Bug("2: a.go:1:1 X", "a.go", "boom", runs)], lambda path: True).splitlines()[-2:], ["### bug-2-base-1, the passing run with the median tokens, 20", ""]) def test_a_bug_no_run_fixed_shows_the_failing_trace_alone_and_says_where_no_file_misled(self): held = digest([], [Bug("3: a.go:1:1 X", "a.go", "boom\nat line 2", [Run("bug-3-base-1", False, 10, reading("a.go")), Run("bug-3-head-1", False, 10, reading("a.go"))])], lambda path: True) diff --git a/bin/task_bench/test_gather.py b/bin/task_bench/test_gather.py index 0aa8e96e..6eac82c4 100644 --- a/bin/task_bench/test_gather.py +++ b/bin/task_bench/test_gather.py @@ -98,6 +98,18 @@ class GatherTest(unittest.TestCase): self.models.write_text("{") self.assertIsInstance(gather(self.env, self.home, self.claude), Failure) + def test_a_claude_that_fails_without_a_word_is_named(self): + self.code = 1 + found = gather(self.env, self.home, lambda args, cwd, prompt: subprocess.CompletedProcess(args, 1, "", "")) + self.assertEqual(found.reason.splitlines()[0] if isinstance(found, Failure) else found, "the gathering claude exited 1") + + def test_git_runs_in_the_environment_given(self): + env = {**self.env, "GIT_DIR": str(self.home / "none")} + self.assertIsInstance(gather(env, self.home, self.claude), Failure) + with contextlib.redirect_stderr(io.StringIO()): + self.assertEqual(main.main(["gather"], env, claude=self.claude), 1) + self.assertEqual(self.calls, []) + def test_refuses_outside_a_checkout(self): with contextlib.chdir(self.home): self.assertIsInstance(gather(self.env, self.home, self.claude), Failure)