diff --git a/agents/stability-reviewer.md b/agents/stability-reviewer.md index 6fe9ce83..9738200c 100644 --- a/agents/stability-reviewer.md +++ b/agents/stability-reviewer.md @@ -72,7 +72,7 @@ Catch behavior that is unclear or under-specified — "building in ambiguousness - Are there potential off-by-one errors? - Zero and absent are different values: `empty('0')`, `if ($amount)`, `$x ?: $default`, JS `||` conflate them one way; null coerced to `'0'` conflates them the other (a past prod bug: phantom 0-amount reversals). Both directions are findings. - Multibyte text (åäö): truncation, length checks, and comparisons must be mb-safe; encoding consistent end-to-end. -- Where the change splits text on a separator or strips a suffix, look in the fixtures and a sample of the source data for a field that holds the separator (a full address split on `,` whose leaf holds one), and report each row the parse then misplaces or drops, silently or with only a log line. +- Where the change splits text on a separator or strips a suffix, look in the fixtures and a sample of the source data for a value where the separator or suffix also occurs as data, such as an address split on `,` whose last part holds a comma. Report a row the parse then misplaces or drops, silently or with only a log line. - Are payload and collection sizes bounded at the boundary? ### 6. Concurrency & State Management