Merge remote-tracking branch 'origin/main' into item-458
CI / tests (pull_request) Has been cancelled

This commit is contained in:
Lilleman
2026-11-19 23:39:12 +01:00
6 changed files with 127 additions and 23 deletions
+60
View File
@@ -4146,3 +4146,63 @@ Inherited architect, decided by:
- Navigation, Shape: `bin/chunk_driver/claims.py:1` module docstring: the lock and the chunk flags sit in one module named for that job, and `starting` yields a `Failure` instead of raising
- Locality, Navigation: `bin/forge/reviews.py:23` `review_decision`: all review-state reading in `forge/`, each field shape-checked; three similar names cost a docstring read each
- Locality: `bin/chunk_driver/project/model_choice.py:28` `overridden`: the model override is one function, where it was spelled out twice
## 2026-11-19T22:33:15Z, PR #646 at a357cc7b
| Seat | Navigation | Locality | Shape | Self-sufficiency | Overall |
|---|---|---|---|---|---|
| Junior A | 7 | 5.5 | 6 | 6 | 6 |
| Mid A | 7 | 6 | 6.5 | 6 | 6.5 |
| Maintainability senior | 7 | 6 | 6 | 6 | 6.5 |
| Inherited architect | 7 | 6.5 | 6 | 6 | 6.5 |
| Mean | 7.00 | 6.00 | 6.13 | 6.00 | 6.38 |
Junior A, hardest first:
- Locality, Shape: `bin/do_epic/main.py:287` `parked_through`: the three-step park and resume order, the `told` and `finished` flags and a raw string compare held at once; the docstring gives the order but not why the flags exist
- Locality, Self-sufficiency: `bin/agent_cycle/routing.py:115` `unfinished_route`: floor rung, escalation mark, cap and the count of unfinished verdicts meet in a dozen lines, and the reasons sit in the decision log
- Shape: `bin/agent_cycle/judge.py:237` `quotes_checked`: six checks each quietly turn one verdict type into another, and the call site doesn't show the result type
- Locality: `bin/do_epic/scheduler.py:144` `start_chunks`: four overlapping sets, a five-branch chain, a counter and nested locks shared with loop-claude
- Shape: `bin/agent_cycle/run.py:150` `rule`: runs the judge, stamps, annotates, steps up and orders the archive writes, beside four near-identical archive helpers
- Locality: `bin/agent_cycle/stuck_workers.py:52` `Watch.check`: mutates `self.cpu` and `self.judged` out of sight, and one condition mixes `and` and `or` without parentheses
- Shape: `bin/do_epic/gates.py:42` `gate`: a long ordered chain where a missing value means something different on each line
- Locality: `bin/loop_claude/loop/reload.py:36` `decode_handed`: pops legacy fields from a handover the old process wrote before it replaced itself; nothing enforces the coupling
- Self-sufficiency: `skills/larv-review/SKILL.md:89` "Round cap": three sections must be open at once to tell whether a fix reruns a pass
- Self-sufficiency: `bin/agent_cycle/verdicts.py:41` the comment: points to `cycle.judge.re_ask_checked`, a module path that doesn't exist
Mid A, hardest first:
- Locality: `bin/do_epic/main.py:354` `resumed_news`: a `while True` poll that carries `said` and `shown` across turns, with a nested-quote f-string; no comment says what holds when the loop exits
- Locality, Self-sufficiency: `bin/do_epic/main.py:287` `parked_through`: three steps whose correctness depends on each other; the reason for the order sits in the decision log
- Locality: `bin/do_epic/main.py:241` `chunk_run`: `news`, `told`, `finished` and the reopened-epic exit held across iterations
- Locality: `bin/do_epic/scheduler.py:144` `start_chunks`: a five-branch chain over four sets, counted under nested locks
- Shape: `bin/project_config/settings.py:187` `load`: about twenty comprehension clauses build one `faults` list, so finding what one setting requires means scanning all of them
- Locality: `bin/agent_cycle/routing.py:115` `unfinished_route`: five rung concepts at once, readable only with `bin/model_routing/ladder.py` open beside it
- Shape: `bin/chunk_pr/main.py:447` `levelled_and_finished`: checks whether a scoring run is owed, which its name doesn't suggest
- Locality: `bin/plan/ranking.py:239` `score`: the formula forks on the old and the new table shape, both live
- Self-sufficiency: `bin/larv_review/main.py:1` the module docstring: about 165 lines that restate what `COMMANDS` and the modules it calls enforce
Maintainability senior, hardest first:
- Locality, Shape: `bin/do_epic/main.py:287` `parked_through`: the told, finished and news interplay, the human-merge cases and the three-step order held at once, and no code enforces the order
- Locality, Shape: `bin/do_epic/main.py:354` `resumed_news`: a loop that mutates five locals and builds its message in a nested f-string, with no stated invariant
- Locality: `bin/agent_cycle/routing.py:115` `unfinished_route`: five rungs, an unfinished count, the escalation mark and the cap held together; each threshold's reason sits in the decision log
- Shape, Self-sufficiency: `bin/project_config/settings.py:187` `load`: about 20 comprehension expressions each encode a rule linking two settings; named predicates would make each rule findable
- Shape, Locality: `bin/chunk_pr/main.py:314` `merged`: the merge-queue loop with its flags, where a variable carries either a string or a Failure and each read must work out which
- Locality: `bin/plan/ranking.py:239` `score`: the old and new table shapes run through the whole module, so each change is checked against both
- Locality: `bin/larv_review/plan.py:21` `Emptied`: a `str` subclass whose type carries meaning, lost without warning by any code that rebuilds the string
- Locality: `bin/agent_cycle/judge.py:76` `TASK_HEADING`: an archive key, so rewording it breaks replays in another module, and only a comment warns
- Self-sufficiency: `skills/larv-review/SKILL.md:89` "Round cap": the review rules exist three times, here, in the help at `bin/larv_review/main.py:1` and in rule-hook's code
Inherited architect, would restructure first:
- Locality, Shape: `bin/rule_hook/round_cap.py:10` `round_cap_breaches`: the round cap lives in four places across three packages, and none owns the whole invariant; rounds are counted from commit titles, never from launches
- Navigation, Shape: `README.md:225` "Packages under bin/": 84 entries listed alphabetically in dense prose, with no grouping by layer
- Shape: `bin/loop_claude/loop/reload.py:18` `LoopRun`: loop-claude's core run state defined in a module named for self-reloading
- Shape: `bin/agent_cycle/judge.py:116` `Rejected`: says loop-claude rejected the reply, in a module do-epic shares
- Self-sufficiency: `bin/agent_cycle/run.py:103` the comment: cites `close.py`, which doesn't exist
- Self-sufficiency: `bin/agent_cycle/verdicts.py:41` the comment: cites `cycle.judge.re_ask_checked`, a stale module path
- Navigation: `bin/chunk_driver/drivers.py:1` the module: "entry point" and "driver" name one concept, and `Run`, `ChunkRun` and `LoopRun` are one concept in three types
- Navigation: `bin/do_epic/status.py:1` the module: in no map, and the package's `__init__.py` is empty like 40 others
- Locality: `reviewer-merge-trials/driver.py:4` the imports: a frozen trial imports live code under `bin/`, so a refactor there breaks a record
- Self-sufficiency: `bin/agent_cycle/routing.py:92` the comment: one of 109 citations of the decision log that carry a unit's reason