Answer prose round 1: 0 🔴, 3 🟡; one name for unreleased changes, a plainer standing docstring, a changelog entry true without a named release

This commit is contained in:
2026-10-18 11:04:52 +02:00
parent 5eafe960e1
commit 3eb3217a49
5 changed files with 17 additions and 13 deletions
+1 -1
View File
@@ -2,7 +2,7 @@
## Unreleased
- `chunk-preflight` names the release it finds finished and ready to cut, or to be planned first, so you no longer have to work out which release that is.
- `chunk-preflight` names the release it finds finished and ready to cut, or to be planned first, wherever todo.md has named that release since the last cut.
- Each reviewer under `agents/` now writes its full report to a file that larv-review names in the reviewer's prompt, in a folder per chunk under `~/.local/state/larv-review/`. It returns only its verdict and one line per finding, so a review takes less of the worker's context. The worker reads a finding's full entry before it fixes or answers a 🔴 or 🟡. Each reviewer now holds Write. `rule-hook` refuses a reviewer's Edit and MultiEdit, and any Write outside `~/.local/state/larv-review/`; no override waives this rule. Each chunk's folder stays after the merge, so `stability-replay` can replay a round that reads an earlier round's report. It replays on a copy of the folder.
- `loop-claude` asks an interrupt's question on its own terminal and resumes the worker headless with your one-line answer, so the loop no longer waits for you to leave a claude session. Type `/talk` instead to open the worker's session in claude, as every interrupt did before, to read the diff or discuss first. A release ready to cut opens that session at once. Pressing Enter on an empty answer stops the loop, exit 2. Keys typed before the question shows are dropped, and a pasted answer keeps only its first line; type `/talk` for a longer one. The judge counts that answer as yours, like one typed in claude: the chunk stays open until the answer is recorded, where a later chunk could need it.
- `todo.md` may mark a renamed release in a `## Renamed` section, one line per rename, such as `- 0.2.1 renamed to 0.3.0`. `chunk-preflight` and `loop-claude` then skip that release when they pick the next one, and larv-review's scoring-run trigger calls no run for it. Without the mark, a release named since the last tag whose items all moved to other releases reads as finished: `chunk-preflight` says it is ready to cut and the loop stops for you, and the trigger calls a scoring run. `rank_todo.py` fails on a `## Renamed` line of another shape, and on an item filed under a release it marks. Before you move a machine to this release, add the line to the `todo.md` of every project that renamed a release since its last tag, or its loop stops for that release's cut.
+10 -7
View File
@@ -1,4 +1,4 @@
"""The next chunk's pick: the item it takes first, weighed against the last release cut, and what the default branch holds for it."""
"""The next chunk's pick: the item the chunk takes first, weighed against the last release cut, and what the default branch holds for the pick."""
import dataclasses
import re
@@ -22,7 +22,7 @@ class LastCut:
@dataclasses.dataclass(frozen=True)
class Next:
"""The plan's earliest release is the next release: the earliest after the last cut that todo.md has named since it, or there is no cut to weigh it against."""
"""The plan's earliest release is the next release: the earliest after the last cut that todo.md has named since that cut. Without a cut, the plan's earliest release is the next."""
# None where the plan holds no item.
release: tuple[int, int, int] | None
# The item the next chunk takes first, next_item's pick; None where every item waits or the plan holds none.
@@ -37,14 +37,14 @@ class Cut:
@dataclasses.dataclass(frozen=True)
class Finished:
"""The next release holds no item, and work has landed since the cut."""
"""The next release holds no item, and changes are unreleased."""
# The next release, None where todo.md has named none since the cut.
release: tuple[int, int, int] | None
@dataclasses.dataclass(frozen=True)
class Unplanned:
"""The next release holds no item, and no work has landed since the cut."""
"""The next release holds no item, and no change is unreleased."""
# The next release, None where todo.md has named none since the cut.
release: tuple[int, int, int] | None
@@ -95,7 +95,10 @@ def chunk_item(found: list[Item], cut: LastCut) -> Pick:
def standing(tag: str | None | Failure, changes: int | Failure, earliest: tuple[int, int, int] | None, first: Item | None, named: set[tuple[int, int, int]] | Failure) -> Pick:
"""How earliest, the plan's earliest release, None where the plan holds no item, stands to tag, the newest v* tag. first is the earliest release's first item that does not wait, changes counts the changes since the tag, and named holds each release todo.md named since it."""
"""How the plan stands to tag, the newest v* tag.
earliest is the plan's earliest release, None where the plan holds no item, and first is next_item's pick. changes counts the unreleased changes. named holds each release todo.md named since the tag.
"""
tagged = re.fullmatch(r"v([0-9]+)\.([0-9]+)\.([0-9]+)", tag) if isinstance(tag, str) else None
if tagged is None:
return Next(earliest, first)
@@ -113,7 +116,7 @@ def standing(tag: str | None | Failure, changes: int | Failure, earliest: tuple[
def unreleased_changes(cut: LastCut) -> int | Failure:
"""How many changes are unreleased, as `~/.claude/CLAUDE.md` → "Working loop" counts them: the entries under ## Unreleased, or the commits since the tag where CHANGELOG.md has no such section."""
"""How many changes are unreleased, as `~/.claude/CLAUDE.md` → "Working loop" counts them: the entries under ## Unreleased, or the commits since the tag where CHANGELOG.md has no such section or cannot be read."""
entries = unreleased_entries(cut.changelog) if isinstance(cut.changelog, str) else None
return cut.commits if entries is None else entries
@@ -125,7 +128,7 @@ def unreleased_entries(changelog: str) -> int | None:
def named_releases(todos: list[str] | Failure) -> set[tuple[int, int, int]] | Failure:
"""Each release the todo.md texts, oldest first, file items under. A release leaves the set when a text marks it renamed, and returns when a later text files items under it again. A text whose items or marks do not parse names none, except the newest: its marks failing to parse fails the whole, since the release they should have excluded would read as finished. larv_review/plan.py's `emptied` skips the releases marked renamed too."""
"""Each release the todo.md texts, oldest first, file items under. A release leaves the set when a text marks it renamed, and returns when a later text files items under it again. A text whose items or marks do not parse names none, except the newest: where its marks do not parse, it returns that Failure, since the release they should have excluded would read as finished."""
if isinstance(todos, Failure):
return todos
if todos and isinstance(newest := renames(todos[-1]), Failure):
+2 -2
View File
@@ -29,8 +29,8 @@ def planned(todo: str | Failure, cut: LastCut, default: str) -> Plan | NoItem:
if isinstance(pick, Finished | Unplanned):
upcoming = f"release {version(pick.release)}, the next after the last cut, {cut.tag}" if pick.release else f"the next release after the last cut, {cut.tag}"
if isinstance(pick, Finished):
return NoItem(f"{where} holds no item for {upcoming}, and work has landed since, so that release is finished and ready to cut, and the working loop stops here. If todo.md renamed that release instead, add `- <old release> renamed to <new release>` to todo.md's `## Renamed` section.")
return NoItem(f"{where} holds no item for {upcoming}, and no work has landed since, so that release is to be planned first.")
return NoItem(f"{where} holds no item for {upcoming}, and changes are unreleased, so that release is finished and ready to cut. The working loop stops here. If todo.md renamed that release instead, add `- <old release> renamed to <new release>` to todo.md's `## Renamed` section.")
return NoItem(f"{where} holds no item for {upcoming}, and no change is unreleased, so that release is to be planned first.")
first = pick.item
if first is None:
return NoItem(f"every item of release {version(pick.release)} in {where} waits." if pick.release is not None else f"{where}'s items table holds no item.")
+3 -2
View File
@@ -15,8 +15,9 @@ holds it, the plan loop-claude routes on. It prints:
blocks it. Where the newest tag names a version x.y.z, the next release is the earliest after
x.y.z that todo.md has named at that tag or since, less a release its ## Renamed section marks
renamed. Otherwise it is todo.md's earliest release.
Where the next release holds no item, it says so: finished and ready to cut where work landed
since the tag (the ## Unreleased entries, or else the commits), and else to be planned first.
Where the next release holds no item, it says so, naming it where todo.md named it since the tag:
finished and ready to cut where changes are unreleased (the ## Unreleased entries, or else the
commits since the tag), and else to be planned first.
Where todo.md's earliest release is x.y.z or earlier, it says todo.md files items under a release
already cut;
- the item's worktree: a sibling of the checkout named <checkout>-item-<ID>, on the branch
+1 -1
View File
@@ -383,7 +383,7 @@ Replaces item 62, which release 0.3.0's items split. PR #257's scoring run put L
Shape is the lowest dimension, so this item moves goal 1.1 by 9, per `docs/decisions.md` → `larv-review: a project lifting itself to the comprehension floor starts at the lowest dimension`.
PR #257's scoring run put Shape at 6.25, the lowest dimension. `bin/` holds about 30 entries: 6 launchers, 6 tool packages, 3 shared packages and 13 root modules. Two root modules are tools (`rank_todo.py`, `statusline.py`) and 11 are shared libraries, and nothing in the layout tells them apart; only README's import-root paragraph maps them. Candidate packages: git running and parsing, the todo table with `rank_todo.py`'s formula language and goal weighing, and the comprehension history with round titles. `rank_todo.py` keeps its path, which every project's rules name. The `.gitignore` allowlist and README follow the move.
PR #257's scoring run put Shape at 6.25, the lowest dimension. `bin/` holds about 30 entries: 6 launchers, 6 tool packages, 3 shared packages and 15 root modules. Two root modules are tools (`rank_todo.py`, `statusline.py`) and 13 are shared libraries, and nothing in the layout tells them apart; only README's import-root paragraph maps them. Candidate packages: git running and parsing, the todo table with `rank_todo.py`'s formula language and goal weighing, and the comprehension history with round titles. `rank_todo.py` keeps its path, which every project's rules name. The `.gitignore` allowlist and README follow the move.
### 156. Drop `rank_todo.py`'s ranking of an old-shape table once no project under `~/code` holds one.