diff --git a/todo.md b/todo.md index 86b021c3..a6b9105b 100644 --- a/todo.md +++ b/todo.md @@ -6,7 +6,7 @@ `Bar = 0.1` -`Next ID = 516` +`Next ID = 517` ## Items @@ -43,6 +43,7 @@ | 496 | 0.22.0 | 478, 491 | owner | **Rename the repo to the name item 478 picks, and rename what says Claude where it means any harness, such as `CLAUDE.md`.** | 3 | 2 | 3 | 6 | 6 | code health by 2 | 1.3 | | 494 | 0.22.0 | 477, 483 | owner | **Let a newcomer install, log in and run a first project from the README alone, with an example config, and test a fresh install in a container in the gate.** | 2 | 2 | 2 | 4 | 5 | 1.6 by 4 | 0.8 | | 446 | 0.23.0 | | question | **Kill the process a stuck check names where its verdict is `stuck`, once the human says the recorded verdicts match what they would have done.** | 2 | 2 | 3 | 5 | 3 | 1.5 by 3 | 1.0 | +| 516 | 0.23.0 | | | **Refuse a `.dockerignore` that leaves out a secret-named entry the `.gitignore` beside it ignores, where a Dockerfile copies the whole build context.** | 2 | 2 | 3 | 5 | 3 | 4 by 4 | 5.0 | | 462 | 0.23.0 | | | **Run under `mutate-changes` the tests that today fail in mutmut's copy of the tree, so a mutant of a line only they cover is killed.** | 2 | 1 | 2 | 3 | 3 | code health by 3 | 4.7 | | 77 | 0.23.0 | | | **Teach `bin/metric-bench` Go and TypeScript, rerun it once two projects' comprehension histories name places, and bring into review only a metric that tracks the panel.** | 4 | 2 | 1 | 5 | 6 | 1.1 by 7, 1.4 by 7 | 2.1 | | 196 | 0.23.0 | | decision | **Replay the architecture, principles, overrides and product-owner passes with `review-replay` on Opus 5.5 projects, record each run in the review-replay routing decision, and, where a run qualifies a rung, add back the code that lowers a pass to it.** | 2 | 2 | 3 | 5 | 2 | 1.4 by 3 | 1.2 | @@ -260,6 +261,17 @@ Touches: - `bin/loop_effects/child_shells.py`: `stop` (small) - `bin/loop_claude/loop/usage.py`: `HELP` (small) +### 516. Refuse a `.dockerignore` that leaves out a secret-named entry the `.gitignore` beside it ignores, where a Dockerfile copies the whole build context. + +An outside reviewer caught what our review missed: a repo's `.gitignore` ignored `auth.json`, Composer's credentials file, while its `.dockerignore` didn't, and its Dockerfiles run `COPY . .`. A developer's local `auth.json` could then reach the image. Today rule-hook checks ignore files only for sort order (`ignorefile-sorted`). + +Add a rule-hook check on Write and Edit of `.gitignore`, `.dockerignore` and `Dockerfile*`, and a gate check: +- where a Dockerfile in the repo copies the whole context (`COPY . ` or `ADD . `), +- each `.gitignore` entry whose name marks a secret (`.env`, `.env.*`, `auth.json`, `*.pem`, `*.key`, `id_*`, `credentials*`, `*secret*`) +- must also be in `.dockerignore`, or be excluded by a pattern there. + +Name the entry and the Dockerfile line. Source the secret-name list from a widely used one, such as GitHub's gitignore templates or gitleaks' default rules, and cite it in the decision that records the list. + ### 462. Run under `mutate-changes` the tests that today fail in mutmut's copy of the tree, so a mutant of a line only they cover is killed. Found while shipping item 461: `mutate-changes` printed `23 mutants on changed lines, 18 not killed. Left out the tests that fail without a mutant, in do_epic/test_main.py, larv_review/test_larv_review.py, larv_review/test_scoring_setup.py, plan/test_ranking.py, repo_checks/…, review_rules/test_review_passes.py, review_rules/test_reviewer_context.py, rule_hook/test_rule_hook.py, test_settings_filter.py`. All 18 survivors were in `bin/larv_review/scoring_setup.py`: `prepare_scoring`, whose tests are among those left out, so the chunk checked four of them by hand and left 14 unchecked. Find why each left-out test fails in mutmut's copy, such as a path to `skills/` or a git checkout it expects, and make it pass there, or report under the count which changed lines no remaining test covers.