From 53e87d1051211a38e5323c1c18da4bfa5ca9ec2c Mon Sep 17 00:00:00 2001 From: Lilleman auf Larv Date: Fri, 16 Oct 2026 22:54:18 +0200 Subject: [PATCH] =?UTF-8?q?Answer=20security=20round=205:=200=20?= =?UTF-8?q?=F0=9F=94=B4,=201=20=F0=9F=9F=A1;=20load=20no=20settings=20sour?= =?UTF-8?q?ce=20at=20all,=20and=20answer=20stability=20round=205's=20nit?= =?UTF-8?q?=20with=20a=20test=20that=20no=20config=20or=20hook=20program?= =?UTF-8?q?=20runs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- workflow-bench/bench.py | 7 ++++--- workflow-bench/test_review_git.py | 19 +++++++++++++++++++ 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/workflow-bench/bench.py b/workflow-bench/bench.py index 5b840436..c8486335 100755 --- a/workflow-bench/bench.py +++ b/workflow-bench/bench.py @@ -50,9 +50,10 @@ def permission_flags(clone, version_dir, report): *(f"{tool}({tree})" for tool in ("Read", "Grep", "Glob") for tree in trees), ] denied = ["Bash(git *)", f"Edit(/{clone}/.git/**)", f"Edit(/{clone}/.claude/**)"] - # No "user" or "project" source: ~/.claude/settings.json would add ~/code to the trees and run its hooks, - # and a case's committed .claude/settings.json could run its own; --strict-mcp-config ignores a committed .mcp.json. - return ["--setting-sources", "local", "--strict-mcp-config", "--permission-mode", "dontAsk", "--permission-prompts", "none", + # No settings source: ~/.claude/settings.json would add ~/code to the trees and run its hooks, and a case's + # committed .claude/settings.json or settings.local.json could run its own. --strict-mcp-config ignores a + # committed .mcp.json. + return ["--setting-sources", "", "--strict-mcp-config", "--permission-mode", "dontAsk", "--permission-prompts", "none", "--allowedTools", *allowed, "--disallowedTools", *denied] diff --git a/workflow-bench/test_review_git.py b/workflow-bench/test_review_git.py index 16216851..05950147 100644 --- a/workflow-bench/test_review_git.py +++ b/workflow-bench/test_review_git.py @@ -119,6 +119,25 @@ class Wrapper(unittest.TestCase): ran = self.wrapper("diff", "--output=.git/config", cwd=self.clone) self.assertEqual((ran.returncode != 0, (self.clone / ".git" / "config").read_bytes()), (True, config)) + def test_runs_no_program_that_a_config_or_hook_names(self): + marker = self.root / "ran" + program = self.root / "program.sh" + program.write_text(f"#!/bin/sh\ntouch {marker}\n") + program.chmod(0o755) + home = self.root / "home" + home.mkdir() + (home / ".gitconfig").write_text(f"[diff]\n\texternal = {program}\n") + (self.clone / ".git" / "hooks" / "pre-commit").write_text(f"#!/bin/sh\ntouch {marker}\n") + (self.clone / ".git" / "hooks" / "pre-commit").chmod(0o755) + with (self.clone / ".git" / "config").open("a") as config: + config.write(f"[core]\n\tfsmonitor = {program}\n") + (self.clone / "a.txt").write_text("two\n") + self.env["HOME"] = str(home) + self.wrapper("diff", cwd=self.clone) + self.wrapper("status", cwd=self.clone) + self.wrapper("commit", "-a", "-m", "x", cwd=self.clone) + self.assertFalse(marker.exists()) + def test_refuses_to_run_without_the_clone_named(self): (self.clone / "a.txt").write_text("two\n") ran = self.wrapper("diff", cwd=self.clone, clone_env=False)