Fix the places help, the second run's recording rule and the decision title that the comprehension seats found misleading

This commit is contained in:
2026-10-17 21:32:33 +02:00
parent 207cd7c3eb
commit 85cbd6b5a5
7 changed files with 13 additions and 7 deletions
+1 -1
View File
@@ -13,7 +13,7 @@ Decisions live in `docs/decisions.md`:
- review: a pass gets at most three rounds per chunk; instead of a fourth, the run asks the human
- review: a reviewer or comprehension seat that rules the work below standard may ask to rerun once, one rung up, in the same round; the ruling that stands is an escalation trigger for the worker, never for the judge
- review: a fix for a 🔴 or 🟡 reruns the pass that found it and each pass whose trigger names fixes like it; from round 2 a pass reviews only the answers to its last round's findings and any other pass's fix that re-entered it; a fix for a 🟢, a ❓ or a prose finding reruns none
- review: the comprehension check records how hard a project is to read and blocks no merge: a paired ruling against the last measured commit where the architecture pass ran, and the four-seat scoring run, done twice on one head, when a release's items run out or an item names the floor
- review: the comprehension check records how hard a project is to read and blocks no merge: a paired ruling against the last measured commit where the architecture pass ran, and the four-seat scoring run, once when an item names the floor and twice on one head when a release's items run out
- review: a project decision may suspend the comprehension check for the plan items it names
- review: a project decision may opt every chunk out of the architect, the product-owner pass or the comprehension check
- review: the principles audit runs on every chunk that changes code, config or tests, and on no other chunk
+3 -2
View File
@@ -107,8 +107,9 @@ def latest_places(history: str) -> str | None:
"""The places seats found hard from the oldest entry on the commit of the newest entry, by time, that is a scoring run or holds scoring seats' places: in it and each later entry, each ruled place opening with a dimension its seat's vote counted as worse, and every scoring seat's place. Each entry's places come under its heading, oldest first; with no such entry, it starts at the oldest entry. None when no place counts."""
found = sorted(entries(history), key=lambda entry: entry.time)
scored = [index for index, entry in enumerate(found) if not entry.paired or entry.scored_places]
newest = next((index for index in scored if found[index].commit == found[scored[-1]].commit), 0)
parts = [placed(entry, worse_places(entry) + labelled_bullets(entry.body, SCORED_PLACES)) for entry in found[newest:]]
newest_commit = found[scored[-1]].commit if scored else None
start = next((index for index in scored if found[index].commit == newest_commit), 0)
parts = [placed(entry, worse_places(entry) + labelled_bullets(entry.body, SCORED_PLACES)) for entry in found[start:]]
return "\n".join(part for part in parts if part) or None
+1 -1
View File
@@ -8,7 +8,7 @@ MIN_PAIRS = 10
def overall_cells(entry: Entry) -> dict[str, str]:
"""Each table row's last non-empty cell, by its first cell: a seat's overall vote in a ruling, its overall score in a scoring run."""
"""Each table row's last non-empty cell, by its first cell: a seat's overall vote in a ruling table, whether it has five votes or the older single `Vote`, or its overall score in a scoring table."""
return {name: cells[-1] for name, cells in table_rows(entry.body).items() if cells and cells[-1]}
+5 -1
View File
@@ -31,6 +31,9 @@ landed when the chunk ships one of the release's items, or when the release is t
default branch's todo.md names and the default branch has a commit after its newest v* tag, or has
no v* tag.
A second scoring run of one head names itself `<PR or branch> rerun at <commit>`, so record-scoring
does not refuse it as a repeat of the first.
A seats file's first line names what the seats read, `<PR or branch> at <commit>`, ending
`, against <base>` in a votes file. Each seat's line follows, opening with its label written
exactly: `Junior A:`, `Mid A:`, `Maintainability senior:` or `Inherited architect:`. Its places
@@ -66,7 +69,8 @@ record-scoring takes the scores file of a run needs-scoring-run calls, whose fir
and their means, rounded half up to two decimals, prints the means and, when a mean is under the
floor of {floor}, a line opening `Floor:` naming each one.
places prints the places seats found hard since the newest scoring run: that run's places, and,
places prints the places seats found hard since the newest scored commit: the places of each scoring
run on it, and,
in each later ruling, each place opening with a dimension, or Overall, that its seat voted worse.
A ruling recorded with scoring seats' places counts as a scoring run. Each entry's places come
under its heading, oldest first. With no scoring run, it reads every ruling.
+1
View File
@@ -19,6 +19,7 @@ def scoring_run_due(before: list[Item], after: list[Item], ships: list[int], lan
next_release = min((item.release for item in before), default=None)
for release in emptied(before, after, shipped):
if any(item.release == release for item in shipped) or (release == next_release and landed):
# SKILL.md → "Second run" keys on this wording.
reasons.append(f"leaves release {'.'.join(map(str, release))} with no plan item")
return reasons
+1 -1
View File
@@ -74,7 +74,7 @@ Valid while the ladder orders its rungs by competence.
2026-10-13, lilleman through todo item 97, implemented by claude: from round 2 a pass reviews only how the chunk answered its previous round, each fix and each dismissal with its reason, and reports only one that is plainly wrong or worse than the change it answered. A fix from another pass that re-enters it is still reviewed as a first round would review it, limited to its lines. Reviewing all that changed had a reviewer find new gaps in each round's fixes, so a pass ran to its cap. Serves goals 1.4 and 1.5. Valid while round-2 findings outside a round's answers keep changing nothing a user would notice.
## review: the comprehension check records how hard a project is to read and blocks no merge: a paired ruling against the last measured commit where the architecture pass ran, and the four-seat scoring run, done twice on one head, when a release's items run out or an item names the floor
## review: the comprehension check records how hard a project is to read and blocks no merge: a paired ruling against the last measured commit where the architecture pass ran, and the four-seat scoring run, once when an item names the floor and twice on one head when a release's items run out
2026-10-08, lilleman. Serves goals 1.1 and 1.4. Two independent four-seat runs moved up to 0.4 on near-identical code, so a fall within that noise forced rounds that changed nothing (PR #224). A seat reading both versions judges the difference on the same material, so the noise the versions share cancels. No conventional significance level lets a sign test settle with four votes, so the human chose a lead of two votes over every other ruling, same included. Two seats that agree settle it, so a PR that leaves the reading as it was costs two seats. A third seat alone can never settle it, so the third and fourth launch together. The human chose the last measured commit on the architect's finding that with a merge base as the base, chunks without an architecture pass, and a suspended restructure's steps, could each lower comprehension unseen. Reading the default branch one merged change at a time keeps the rule working for merge commits and squash merges alike. The scoring run also runs on a chunk shipping an item that names the floor, so the chunk that lifts a project to the floor can prove it. A chunk that removes a release's last item without shipping it runs it too, so no release ends unmeasured. Valid while seats reading both versions agree more often than two absolute runs do.
+1 -1
View File
@@ -120,7 +120,7 @@ The comprehension check records how hard the project is to read, and blocks no m
**Record.** `docs/comprehension-history.md` keeps every paired ruling and scoring run, which `larv-review` appends; never edit one. Commit what it appends in one commit titled `Record the comprehension check: …`, push it, and wait for the forge's checks (§4 step 4), not for an auto-review; it re-enters no pass. Resolve a merge conflict in the file by putting the default branch's entries first. Put each ruling with its base and votes, and each run's five scores, in the summary.
**Places.** Give systems-architect and stability-reviewer what `~/.claude/bin/larv-review places` prints: the places seats found hard since the newest scoring run. Ask each to report, as a 🟡, each of those places the change touches without making it easier to read, matching a place by its path and the function or section it names, since its line may have moved. Fix such a 🟡, or say in the PR summary why not; that reason settles it in place of a decline's record.
**Places.** Give systems-architect and stability-reviewer what `~/.claude/bin/larv-review places` prints: the places seats found hard since the newest scored commit. Ask each to report, as a 🟡, each of those places the change touches without making it easier to read, matching a place by its path and the function or section it names, since its line may have moved. Fix such a 🟡, or say in the PR summary why not; that reason settles it in place of a decline's record.
**Suspended.** A decision in the project's `docs/decisions.md`, held before the chunk began, may name plan items to ship without a comprehension check. A named item counts as `todo.md` worded it before the chunk began. The decision must name the later plan item whose chunk ends the suspension with a comprehension check. A chunk may ship named items only with each other. Such a chunk skips the comprehension check, and its summary cites the decision. A chunk due a scoring run runs it, even when every item it ships is named.