Record the comprehension check: PR #513 paired ruling is better; say what a floor item is in the docstrings
CI / tests (pull_request) Successful in 2m43s

This commit was merged in pull request #513.
This commit is contained in:
2026-11-12 21:22:57 +01:00
parent d5a9576fff
commit e705fd8867
3 changed files with 22 additions and 1 deletions
+1 -1
View File
@@ -17,7 +17,7 @@ EMPTIED_WORDS = "with no plan item"
def scoring_run_due(before: list[Item], after: list[Item], ships: list[int], landed_release: Release | None, renamed: set[Release], unmeasured: str | None = None) -> list[str] | Failure:
"""Why the plan calls a scoring run, empty when it does not.
A chunk that ships an item naming the floor is due one, so it can prove the floor met. So is a chunk that empties a release after work has landed towards it, so no release ends unmeasured. A release the chunk's plan marks renamed is due none. A chunk after a release `unmeasured_cut` names is due one too, so a release cut with no scoring run is caught up.
A chunk that ships a floor item is due one, so it can prove the floor met. So is a chunk that empties a release after work has landed towards it, so no release ends unmeasured. A release the chunk's plan marks renamed is due none. A chunk after a release `unmeasured_cut` names is due one too, so a release cut with no scoring run is caught up.
before is the default branch's plan and after the chunk's. ships holds the IDs of the items the chunk ships. landed_release is the next release where work has landed towards it, else None (`landed_towards`). renamed holds the releases the chunk's plan marks renamed. unmeasured is `unmeasured_cut`'s answer.
"""
+1
View File
@@ -8,6 +8,7 @@ FLOOR_ITEM = "Reach the comprehension floor:"
def is_floor_item(item: Item) -> bool:
"""Whether the item's tagline, which keeps its `**` bold markers, opens with FLOOR_ITEM."""
return item.tagline.removeprefix("**").startswith(FLOOR_ITEM)
+20
View File
@@ -3657,3 +3657,23 @@ Inherited architect, decided by:
- Navigation, Locality: `bin/larv_review/main.py:211` `COMMANDS`: each subcommand's spelling, argument check and action sit in one row that usage and `--help` are built from
- Locality: `bin/transcript_archive/outcomes.py:63` `spent_block`: the writer sits beside the marker and parser, and the loop no longer depends on the measuring package for an archive format
- Shape: `bin/model_routing/prices.py:1` `prices`: the price list moved out of `routing_figures` once it gained a second reader, and its docstring states both uses
## 2026-11-12T20:22:47Z, PR #513 at d5a9576, against 0a26bcb
Ruling: better
| Seat | Navigation | Locality | Shape | Self-sufficiency | Overall |
|---|---|---|---|---|---|
| Mid A | same | better | same | same | better |
| Inherited architect | same | better | better | same | better |
Mid A, decided by:
- Locality, Overall: `bin/larv_review/scoring.py:10` `is_floor_item`: the rule for what makes a plan item a floor item lives in one named predicate that both callers use, where 0a26bcb wrote the same test out twice
- Locality: `bin/larv_review/plan.py:28` `scoring_run_due`: reads `is_floor_item(item)` and prints `a floor item`, so the trigger needs no knowledge of the tagline's format
Inherited architect, decided by:
- Locality, Shape, Overall: `bin/larv_review/scoring.py:10` `is_floor_item`: one named predicate that both `scoring_run_due` and `floor_step` call, where each spelled its own substring test at 0a26bcb
- Shape: `bin/larv_review/scoring.py:7` `FLOOR_ITEM`: the constant is now the tagline's opening phrase and matched as one, where it was a bare substring that any mention matched
- Locality: `bin/larv_review/plan.py:28` `scoring_run_due`: the reason line reads off the predicate, so the function no longer carries tagline matching