Record the comprehension check: PR #510 scores Overall 6.00; refresh floor item 300
CI / tests (pull_request) Failing after 2m39s
CI / tests (pull_request) Failing after 2m39s
This commit is contained in:
@@ -3528,3 +3528,54 @@ Inherited architect, would restructure first:
|
||||
- Locality: `bin/chunk_pr/main.py:42` `forge`: the forge helpers live in `chunk_preflight` and `deploy_release`, so a second forge needs edits in four packages
|
||||
- Shape: `bin/records/__init__.py:1` `records`: one name for three concepts, as `cut` and `Plan` also name several
|
||||
- Locality: `bin/loop_claude/cycle/run.py:86` `archived`: the archive helpers that `loop/close.py` imports sit in the cycle runner
|
||||
|
||||
## 2026-11-12T18:40:20Z, PR #510 at 62faf32
|
||||
|
||||
| Seat | Navigation | Locality | Shape | Self-sufficiency | Overall |
|
||||
|---|---|---|---|---|---|
|
||||
| Junior A | 6.5 | 5 | 5.5 | 4.5 | 5.5 |
|
||||
| Mid A | 7 | 6 | 6.5 | 5 | 6 |
|
||||
| Maintainability senior | 7 | 6 | 6 | 5 | 6 |
|
||||
| Inherited architect | 6.5 | 7.5 | 6 | 5.5 | 6.5 |
|
||||
| Mean | 6.75 | 6.13 | 6.00 | 5.00 | 6.00 |
|
||||
|
||||
Junior A, hardest first:
|
||||
|
||||
- Locality, Shape: `bin/loop_claude/routing.py:84` `next_route`: item rung, floor, cap, escalation mark and unfinished count spread over four modules, and the reasons sit in the decision log
|
||||
- Locality: `bin/loop_claude/cycle/judge.py:196` `quotes_checked`: each check silently demotes the verdict's type, and `INTERRUPT_RULES` is policy held as a prompt string
|
||||
- Locality, Shape: `bin/loop_claude/cycle/run.py:154` `rule`: one function reads, judges, archives and steps up in an order a comment alone states
|
||||
- Self-sufficiency: `skills/larv-review/SKILL.md:35` "Passes": about 200 lines of nested conditions whose terms are defined at the end of CLAUDE.md
|
||||
- Shape: `bin/larv_review/main.py:173` `main`: a 150-line docstring doubles as the spec of about 12 subcommands in one elif chain
|
||||
- Locality, Shape: `bin/release_plan/ranking.py:304` `score`: two table shapes and a hidden comprehension-history input
|
||||
- Locality: `bin/larv_review/scoring_setup.py:156` `prepare_scoring`: code parses two Markdown files, so a prose edit can break it
|
||||
|
||||
Mid A, hardest first:
|
||||
|
||||
- Locality, Shape: `bin/loop_claude/routing.py:84` `next_route`: rung, floor, cap, mark and unfinished count feed one choice across four files
|
||||
- Self-sufficiency: `skills/larv-review/SKILL.md:76` "Round cap": a rule engine in English whose numbers are repeated in code, CLAUDE.md and `--help`
|
||||
- Locality: `bin/loop_claude/cycle/prompts.py:61` `review_launches`: the worker's text is assembled from rung choices and has to be run in the head
|
||||
- Shape: `bin/command_lines/shell_command.py:46` `segments`: a hand-written shell tokenizer whose regexes stay opaque
|
||||
- Locality: `bin/rule_hook/repeat_read.py:119` `shown_lines`: depends on Claude Code's transcript format
|
||||
- Locality: `bin/loop_claude/cycle/judge.py:196` `quotes_checked`: five quote checks with different failure modes
|
||||
- Shape: `bin/release_plan/release_standing.py:145` `next_release`: many tag, rename and changelog cases in a six-way union
|
||||
- Shape: `reviewer-merge-trials/driver.py:1` `driver`: one-off scripts that break the repo's tab and naming conventions
|
||||
|
||||
Maintainability senior, hardest first:
|
||||
|
||||
- Locality, Shape: `bin/release_plan/release_standing.py:145` `next_release`: six cases held at once, `Cut` against `cut`, and a compound `is_earliest` condition
|
||||
- Shape: `bin/release_plan/ranking.py:304` `score`: `SHAPE` against `OLD_SHAPE` threaded through nearly every function
|
||||
- Locality: `bin/loop_claude/routing.py:84` `next_route`: rung arithmetic split with `escalation_mark.py`
|
||||
- Locality: `bin/loop_claude/cycle/judge.py:196` `quotes_checked`: each layer silently downgrades the verdict
|
||||
- Locality, Shape: `bin/loop_claude/cycle/run.py:154` `rule`: order-dependent steps and a 17-field `Cycle`
|
||||
- Locality: `bin/larv_review/main.py:173` `main`: the scoring-run rule is split over `plan.py`, unopened siblings and a wording match with SKILL.md
|
||||
- Self-sufficiency: `skills/larv-review/SKILL.md:76` "Round cap": mechanical rules duplicated in three code places, so no copy is authoritative
|
||||
|
||||
Inherited architect, would restructure first:
|
||||
|
||||
- Navigation, Shape: `README.md:96` `bin/`: about 100 entries at one level, with the README's two lists as the only map
|
||||
- Locality: `bin/review_rules/round_titles.py:1` `ROUND`: the commit-title protocol is parsed in five tools and written in SKILL.md
|
||||
- Shape: `bin/release_plan/release_standing.py:41` `Next`: `Next`, `Cut` and `LastCut` each carry more than one meaning
|
||||
- Shape: `bin/records/__init__.py:1` `records`: one name for two unrelated concepts, and "plan" and "ruling" also name several
|
||||
- Locality: `bin/loop_claude/cycle/judge.py:196` `quotes_checked`: the judge's rules are strings coupled to CLAUDE.md's text
|
||||
- Shape: `bin/rule_hook/rules.py:127` `check`: round-cap rules sit beside unrelated pin rules in 13 rules
|
||||
- Self-sufficiency: `bin/loop_claude/routing.py:84` `next_route`: the reasons cite decision titles the reader cannot see
|
||||
|
||||
@@ -36,7 +36,7 @@
|
||||
| 273 | 0.11.0 | | decision | **Re-tune the E + I steps of `REVIEW_STEPS` for 6 to 8 once 10 finished chunks have scored an E + I of 6 or more, from how well E + I orders their review rounds and 🔴 findings.** | 1 | 2 | 2 | 3 | 2 | 1.1 by 2, 1.4 by 3 | 2.3 |
|
||||
| 268 | 0.11.0 | | | **End a run whose release is ready to cut with a notice on loop-claude's terminal, in place of an interrupt that waits for an answer.** | 2 | 2 | 3 | 5 | 3 | 1 by 5 | 2.2 |
|
||||
| 171 | 0.11.0 | | decision | **Group the routing figures' review rounds by the reviewers' rung as well as the worker's, so a call blames a rung only for rounds its own reviews raised.** | 3 | 2 | 2 | 5 | 4 | 1.2 by 3, 1.4 by 3 | 2.0 |
|
||||
| 300 | 0.11.0 | | owner | **Restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality first: today the comprehension floor run at 52da15e scored Locality 6.00, Shape 6.25, Self-sufficiency 6.38 and Overall 6.38.** | 4 | 2 | 3 | 7 | 8 | code health by 8 | 2.0 |
|
||||
| 300 | 0.11.0 | | owner | **Restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Self-sufficiency first: today the comprehension floor run at 62faf32 scored Navigation 6.75, Locality 6.13, Shape 6.00, Self-sufficiency 5.00 and Overall 6.00.** | 4 | 2 | 3 | 7 | 8 | code health by 8 | 2.0 |
|
||||
| 264 | 0.11.0 | | | **Report the comprehension seats and the escalated subagents as subagent types of their own in `routing-figures.md`, with their dollars.** | 2 | 2 | 1 | 3 | 3 | 1.4 by 5 | 2.0 |
|
||||
| 323 | 0.11.0 | | | **Count a release review as landed once its pull request has merged, whatever its commits are titled.** | 3 | 2 | 3 | 6 | 3 | 1.4 by 3, 1.5 by 2 | 2.0 |
|
||||
| 342 | 0.11.0 | | | **Research the tooling agents read, search and run commands with once more, and file an item for each tool that cuts tokens a replay shows keep quality.** | 1 | 2 | 1 | 2 | 3 | 1.4 by 3, 1.5 by 2 | 2.0 |
|
||||
@@ -242,9 +242,9 @@ Releases are the human's, and `CLAUDE.md` → "Working loop" already ends the lo
|
||||
|
||||
Raised by the goals audit of PR #296. `bin/routing_figures/calls.py` groups a chunk's review rounds by the rung its worker started on, and calls for a routing change when a lower rung took more of them. Since PR #296 the reviewers may run above the worker's rung, on the one their item's E + I picks, and no figure groups rounds by it, though the archived worker line names the E + I it follows from. A cheap worker on an item of high E + I gets stronger reviewers, who may raise more rounds, and a call could then blame the worker's rung for them: an interrupt of lilleman that settles nothing (goal 1.2).
|
||||
|
||||
### 300. Restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality first: today the comprehension floor run at 52da15e scored Locality 6.00, Shape 6.25, Self-sufficiency 6.38 and Overall 6.38.
|
||||
### 300. Restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Self-sufficiency first: today the comprehension floor run at 62faf32 scored Navigation 6.75, Locality 6.13, Shape 6.00, Self-sufficiency 5.00 and Overall 6.00.
|
||||
|
||||
Filed by the comprehension check of PR #473 at 13d1550 (`larv-review record-scoring`), which printed `Floor:` and `Next:`, and refreshed from the run of PR #475 at 52da15e. The lowest mean is Locality, 6.00. Refresh this item's places and aim from the newest run before the chunk starts; do not file a second floor item.
|
||||
Filed by the comprehension check of PR #473 at 13d1550 (`larv-review record-scoring`), which printed `Floor:` and `Next:`, and refreshed from the run of PR #510 at 62faf32. The lowest mean is Self-sufficiency, 5.00: all four seats name a reason that sits in `docs/decisions.md`, `CLAUDE.md`'s "Vocabulary" or `skills/larv-review/SKILL.md` rather than beside the code. Refresh this item's places and aim from the newest run before the chunk starts; do not file a second floor item.
|
||||
|
||||
Aim: one ambitious refactor of the areas below, sized so every mean reaches 7.0 on the chunk's own scoring run. Where a place is already easier to read when the chunk starts, drop it.
|
||||
|
||||
@@ -268,6 +268,11 @@ Places the seats named, hardest first (`larv-review places`):
|
||||
- Shape: `bin/rule_hook/rules.py:25` `RULES`: rules sit inline in one module while five others have a module each.
|
||||
- Navigation, Shape: `README.md:116` `bin/`: about 64 entries in one flat list, some 35 of them packages, the worst fan-out level.
|
||||
- Self-sufficiency: `skills/larv-review/SKILL.md:147` "Scoring run": dense rule prose with many cross-references; three sections rebuild one rule.
|
||||
- Locality: `bin/review_rules/round_titles.py:1` `ROUND`: the commit-title protocol `Answer <pass> round <n>: …` is parsed in `round_titles.py`, `rule_hook/round_cap.py`, `score_outcomes`, `branch_chunks` and `routing_figures`, and written in SKILL.md.
|
||||
- Locality: `bin/larv_review/scoring_setup.py:156` `prepare_scoring`: code parses the headings and fences of SKILL.md and `seat-prompts.md`, so a prose edit can break it.
|
||||
- Shape: `bin/command_lines/shell_command.py:46` `segments`: a hand-written shell tokenizer whose regexes stay opaque.
|
||||
- Shape: `reviewer-merge-trials/driver.py:1` `driver`: one-off trial scripts space-indented and tersely named, against the repo's tabs and naming.
|
||||
- Self-sufficiency: the seats on this run name the decision-log titles that code cites for a constant's reason (`routing: …` in `routing.py`, `ladder.py`, `judge.py`) as the largest cost; state each reason beside its constant.
|
||||
|
||||
Scored L 4 because the refactor touches several components that hold known defects, E 2 because review and a manual check see a regression, I 3 because every session runs these tools. The chunk runs a scoring run, since its tagline names the comprehension floor.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user