Pin the disproof's record, the round cap per chunk in Vocabulary, and drop larv-review's duplicate severity rules
This commit is contained in:
@@ -6,15 +6,15 @@ A reviewer reads and reports; it edits nothing. Read `docs/decisions.md` first:
|
||||
|
||||
## Severity
|
||||
|
||||
- 🔴 **must fix** — a goal, a principle or correctness broken. Fixed, or shown factually wrong; never declined.
|
||||
- 🔴 **must fix** — a goal, a principle or correctness broken. Fixed, or shown factually wrong, with what disproved it recorded in `docs/decisions.md`; never declined.
|
||||
- 🟡 **should fix** — worse than it needs to be. Fixed, or declined.
|
||||
- 🟢 **nit** — fixed if cheap; never holds a pass.
|
||||
- 🟢 **nit** — never holds a pass.
|
||||
- ❓ **question** for the author: a finding you could not confirm goes here, not above.
|
||||
- 🔀 **escalation** — names the reviewer whose concern it is (`product-owner-reviewer`, `systems-architect` or `/security-review`) and why, in one line. The orchestrator runs it.
|
||||
|
||||
Other reviewers map onto this scale:
|
||||
|
||||
- `/security-review`: HIGH is 🔴, MEDIUM 🟡, LOW 🟢. A HIGH shown not real is recorded with what disproved it.
|
||||
- `/security-review`: HIGH is 🔴, MEDIUM 🟡, LOW 🟢.
|
||||
- A forge's auto-reviewer: what it marks blocking is 🔴.
|
||||
|
||||
## Verdict
|
||||
@@ -29,9 +29,9 @@ A review's first line, derived from the findings:
|
||||
|
||||
- Surface everything in round 1.
|
||||
- From round 2 the prompt carries the previous round's findings verbatim and what changed since. Verify each earlier 🔴 and 🟡 is resolved — re-run the scenario, never trust the claim — then review what changed. A fix raises a new finding only where the fix itself introduced a real problem.
|
||||
- A pass is done on no 🔴 and no 🟡. The 🟢 and ❓ left are addressed in that round — fixed, answered, declined or filed in `todo.md` — and take no further round, unless a fix changes behaviour.
|
||||
- Round cap: a pass runs at most three times per chunk, re-entries included. A fourth run lists what is open and asks the human.
|
||||
- A pass is done on no 🔴 and no 🟡. The 🟢 and ❓ left are addressed in that round — fixed, answered, declined or filed in `todo.md` — and take no further round, unless a fix changes behaviour: that takes one.
|
||||
- Round cap: a pass runs at most three times per chunk, re-entries included. Instead of a fourth, list what is open and ask the human.
|
||||
|
||||
## Declining
|
||||
|
||||
A 🟡 or below may be declined where the reason is sound, consistent with the goals, and confidence is very high. The decline, its reason and the goal it rests on go to `docs/decisions.md`, with the human's decisions and answers to ❓; an unrecorded one is asked again next review. A reason no goal speaks to is a gap in the goals, taken per `~/.claude/CLAUDE.md` → "Ask, don't guess" — or fix the finding. Never a silent drop, and never a decline argued from convenience or the size of the fix.
|
||||
A 🟡 or below may be declined where the reason is sound, consistent with the goals, and confidence is very high. The decline, its reason and the goal it rests on go to `docs/decisions.md`; an unrecorded one is raised again next review. A reason no goal speaks to is a gap in the goals: fix the finding, or ask per `~/.claude/CLAUDE.md` → "Ask, don't guess", which also says where an answer to a ❓ lands. Never a silent drop, and never a decline argued from convenience or the size of the fix.
|
||||
|
||||
Reference in New Issue
Block a user