larvit/adf-codec
3
0
Fork 0
mirror of https://github.com/larvit/adf-codec.git synced 2026-11-13 04:08:29 +01:00
Code Activity

Answer stability round 2: a link slot keeps a linked image linked, so the link-in-link refusal holds

Browse Source
This commit is contained in:
Lilleman auf Larv
2026-10-09 03:52:24 +02:00
committed by Lillem4n
parent c3c624f66e
commit 050364dbdc
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/markdown/parse/inline-content.ts
+2 -2
View File
@@ -299,7 +299,7 @@ function pushNode(scan: Scan, node: AdfNode): void {
}
function assemble(scan: Scan): Result<Scanned> {
const nodes = resolveNodes(scan.inLink ? scan.pieces : scan.pieces.map(linkedAlt), scan, true)
const nodes = resolveNodes(scan.pieces.map((piece) => (scan.inLink && piece.kind === 'image' && piece.link === undefined ? piece : linkedAlt(piece))), scan, true)
if (!nodes.ok) return nodes
const [only] = scan.pieces
return success(scan.pieces.length === 1 && only?.kind === 'image' ? { image: mediaSingle(only), nodes: nodes.value } : { nodes: nodes.value })
@@ -549,7 +549,7 @@ function mergeReadText(items: readonly Inline[]): Inline[] {
return merged
}
// The image arm is an image inside an image's description or a link's text, which reads as its plain alt text: `assemble` links every other.
// The image arm is an image inside an image's description or a link's text, which reads as its plain alt text.
// A highlight delimiter holds an empty text node until it pairs, so the emphasis around it marks it.
function pieceNodes(piece: Piece): Inline[] {
switch (piece.kind) {
src/markdown/parse/markdown-to-adf.test.ts
+2
View File
@@ -985,6 +985,7 @@ test('reads a lone image as the media the flavour spells for it', () => {
assert.deepEqual(content(losslessMarkdownToAdf('![](/u)\n')), [image('/u')])
assert.deepEqual(content(losslessMarkdownToAdf('![*a*](/u)\n')), [image('/u', 'a')])
assert.deepEqual(content(losslessMarkdownToAdf('- ![a](/u)\n')), [bulletList(item(image('/u', 'a')))])
assert.deepEqual(content(losslessMarkdownToAdf('> ![a](/u)\n')), [quote(image('/u', 'a'))])
})
test('flattens the description of a lone image to the plain text alt holds', () => {
@@ -1040,6 +1041,7 @@ test('reads an image inside a link not alone in its paragraph as plain alt text
const unspellable = { attrs: { href: 'a\nb' }, type: 'link' }
assert.deepEqual(firstContent('!adf:link[b ![a](/u)]{href="a\\nb"}\n'), [marked('b a', unspellable)])
assert.deepEqual(firstContent('!adf:link[!adf:underline[![a](/u)]]{href="a\\nb"}\n'), [marked('a', unspellable, { type: 'underline' })])
assert.equal(content(losslessMarkdownToAdf('!adf:link[x [![a](/u)](/v)]{href="a\\nb"}\n')), 'unsupported-node-shape: no link wraps a link: the [content] this one marks already holds one')
})
test('carries the mark a spelling nested inside its own kind names once', () => {