3
0
mirror of https://github.com/larvit/adf-codec.git synced 2026-11-18 22:25:44 +01:00

Answer prose round 1: 0 🔴, 3 🟡; rewrite the Line comment and two test names, and name the markdown in the changelog entry

This commit is contained in:
2026-10-18 12:08:29 +02:00
committed by Lillem4n
parent bc18533e8e
commit df7bc0b266
3 changed files with 8 additions and 8 deletions
+1 -1
View File
@@ -23,7 +23,7 @@
- Every reader takes time linear in the markdown when it holds blank lines under list items nested
deeply. Such a list is still refused as `unsupported-nesting-depth`, now after 40 ms where 20000
nested items and as many blank lines took 10.7 seconds.
- Every reader takes time linear in the markdown when it holds tab-indented lines under list items
- Every reader takes time linear in the markdown when tab-indented lines sit under list items
nested deeply. Such a list is still refused as `unsupported-nesting-depth`, now after 107 ms where
20 lines of 40000 tabs under 80000 nested items took 1988 ms.
- `losslessMarkdownToAdf` takes time linear in the markdown when an inline directive's `[content]`
+2 -2
View File
@@ -165,7 +165,7 @@ function outline(blocks: readonly Block[]): string {
.join(' ')
}
test('reads a marker a tab pushes to four columns past its container as text, not as a marker', () => {
test('reads a marker a tab indents four or more columns into its container as text', () => {
const read = (markdown: string): string => outline(parseBlocks(markdown, flavourClaims.lossless).blocks)
assert.equal(read('> a\n \t> b\n'), 'quote(paragraph(a|> b))')
assert.equal(read('> > a\n>\t\t> b\n'), 'quote(quote(paragraph(a|> b)))')
@@ -173,7 +173,7 @@ test('reads a marker a tab pushes to four columns past its container as text, no
assert.equal(read('x\n\t# h\n'), 'paragraph(x|# h)')
})
test('gives what follows an item the columns of the tab a cut splits', () => {
test("keeps as spaces the columns a tab holds past an item's indentation", () => {
const read = (markdown: string): string => outline(parseBlocks(markdown, flavourClaims.lossless).blocks)
assert.equal(read('- ```\n\tx\n ```\n'), 'list(code(" x"))')
assert.equal(read('- a\n \t- b\n'), 'list(paragraph(a) list(paragraph(b)))')
+5 -5
View File
@@ -62,10 +62,10 @@ type ContainerStart = { kind: 'blockquote'; rest: Line } | { fresh: boolean; ind
type ParagraphLine = { position: SourcePosition; text: string }
// The line from an absolute column on: a tab a cut splits keeps the stop it is measured against, and its leftover columns
// stand as `spaces` before `text`, so a cut shares `text`. At most 3, and blank, so blankness reads `text` alone. A cut of
// `largestOpenerIndentation` leaves some only on a line indented as code, which no marker follows: a marker check reads
// `spaces` first, and a block takes the line through `lineText`.
// The line from an absolute column on, so a tab after a cut still measures its stop. When a cut splits a tab, its leftover
// columns, at most 3 and all blank, go in `spaces` rather than in a new `text`. Blankness reads `text` alone, and a block
// reads the line through `lineText`. After a `largestOpenerIndentation` cut, `spaces` is non-zero only on a line indented as
// code, so a marker check no code-indent guard precedes, as in `blockquoteRest`, refuses such a line.
type Line = { column: number; spaces: number; text: string }
type LeafOpener = { index: number; position: SourcePosition }
@@ -621,7 +621,7 @@ function leadingColumns(line: Line, upTo = Infinity): number {
return columns
}
// CommonMark's tab stops: a tab the cut splits leaves the columns it holds past the cut as `spaces`.
// CommonMark's tab stops.
function removeColumns(line: Line, columns: number): Line {
const target = line.column + columns
if (line.spaces >= columns) return { column: target, spaces: line.spaces - columns, text: line.text }