larvit/adf-codec
3
0
Fork 0
Code Pull Requests Actions Activity

21 - the ADF tables carry ADF's nouns #119

Merged
lilleman merged 3 commits from item-21 into main 2026-09-21 22:05:17 +02:00
Conversation 0 Commits 3 Files Changed 17
+130 -109
lilleman commented 2026-09-21 21:40:01 +02:00
Owner
Copy Link
Copy Source

The ADF node tables move out from under the markdown flavour's word: adf/block-nodes.ts and adf/inline-nodes.ts, holding blockNodes and inlineNodes — spec/flavour.md's own headings. Each row is a BlockNodeModel or InlineNodeModel, read by blockNodeModel/inlineNodeModel and named model at call sites: the row is the node's model, never the node, which AdfNode already names. markdown-to-adf.ts's own blockNodes/blockNode walk became readBlocks/readBlock so the table's name means one thing repo-wide. markdown/'s blockDirectiveForm, blockArgument and the spell*Directive* family keep the word — they name the spelling, not the node.

The ADF node tables move out from under the markdown flavour's word: `adf/block-nodes.ts` and `adf/inline-nodes.ts`, holding `blockNodes` and `inlineNodes` — `spec/flavour.md`'s own headings. Each row is a `BlockNodeModel` or `InlineNodeModel`, read by `blockNodeModel`/`inlineNodeModel` and named `model` at call sites: the row is the node's model, never the node, which `AdfNode` already names. `markdown-to-adf.ts`'s own `blockNodes`/`blockNode` walk became `readBlocks`/`readBlock` so the table's name means one thing repo-wide. `markdown/`'s `blockDirectiveForm`, `blockArgument` and the `spell*Directive*` family keep the word — they name the spelling, not the node.
lilleman added 1 commit 2026-09-21 21:40:01 +02:00
21 - the ADF tables carry ADF's nouns
CI / gate (push) Successful in 29s
Details
CI / publish (push) Has been skipped
Details
c2acee7a1d
lilleman marked the pull request as work in progress 2026-09-21 21:40:11 +02:00
lilleman added 1 commit 2026-09-21 21:41:17 +02:00
21 - the parse walk reads blocks, so no name means two things
CI / gate (push) Successful in 30s
Details
CI / publish (push) Has been skipped
Details
7f290d220d
lilleman added 1 commit 2026-09-21 21:45:13 +02:00
21 - the table's row is the node's model, never the node
CI / gate (push) Successful in 29s
Details
CI / publish (push) Successful in 5s
Details
67c3345fd2
lilleman marked the pull request as ready for review 2026-09-21 22:05:16 +02:00
lilleman merged commit 67c3345fd2 into main 2026-09-21 22:05:17 +02:00
lilleman deleted branch item-21 2026-09-21 22:05:17 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/adf-codec#119
Delete Branch "item-21"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?