Make markdownToAdf(adfToMarkdown(doc)) deep-equal doc #156

Merged

lilleman merged 67 commits from deep-equal-round-trip into main 2026-10-03 17:56:46 +02:00

Conversation 0 Commits 67 Files Changed 104

+2019 -553

lilleman commented 2026-10-03 12:31:50 +02:00

Owner

Copy Link

Copy Source

Item 40. The lossless round-trip now holds under deep equality: !adf:textBreak{} parts adjacent text, empty keys spell as {attrs=empty} / {content=empty} / {marks=empty}, -0 survives, the block carry fence names its type (adf:<type>), and a code block of several text nodes is one fence per node. Empty markdown reads as a document with empty content. Adds the markdown's readers and writers to the audience and the standing writer-panel rule.

Item 40. The lossless round-trip now holds under deep equality: `!adf:textBreak{}` parts adjacent text, empty keys spell as `{attrs=empty}` / `{content=empty}` / `{marks=empty}`, `-0` survives, the block carry fence names its type (`adf:<type>`), and a code block of several text nodes is one fence per node. Empty markdown reads as a document with empty content. Adds the markdown's readers and writers to the audience and the standing writer-panel rule.

lilleman added 5 commits 2026-10-03 12:31:51 +02:00

Name the markdown's readers and writers in the audience, and the panel rule bfc4b2ce00

Make markdownToAdf(adfToMarkdown(doc)) deep-equal doc: textBreak, empty keys, -0, typed carry fences, code blocks of several text nodes 9ab7286e6d

Record deep equality, the text break, empty keys, -0, the typed carry fence and per-node code fences; file items 52 and 53 f180943edf

Name the code block the carry now holds in the migration's error codes 1d0ae695da

Name the writer panel behind the doc spelling 0c507f981f

lilleman marked the pull request as work in progress 2026-10-03 12:31:54 +02:00

lilleman added 7 commits 2026-10-03 14:24:24 +02:00

Keep one merge loop and one mark key: editor-normal compares normalized marks with identicalMark fdbf43398c

Carry the text break as its own item, not a fake node, and check it where the outermost content resolves 70e2639982

Keep an empty stored document empty in the migration recipe afb53ca594

Refuse a carry fence naming a type no info string carries back eab28ae8ff

Index a plain refusal's path in the caller's document: normalize only the reduction's output 1458b09449

Say only the plain writer is editor-normal, and read plain markdown in the tests without normalizing 0bc19238b4

File item 54: the source-parting decision misses an import parse/ takes from emit/ 3da45a9da7

lilleman added 2 commits 2026-10-03 14:34:13 +02:00

Write the same plain markdown for documents the editor holds equal: normalize the reduction's input again, naming a refusal by the caller's document 20a191e7e9

Set up every inline scan through one freshScan 45f1bee94b

lilleman added 1 commit 2026-10-03 14:34:31 +02:00

Give the comprehension panel its fill-ins 9f0f520afd

lilleman added 12 commits 2026-10-03 14:47:44 +02:00

Cite item 43 as what ends the CommonMark carve-outs and the adf: fence reservation a5238e4fe5

Name the adf: fence among the carve-outs, and the way a fence stays code in its errors 723c0e31ef

Take the raw run's refusal path only where its code matches the editor-normal refusal 31576bb824

Hold a carried node's own marks on the item, not in a side set copies fall out of ade3997cfd

Spell 'a text node holding its text and marks alone' once, as isPlainText a565d49c24

Keep the browser leg on dist/index.js: tag -0 in the JSON it hands back 2d02165702

Derive a block directive's empty content from its node, and let readEmptyKeys own the attrs=empty-stands-alone rule d9c3e4b349

Spell the doc directive's content=none through spellAttributes from one constant 2700184e56

Read a carry fence's type in one function c3bc2eb572

Drop empty keys in the property harness through emptyKeys bba2fa409e

Keep format knowledge out of mergeAdjacentText's comment d7ba8e6aae

Name plainMarkdownToAdf in the empty-markdown changelog entry b9760d0af2

lilleman added 1 commit 2026-10-03 14:47:59 +02:00

File the audits' pre-existing findings, and mark item 43 cited by decisions 423dcbbff5

lilleman added 11 commits 2026-10-03 15:07:31 +02:00

Refuse attrs=empty on a code block whose fences carry its language 6fc0d6bba9

Pin the empty fence beside another as an error fixture 0ac5dccf11

Drop the as const on the doc directive's attribute 5a7279059d

Inline the identity blocks() helper in the plain reader tests ff9bb7fab2

Pin a code block holding content=empty beside its language 4d7e8c944c

Say equality is deep over the document's JSON values 419bbcb4f2

Tell migrators an empty stored document gets content: [], and what an adf: fence refuses d9f2d325ca

Lead the refusals ordinary editing meets with the edit that fixes them 5cffe82dd5

Name the code block wrapper in the two carry-fence refusals that lacked it fb78063f12

Rewrap the broken lines, and say plainly how an adf: fence stays code 912c5039aa

Keep the fence wrapper's code span on one line 79d9b4db53

lilleman added 5 commits 2026-10-03 15:15:04 +02:00

Lead the code block, empty-key, carry fence, text break and carry-in-mark refusals with their fix 7846502a1a

Trim two comments 230d590fb4

Keep the decisions to their reasons and link the grammar; name the bare adf: fence's refusal exactly; call the doc panel a writer panel e4eecebeab

Define the writer panel, split the carry fence into its own changelog entry, and say how an adf: fence stays code a2c620da27

Reword item 53's tagline 608ef266ed

lilleman added 7 commits 2026-10-03 15:55:32 +02:00

Reword the attrs=empty and language-placement refusals, quoting a language that needs it d68f311a14

Final wording: the reserved-directive refusal row, the adf:-alone fence, the changelog's carry and scope, the developer panel, the migration's empty shape 4349df9017

Gather the plain flavour's code in markdown/plain/ 6df17a7069

Name the two text-joining rules for whose rule they are, side by side in adjacent-text.ts 4579f32fcd

Keep 'carry' for the opaque carry: holdsOnlyAttributes, spellEdgeWhitespace, bothCommonMark 1d3a020926

Name the emitter's block walk PlacedBlocks, apart from the parser's Walk d0cb63fcf2

Ship under the comprehension floor with the panel's scores as the baseline, and file items 59-62 that end it b39525cad7

lilleman added 1 commit 2026-10-03 16:12:10 +02:00

Prose round 3: retitle the floor decision, put the plain/ exception first, sharpen items 59-62 7f67998c3b

lilleman added 9 commits 2026-10-03 16:24:33 +02:00

File the round-4 goals audit's defects and widen items 55 and 62 79005f07be

Widen item 56 to the inline scanner's Scan f7d2eb6517

Rename isPlainText to isBareText, apart from the plain flavour, and say truly what it admits 1791542b3c

Hold the editor's join rule in plain/editor-normal.ts as the reader's over editor-normal forms 36604b1e2b

Keep near-miss text pairs apart in the property harness: merge only what the reader joins d56e5b4f57

Name the reader's own-marks items for what they hold, and drop the carry flag the items already say fd3452b124

Give the unmarked bare text check and the text-holding-content refusal one owner each 00c89dd63b

Keep an empty doc content in editor-normal ADF, as the schema requires 7bab478729

Cut the empty-key and -0 grammar from the decisions into the spec, and cite item 65 as what ends the image gap eccfd12d2d

lilleman added 6 commits 2026-10-03 17:54:43 +02:00

Say which emitter refuses which text node in item 55 317262b240

Join only content-free text nodes in editor-normal ADF, type checked first: adfToPlainMarkdown on 3,000 extension blocks of 200-key parameters 1,752-1,941 ms → 1,034-1,240 ms (1,018-1,283 ms at 608ef26) ee9a7e7562

Reword the isBareText and adfNodes comments 7b38eba29e

Take round 5 as the comprehension baseline, and tighten four decision sentences 8287a483db

Sharpen items 55, 62, 63, 64 and 65 80a45b69da

Leave Flavour's move to item 59 alone 31d3f53a58

lilleman marked the pull request as ready for review 2026-10-03 17:56:44 +02:00

lilleman merged commit 31d3f53a58 into main 2026-10-03 17:56:46 +02:00

lilleman deleted branch deep-equal-round-trip 2026-10-03 17:56:47 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

claes.eismar.se lilleman (Lilleman auf Larv) martin.siden

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: larvit/adf-codec#156