larvit/adf-codec
3
0
Fork 0
Code Pull Requests Activity

Refuse a cyclic input as not-an-adf-document #159

Merged
lilleman merged 18 commits from cyclic-input into main 2026-10-04 19:36:20 +02:00
Conversation 0 Commits 18 Files Changed 7
+67 -17
lilleman commented 2026-10-04 16:57:58 +02:00
Owner
Copy Link
Copy Source

A document holding itself, through a node's content or an attribute, is refused as not-an-adf-document where the guards walked forever. Item 63.

A document holding itself, through a node's content or an attribute, is refused as `not-an-adf-document` where the guards walked forever. Item 63.
lilleman added 1 commit 2026-10-04 16:57:59 +02:00
Refuse a cyclic input as not-an-adf-document
CI / gate (push) Successful in 53s
CI / publish (push) Has been skipped
f9f863fb28
lilleman added 10 commits 2026-10-04 17:18:07 +02:00
Answer security round 1: clean bf610fc438
Answer stability round 1: nits moot once the walks revert 438bf8876b
Answer product-owner round 1: name the cycle in its own message and in the error table addef08fa4
Answer prose round 1: CHANGELOG states what isAdfDocument returns 261dc3a5cf
Answer stability round 2: refuse a node or mark holding a key it does not own 9778844c11
Answer product-owner round 2: the cycle message names any object b9fa9bff85
Answer prose round 2: the cycle message, README row and CHANGELOG say an object e501b95cb3
Answer stability round 3: walk an array's elements as the guards do d26e4e8152
Answer product-owner round 3: CHANGELOG names the own-key refusal 638881b555
Answer prose round 3: the ownsWhatItHolds comment names any other key
CI / gate (push) Successful in 54s
CI / publish (push) Has been skipped
fb0d2b4eac
lilleman added 4 commits 2026-10-04 19:21:14 +02:00
Record the guards' input boundary and Goal 8's size as JSON, and drop the hardening past it 58a9c89dfc
Answer stability round 4: the decision's title backs the loop guarantee alone, item 66 filed 9f23c89719
Answer product-owner round 4: the guarantee names strings 2f0ab4dda9
Answer prose round 4: the premise says plain data, Goal 8's size is stated once
CI / gate (push) Successful in 55s
CI / publish (push) Has been skipped
e8733068ab
lilleman added 3 commits 2026-10-04 19:35:14 +02:00
Answer product-owner round 5: item 66 is a defect 758549ab24
Answer prose round 5: nits declined 5a9fd06974
Answer stability round 5: clean
CI / gate (push) Successful in 55s
CI / publish (push) Successful in 5s
bfbe4a51fb
lilleman marked the pull request as ready for review 2026-10-04 19:36:20 +02:00
lilleman merged commit bfbe4a51fb into main 2026-10-04 19:36:20 +02:00
lilleman deleted branch cyclic-input 2026-10-04 19:36:20 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/adf-codec#159
Delete Branch "cyclic-input"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?